[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/8] sdcard: Display command name when tracing C
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 2/8] sdcard: Display command name when tracing CMD/ACMD |
Date: |
Fri, 9 Mar 2018 15:47:33 +0000 |
On 9 March 2018 at 15:36, Philippe Mathieu-Daudé <address@hidden> wrote:
> The SDBus will reuse these functions, so we put them in a new source file.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/sd/sdmmc-internal.h | 20 ++++++++++++++
> hw/sd/sd.c | 13 +++++----
> hw/sd/sdmmc-internal.c | 72
> ++++++++++++++++++++++++++++++++++++++++++++++++++
> hw/sd/Makefile.objs | 2 +-
> hw/sd/trace-events | 8 +++---
> 5 files changed, 105 insertions(+), 10 deletions(-)
> create mode 100644 hw/sd/sdmmc-internal.c
>
> diff --git a/hw/sd/sdmmc-internal.h b/hw/sd/sdmmc-internal.h
> index 0e96cb0081..bf6fb06128 100644
> --- a/hw/sd/sdmmc-internal.h
> +++ b/hw/sd/sdmmc-internal.h
> @@ -12,4 +12,24 @@
>
> #define SDMMC_CMD_MAX 64
>
> +/**
> + * sd_cmd_name:
> + * @cmd: A SD "normal" command, upto SDMMC_CMD_MAX.
> + *
> + * Returns an human useful name describing the command.
> + *
> + * Returns: The command name of @cmd or "UNKNOWN_CMD".
> + */
> +const char *sd_cmd_name(uint8_t cmd);
> +
> +/**
> + * sd_acmd_name:
> + * @cmd: A SD "Application-Specific" command, upto SDMMC_CMD_MAX.
> + *
> + * Returns an human useful name describing the application command.
> + *
> + * Returns: The application command name of @cmd or "UNKNOWN_ACMD".
> + */
> +const char *sd_acmd_name(uint8_t cmd);
> +
"up to", and "a human-readable name". Otherwise:
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-devel] [PATCH 0/8] SDCard: improve tracing, support UHS-I, Philippe Mathieu-Daudé, 2018/03/09
- [Qemu-devel] [PATCH 1/8] sdcard: Do not trace CMD55, except when we already expect an ACMD, Philippe Mathieu-Daudé, 2018/03/09
- [Qemu-devel] [PATCH 2/8] sdcard: Display command name when tracing CMD/ACMD, Philippe Mathieu-Daudé, 2018/03/09
- Re: [Qemu-devel] [PATCH 2/8] sdcard: Display command name when tracing CMD/ACMD,
Peter Maydell <=
- [Qemu-devel] [PATCH 4/8] sdcard: Add the Tuning Command (CMD19), Philippe Mathieu-Daudé, 2018/03/09
- [Qemu-devel] [PATCH 6/8] sdcard: Add a 'uhs' property, update the OCR register ACCEPT_SWITCH_1V8 bit, Philippe Mathieu-Daudé, 2018/03/09
- [Qemu-devel] [PATCH 7/8] sdhci: Fix a typo in comment, Philippe Mathieu-Daudé, 2018/03/09
- [Qemu-devel] [PATCH 3/8] sdcard: Display which protocol is used when tracing (SD or SPI), Philippe Mathieu-Daudé, 2018/03/09
- [Qemu-devel] [PATCH 5/8] sdcard: Implement the UHS-I SWITCH_FUNCTION entries (Spec v3), Philippe Mathieu-Daudé, 2018/03/09