[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 15/22] hw/isa/superio: Factor out the FDC
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 15/22] hw/isa/superio: Factor out the FDC37M817 Super I/O from mips_malta.c |
Date: |
Thu, 8 Mar 2018 21:43:08 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 03/05/2018 10:19 PM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> include/hw/isa/superio.h | 2 ++
> hw/isa/isa-superio.c | 20 ++++++++++++++++++++
> hw/mips/mips_malta.c | 35 ++++++++++-------------------------
> 3 files changed, 32 insertions(+), 25 deletions(-)
>
> diff --git a/include/hw/isa/superio.h b/include/hw/isa/superio.h
> index 3dd5448f8c..b47aac3cf8 100644
> --- a/include/hw/isa/superio.h
> +++ b/include/hw/isa/superio.h
> @@ -54,4 +54,6 @@ typedef struct ISASuperIOClass {
> ISASuperIOFuncs ide;
> } ISASuperIOClass;
>
> +#define TYPE_FDC37M81X_SUPERIO "fdc37m81x-superio"
> +
> #endif /* HW_ISA_SUPERIO_H */
> diff --git a/hw/isa/isa-superio.c b/hw/isa/isa-superio.c
> index 88d254a602..f1f699fc2f 100644
> --- a/hw/isa/isa-superio.c
> +++ b/hw/isa/isa-superio.c
> @@ -182,9 +182,29 @@ static const TypeInfo isa_superio_type_info = {
> .class_init = isa_superio_class_init,
> };
>
> +/* SMS FDC37M817 Super I/O */
> +static void fdc37m81x_class_init(ObjectClass *klass, void *data)
> +{
> + ISASuperIOClass *sc = ISA_SUPERIO_CLASS(klass);
> +
> + sc->serial.count = 2; /* NS16C550A */
> + sc->parallel.count = 1;
> + sc->floppy.count = 1; /* SMSC 82077AA Compatible */
> + sc->ide.count = 0;
> +}
> +
> +static const TypeInfo fdc37m81x_type_info = {
> + .name = TYPE_FDC37M81X_SUPERIO,
> + .parent = TYPE_ISA_SUPERIO,
> + .instance_size = sizeof(ISASuperIODevice),
> + .class_size = sizeof(ISASuperIOClass),
> + .class_init = fdc37m81x_class_init,
> +};
> +
> static void isa_superio_register_types(void)
> {
> type_register_static(&isa_superio_type_info);
> + type_register_static(&fdc37m81x_type_info);
> }
>
> type_init(isa_superio_register_types)
> diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
> index 9e0724ca5a..f6513a4fd5 100644
> --- a/hw/mips/mips_malta.c
> +++ b/hw/mips/mips_malta.c
> @@ -27,14 +27,12 @@
> #include "cpu.h"
> #include "hw/hw.h"
> #include "hw/i386/pc.h"
> +#include "hw/isa/superio.h"
> #include "hw/dma/i8257.h"
> #include "hw/char/serial.h"
> -#include "hw/char/parallel.h"
> -#include "hw/block/fdc.h"
> #include "net/net.h"
> #include "hw/boards.h"
> #include "hw/i2c/smbus.h"
> -#include "sysemu/block-backend.h"
> #include "hw/block/flash.h"
> #include "hw/mips/mips.h"
> #include "hw/mips/cpudevs.h"
> @@ -47,7 +45,6 @@
> #include "hw/loader.h"
> #include "elf.h"
> #include "hw/timer/mc146818rtc.h"
> -#include "hw/input/i8042.h"
> #include "hw/timer/i8254.h"
> #include "sysemu/blockdev.h"
> #include "exec/address-spaces.h"
> @@ -1005,10 +1002,8 @@ void mips_malta_init(MachineState *machine)
> qemu_irq cbus_irq, i8259_irq;
> int piix4_devfn;
> I2CBus *smbus;
> - int i;
> DriveInfo *dinfo;
> DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS];
> - DriveInfo *fd[MAX_FD];
> int fl_idx = 0;
> int fl_sectors = bios_size >> 16;
> int be;
> @@ -1023,15 +1018,6 @@ void mips_malta_init(MachineState *machine)
>
> qdev_init_nofail(dev);
>
> - /* Make sure the first 3 serial ports are associated with a device. */
> - for(i = 0; i < 3; i++) {
> - if (!serial_hds[i]) {
> - char label[32];
> - snprintf(label, sizeof(label), "serial%d", i);
> - serial_hds[i] = qemu_chr_new(label, "null");
> - }
> - }
> -
> /* create CPU */
> mips_create_cpu(s, machine->cpu_type, &cbus_irq, &i8259_irq);
>
> @@ -1067,7 +1053,14 @@ void mips_malta_init(MachineState *machine)
> #else
> be = 0;
> #endif
> +
> /* FPGA */
> +
> + /* Make sure the second serial port is associated with a device. */
> + if (!serial_hds[2]) {
> + serial_hds[2] = qemu_chr_new("fpga-uart", "null");
> + }
> +
> /* The CBUS UART is attached to the MIPS CPU INT2 pin, ie interrupt 4 */
> malta_fpga_init(system_memory, FPGA_ADDRESS, cbus_irq, serial_hds[2]);
>
> @@ -1214,16 +1207,8 @@ void mips_malta_init(MachineState *machine)
> smbus_eeprom_init(smbus, 8, smbus_eeprom_buf, smbus_eeprom_size);
> g_free(smbus_eeprom_buf);
>
> - /* Super I/O */
> - isa_create_simple(isa_bus, TYPE_I8042);
> -
> - serial_hds_isa_init(isa_bus, 0, 2);
> - parallel_hds_isa_init(isa_bus, 1);
> -
> - for(i = 0; i < MAX_FD; i++) {
> - fd[i] = drive_get(IF_FLOPPY, 0, i);
> - }
> - fdctrl_init_isa(isa_bus, fd);
> + /* Super I/O: SMS FDC37M817 */
> + isa_create_simple(isa_bus, TYPE_FDC37M81X_SUPERIO);
>
> /* Network card */
> network_init(pci_bus);
>
Booting Aurelien Malta Linux image with this series applied, the console
is identical (also 'info mtree' in monitor).
- [Qemu-devel] [RFC PATCH v2 08/22] hw/isa/pc87312: Inherit from the abstract TYPE_ISA_SUPERIO, (continued)
- [Qemu-devel] [RFC PATCH v2 08/22] hw/isa/pc87312: Inherit from the abstract TYPE_ISA_SUPERIO, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-devel] [RFC PATCH v2 09/22] hw/isa/superio: Factor out the parallel code from pc87312.c, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-devel] [RFC PATCH v2 12/22] hw/isa/superio: Add a keyboard/mouse controller (8042), Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-devel] [RFC PATCH v2 10/22] hw/isa/superio: Factor out the serial code from pc87312.c, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-devel] [RFC PATCH v2 11/22] hw/isa/superio: Factor out the floppy disc controller code from pc87312.c, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-devel] [RFC PATCH v2 13/22] hw/isa/superio: Factor out the IDE code from pc87312.c, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-devel] [RFC PATCH v2 14/22] hw/mips/malta: Code movement, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-devel] [RFC PATCH v2 15/22] hw/isa/superio: Factor out the FDC37M817 Super I/O from mips_malta.c, Philippe Mathieu-Daudé, 2018/03/05
- Re: [Qemu-devel] [RFC PATCH v2 15/22] hw/isa/superio: Factor out the FDC37M817 Super I/O from mips_malta.c,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [RFC PATCH v2 16/22] hw/mips/mips_fulong2e: Factor out vt82c686b_southbridge_init(), Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-devel] [RFC PATCH v2 18/22] hw/isa/vt82c686: Add the TYPE_VT82C686B_SUPERIO, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-devel] [RFC PATCH v2 17/22] hw/isa/vt82c686: Rename vt82c686b_init() -> vt82c686b_isa_init(), Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-devel] [RFC PATCH v2 19/22] hw/isa/superio: Add the SMC FDC37C669 Super I/O, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-devel] [RFC PATCH v2 20/22] hw/alpha/dp264: Add the ISA DMA controller, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-devel] [RFC PATCH v2 21/22] hw/alpha/dp264: Use the TYPE_SMC37C669_SUPERIO, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-devel] [RFC PATCH v2 22/22] hw/i386/pc: Factor out the superio code, Philippe Mathieu-Daudé, 2018/03/05