[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 17/23] qapi: introduce new cmd option "allow-
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v7 17/23] qapi: introduce new cmd option "allow-oob" |
Date: |
Thu, 8 Mar 2018 19:51:49 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Thu, Mar 08, 2018 at 11:04:13AM +0100, Igor Mammedov wrote:
[...]
> > diff --git a/include/qapi/qmp/dispatch.h b/include/qapi/qmp/dispatch.h
> > index 20578dcd48..b76798800c 100644
> > --- a/include/qapi/qmp/dispatch.h
> > +++ b/include/qapi/qmp/dispatch.h
> > @@ -23,6 +23,7 @@ typedef enum QmpCommandOptions
> > {
> > QCO_NO_OPTIONS = 0x0,
> > QCO_NO_SUCCESS_RESP = 0x1,
> > + QCO_ALLOW_OOB = 0x2,
> Options are essentially bitmask,
> so using shift for value would be more explicit way to express it.
>
> QCO_ALLOW_OOB = (1U << 1)
I'll squash the change into the patch:
diff --git a/include/qapi/qmp/dispatch.h b/include/qapi/qmp/dispatch.h
index b4cb25888f..26eb13ff41 100644
--- a/include/qapi/qmp/dispatch.h
+++ b/include/qapi/qmp/dispatch.h
@@ -20,9 +20,9 @@ typedef void (QmpCommandFunc)(QDict *, QObject **, Error **);
typedef enum QmpCommandOptions
{
- QCO_NO_OPTIONS = 0x0,
- QCO_NO_SUCCESS_RESP = 0x1,
- QCO_ALLOW_OOB = 0x2,
+ QCO_NO_OPTIONS = 0x0,
+ QCO_NO_SUCCESS_RESP = (1U << 0),
+ QCO_ALLOW_OOB = (1U << 1),
} QmpCommandOptions;
typedef struct QmpCommand
Since the change is trivial, I'll keep r-bs for Stefan and Fam.
Anyone who thinks I shouldn't please shoot. Thanks,
--
Peter Xu