[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [edk2] [PATCH v2 1/8] SecurityPkg: also clear HashInter
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [edk2] [PATCH v2 1/8] SecurityPkg: also clear HashInterfaceHob.SupportedHashMask |
Date: |
Thu, 8 Mar 2018 12:40:20 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 03/07/18 16:57, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
>
> Commit 4cc2b63bd829426b05bad0d8952f1855a10d6ed7 fixed an out of bounds
> ZeroMem() call. However, as Laszlo Ersek pointed out, the intent was
> to clear all but the Identifier (to revert the effect of
> RegisterHashInterfaceLib()). For that, it should clear the
> SupportedHashMask too.
>
> Cc: Jiewen Yao <address@hidden>
> Cc: Chao Zhang <address@hidden>
> Cc: Star Zeng <address@hidden>
> Cc: Laszlo Ersek <address@hidden>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> .../Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c
> b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c
> index 361a4f6508a0..bf6e1336ee76 100644
> --- a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c
> +++ b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c
> @@ -426,6 +426,7 @@ HashLibBaseCryptoRouterPeiConstructor (
> //
> ZeroMem (&HashInterfaceHob->HashInterface, sizeof
> (HashInterfaceHob->HashInterface));
> HashInterfaceHob->HashInterfaceCount = 0;
> + HashInterfaceHob->SupportedHashMask = 0;
> }
>
> //
>
Reviewed-by: Laszlo Ersek <address@hidden>
Thanks,
Laszlo
- Re: [Qemu-devel] [edk2] [PATCH v2 3/8] MdeModulePkg: fix REGISITER -> REGISTER, (continued)
- [Qemu-devel] [PATCH v2 2/8] SecurityPkg/Tcg2Pei: drop PeiReadOnlyVariable from Depex, marcandre . lureau, 2018/03/07
- [Qemu-devel] [PATCH v2 4/8] ovmf: simplify SecurityStubDxe.inf inclusion, marcandre . lureau, 2018/03/07
- [Qemu-devel] [PATCH v2 1/8] SecurityPkg: also clear HashInterfaceHob.SupportedHashMask, marcandre . lureau, 2018/03/07
- [Qemu-devel] [PATCH v2 5/8] ovmf: add OvmfPkg Tcg2ConfigPei module, marcandre . lureau, 2018/03/07
- [Qemu-devel] [PATCH v2 6/8] ovmf: link with Tcg2Pei module, marcandre . lureau, 2018/03/07
- [Qemu-devel] [PATCH v2 7/8] ovmf: link with Tcg2Dxe module, marcandre . lureau, 2018/03/07
- [Qemu-devel] [PATCH v2 8/8] ovmf: add DxeTpm2MeasureBootLib, marcandre . lureau, 2018/03/07