qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 05/12] hw/pci: introduce PCISVAOps to PCIDevi


From: Liu, Yi L
Subject: Re: [Qemu-devel] [PATCH v3 05/12] hw/pci: introduce PCISVAOps to PCIDevice
Date: Mon, 5 Mar 2018 16:11:43 +0800
User-agent: Mutt/1.5.21 (2010-09-15)

On Fri, Mar 02, 2018 at 04:10:48PM +0100, Paolo Bonzini wrote:
> On 01/03/2018 11:33, Liu, Yi L wrote:
> > +void pci_setup_sva_ops(PCIDevice *dev, PCISVAOps *ops)
> > +{
> > +    if (dev) {
> > +        dev->sva_ops = ops;
> > +    }
> > +    return;
> > +}
> > +
> 
> Better:
> 
> {
>     assert(ops && !dev->sva_ops);
>     dev->sva_ops = ops;
> }

Thanks, would apply in next version.

Regards,
Yi Liu



reply via email to

[Prev in Thread] Current Thread [Next in Thread]