[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] s390x/sclpconsole: Remove dead code - make _err
|
From: |
Cornelia Huck |
|
Subject: |
Re: [Qemu-devel] [PATCH] s390x/sclpconsole: Remove dead code - make _error functions void |
|
Date: |
Mon, 5 Mar 2018 09:28:18 +0100 |
On Mon, 5 Mar 2018 09:07:17 +0100
Christian Borntraeger <address@hidden> wrote:
> On 03/04/2018 02:45 PM, Nia Alarie wrote:
> > These functions always return 0. By changing their return type to
> > void, some dead code can be removed.
>
> the event facility part looks ok, but I am asking myself if we should
> go a step further.
> Do we need the exit callback at all? We can certainly keep it for reasons of
> symmetry
> but it looks like the other event handlers (quiesce and cpu) do not define it
> at all.
> I addition to that, I have a hard time imagine a usecase for such an exit
> handler.
Agreed. I think we should just remove them.
[I dimly remember having that discussion before...]