Re: [Qemu-devel] [PATCH qemu v3 1/2] qmp: Merge ObjectPropertyInfo and DevicePropertyInfo

[Eric Blake]

On 03/02/2018 07:42 AM, Paolo Bonzini wrote:
> On 02/03/2018 14:37, Eric Blake wrote:
> > > index 0262b9f..87327e5 100644
> > > --- a/qapi-schema.json
> > > +++ b/qapi-schema.json
> > > @@ -1266,10 +1266,12 @@
> > >    #        3) A link type in the form 'link<subtype>' where subtype is
> > > a qdev
> > >    #           device type name.  Link properties form the device model
> > > graph.
> > >    #
> > > +# @description: if specified, the description of the property.
> >
> > Missing a '(since 2.12)' tag.
>
> Some of the users had it (in other types that are now unified) before
> 2.12.  I'm not sure whether it is more accurate to have the annotation
> or not, especially considering that it is optional.  Protocol-wise it is
> never an issue to add optional fields, since you cannot distinguish an
> implementation that lacks the field from one that never fills it.

True; you could write it as '(since 2.2)', as that is the earliest 
version that provided the optional field between the structs that you 
are merging.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org