[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/8] qcow2: make qcow2_co_create2() a coroutine_fn
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 2/8] qcow2: make qcow2_co_create2() a coroutine_fn |
Date: |
Thu, 1 Mar 2018 17:36:13 +0100 |
From: Stefan Hajnoczi <address@hidden>
qcow2_create2() calls qemu_co_mutex_lock(). Only a coroutine_fn may
call another coroutine_fn. In fact, qcow2_create2 is always called from
coroutine context.
Rename the function to add the "co" moniker and add coroutine_fn.
Reported-by: Marc-André Lureau <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
block/qcow2.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index d62705d9aa..24edbb431b 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -2700,11 +2700,12 @@ static uint64_t
qcow2_opt_get_refcount_bits_del(QemuOpts *opts, int version,
return refcount_bits;
}
-static int qcow2_create2(const char *filename, int64_t total_size,
- const char *backing_file, const char *backing_format,
- int flags, size_t cluster_size, PreallocMode prealloc,
- QemuOpts *opts, int version, int refcount_order,
- const char *encryptfmt, Error **errp)
+static int coroutine_fn
+qcow2_co_create2(const char *filename, int64_t total_size,
+ const char *backing_file, const char *backing_format,
+ int flags, size_t cluster_size, PreallocMode prealloc,
+ QemuOpts *opts, int version, int refcount_order,
+ const char *encryptfmt, Error **errp)
{
QDict *options;
@@ -2973,9 +2974,9 @@ static int coroutine_fn qcow2_co_create_opts(const char
*filename, QemuOpts *opt
refcount_order = ctz32(refcount_bits);
- ret = qcow2_create2(filename, size, backing_file, backing_fmt, flags,
- cluster_size, prealloc, opts, version, refcount_order,
- encryptfmt, &local_err);
+ ret = qcow2_co_create2(filename, size, backing_file, backing_fmt, flags,
+ cluster_size, prealloc, opts, version,
refcount_order,
+ encryptfmt, &local_err);
error_propagate(errp, local_err);
finish:
--
2.14.3
- [Qemu-devel] [PATCH v4 0/8] Call check and invalidate_cache from coroutine context, Paolo Bonzini, 2018/03/01
- [Qemu-devel] [PATCH 2/8] qcow2: make qcow2_co_create2() a coroutine_fn,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 3/8] qcow2: introduce qcow2_write_caches and qcow2_flush_caches, Paolo Bonzini, 2018/03/01
- [Qemu-devel] [PATCH 1/8] block: rename .bdrv_create() to .bdrv_co_create_opts(), Paolo Bonzini, 2018/03/01
- [Qemu-devel] [PATCH 4/8] qcow2: fix flushing after dirty bitmap metadata writes, Paolo Bonzini, 2018/03/01
- [Qemu-devel] [PATCH 5/8] qcow2: make qcow2_do_open a coroutine_fn, Paolo Bonzini, 2018/03/01
- [Qemu-devel] [PATCH 6/8] qed: make bdrv_qed_do_open a coroutine_fn, Paolo Bonzini, 2018/03/01
- [Qemu-devel] [PATCH 7/8] block: convert bdrv_invalidate_cache callback to coroutine_fn, Paolo Bonzini, 2018/03/01
- [Qemu-devel] [PATCH 8/8] block: convert bdrv_check callback to coroutine_fn, Paolo Bonzini, 2018/03/01