[Qemu-devel] [PATCH v2 0/4] tricore: added small features + fixed wrong masks

[David Brenken]

From: David Brenken <address@hidden>

Hi Bastian,

thank you for your feedback and sorry for the late reply.

Changes from v1:
 * Removed OPC1_16_SB_JNE instruction.
 * Added CPU feature checks to new instructions.
 * Renamed ICR.IE and PCXI.PIE masks and added corresponding TC 1.6 masks.
 * Squashed patch 4/5 and 5/5.

>From the previous implementation I was unable to see that there are 
>architecture differences between TriCore version 1.3 and version 1.6 (e.g. the 
>masking of ICR.IE and PCXI.PIE).
I did not correct the situation technically but with this patch set one will be 
able to recognize the differences. 

My plan is to correct this issue in a future patch series. Inspecting the code 
I recognized that changing only the bit mask of ICR.IE and PCXI.PIE depending 
on the processor version would not solve the problem since also the shifting 
often used in that context depends on the architecure (e.g. in op_helper.c /* 
PCXI.PIE = ICR.IE */). 
Therefore I would create functions for the storing and restoring of ICR.IE. 
These functions would have different implementations for the given processor 
versions.

Best regards

David Brenken
 
 
David Brenken (4):
  tricore: added some missing cpu instructions
  tricore: added CORE_ID
  tricore: renamed masking of IE
  tricore: renamed masking of PIE

 target/tricore/cpu.h             |  7 +++++--
 target/tricore/csfr.def          |  1 +
 target/tricore/op_helper.c       | 29 +++++++++++++++--------------
 target/tricore/translate.c       | 31 +++++++++++++++++++++++++++++--
 target/tricore/tricore-opcodes.h |  3 +++
 5 files changed, 53 insertions(+), 18 deletions(-)

-- 
2.7.4