[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] use g_path_get_basename instead of basename
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] use g_path_get_basename instead of basename |
Date: |
Thu, 1 Mar 2018 12:21:57 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 01/03/2018 11:59, Cornelia Huck wrote:
>>>
>>> Signed-off-by: Julia Suvorova <address@hidden>
>> What about adding a warning for basename()/dirname() usage in
>> scripts/checkpatch.pl ?
> +1 to that.
>
Good idea indeed. Julia, would you like to send a second patch that
adds the warning?
There are already some examples (__FUNCTION__, strto*, signal, etc.)
that you can take inspiration from.
Paolo