qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v7 00/23] RISC-V QEMU Port Submission


From: no-reply
Subject: Re: [Qemu-devel] [PATCH v7 00/23] RISC-V QEMU Port Submission
Date: Mon, 26 Feb 2018 14:57:17 -0800 (PST)

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v7 00/23] RISC-V QEMU Port Submission
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Submodule 'capstone' (git://git.qemu.org/capstone.git) registered for path 
'capstone'
Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (git://git.qemu.org/QemuMacDrivers.git) 
registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (git://git.qemu-project.org/SLOF.git) registered for path 
'roms/SLOF'
Submodule 'roms/ipxe' (git://git.qemu-project.org/ipxe.git) registered for path 
'roms/ipxe'
Submodule 'roms/openbios' (git://git.qemu-project.org/openbios.git) registered 
for path 'roms/openbios'
Submodule 'roms/openhackware' (git://git.qemu-project.org/openhackware.git) 
registered for path 'roms/openhackware'
Submodule 'roms/qemu-palcode' (git://github.com/rth7680/qemu-palcode.git) 
registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (git://git.qemu-project.org/seabios.git/) registered 
for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (git://github.com/hdeller/seabios-hppa.git) 
registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (git://git.qemu-project.org/sgabios.git) registered 
for path 'roms/sgabios'
Submodule 'roms/skiboot' (git://git.qemu.org/skiboot.git) registered for path 
'roms/skiboot'
Submodule 'roms/u-boot' (git://git.qemu-project.org/u-boot.git) registered for 
path 'roms/u-boot'
Submodule 'roms/vgabios' (git://git.qemu-project.org/vgabios.git/) registered 
for path 'roms/vgabios'
Submodule 'ui/keycodemapdb' (git://git.qemu.org/keycodemapdb.git) registered 
for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out 
'22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out 'e54388015af1fb4bf04d0bca99caba1074d9cc42'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out 
'd4e7d7ac663fcb55f1b93575445fcbca372f17a7'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 
'fa981320a1e0968d6fc1b8de319723ff8212b337'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 
'0600d3ae94f93efd10fc6b3c7420a9557a3a1670'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out 
'54d959d97fb331708767b2fd4a878efd2bbc41bb'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 
'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out 
'f3c7e44c70254975df2a00af39701eafbac4d471'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 
'63451fca13c75870e1703eb3e20584d91179aebc'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out 
'649e6202b8d65d46c69f542b1380f840fbe8ab13'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 
'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out 
'e0ee24c27a172bcf482f6f2bc905e6211c134bcc'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 
'd85ca029f257b53a96da6c2fb421e78a003a9943'
Cloning into 'roms/vgabios'...
Submodule path 'roms/vgabios': checked out 
'19ea12c230ded95928ecaef0db47a82231c2e485'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out 
'6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
7e16956 RISC-V Build Infrastructure
d5fc9fa SiFive Freedom U500 RISC-V Machine
0dd0d08 SiFive Freedom E300 RISC-V Machine
6a7084c SiFive RISC-V PRCI Block
bd70435 SiFive RISC-V UART Device
2c8fd79 RISC-V VirtIO Machine
e6f9b74 SiFive RISC-V Test Finisher
70c3ed0 RISC-V Spike Machines
802248e SiFive RISC-V PLIC Block
946a5c4 SiFive RISC-V CLINT Block
e4277c8 RISC-V HART Array
daa1c5a RISC-V HTIF Console
9fa1bfa Add symbol table callback interface to load_elf
c0a6b9d RISC-V Linux User Emulation
effb082 RISC-V Physical Memory Protection
f5f5047 RISC-V TCG Code Generation
e31eba4 RISC-V GDB Stub
d826084 RISC-V FPU Support
18ed15b RISC-V CPU Helpers
1648526 RISC-V Disassembler
8a7023f RISC-V CPU Core Definition
4c792ca RISC-V ELF Machine Definition
7f71438 RISC-V Maintainers

=== OUTPUT BEGIN ===
Checking PATCH 1/23: RISC-V Maintainers...
Checking PATCH 2/23: RISC-V ELF Machine Definition...
Checking PATCH 3/23: RISC-V CPU Core Definition...
Checking PATCH 4/23: RISC-V Disassembler...
WARNING: line over 80 characters
#649: FILE: disas/riscv.c:597:
+static const rvc_constraint rvcc_jalr[] = { rvc_rd_eq_ra, rvc_imm_eq_zero, 
rvc_end };

ERROR: line over 90 characters
#650: FILE: disas/riscv.c:598:
+static const rvc_constraint rvcc_nop[] = { rvc_rd_eq_x0, rvc_rs1_eq_x0, 
rvc_imm_eq_zero, rvc_end };

WARNING: line over 80 characters
#680: FILE: disas/riscv.c:628:
+static const rvc_constraint rvcc_ret[] = { rvc_rd_eq_x0, rvc_rs1_eq_ra, 
rvc_end };

WARNING: line over 80 characters
#681: FILE: disas/riscv.c:629:
+static const rvc_constraint rvcc_jr[] = { rvc_rd_eq_x0, rvc_imm_eq_zero, 
rvc_end };

WARNING: line over 80 characters
#682: FILE: disas/riscv.c:630:
+static const rvc_constraint rvcc_rdcycle[] = { rvc_rs1_eq_x0, 
rvc_csr_eq_0xc00, rvc_end };

WARNING: line over 80 characters
#683: FILE: disas/riscv.c:631:
+static const rvc_constraint rvcc_rdtime[] = { rvc_rs1_eq_x0, rvc_csr_eq_0xc01, 
rvc_end };

ERROR: line over 90 characters
#684: FILE: disas/riscv.c:632:
+static const rvc_constraint rvcc_rdinstret[] = { rvc_rs1_eq_x0, 
rvc_csr_eq_0xc02, rvc_end };

ERROR: line over 90 characters
#685: FILE: disas/riscv.c:633:
+static const rvc_constraint rvcc_rdcycleh[] = { rvc_rs1_eq_x0, 
rvc_csr_eq_0xc80, rvc_end };

WARNING: line over 80 characters
#686: FILE: disas/riscv.c:634:
+static const rvc_constraint rvcc_rdtimeh[] = { rvc_rs1_eq_x0, 
rvc_csr_eq_0xc81, rvc_end };

ERROR: line over 90 characters
#687: FILE: disas/riscv.c:635:
+static const rvc_constraint rvcc_rdinstreth[] = { rvc_rs1_eq_x0, 
rvc_csr_eq_0xc80, rvc_end };

WARNING: line over 80 characters
#688: FILE: disas/riscv.c:636:
+static const rvc_constraint rvcc_frcsr[] = { rvc_rs1_eq_x0, rvc_csr_eq_0x003, 
rvc_end };

WARNING: line over 80 characters
#689: FILE: disas/riscv.c:637:
+static const rvc_constraint rvcc_frrm[] = { rvc_rs1_eq_x0, rvc_csr_eq_0x002, 
rvc_end };

WARNING: line over 80 characters
#690: FILE: disas/riscv.c:638:
+static const rvc_constraint rvcc_frflags[] = { rvc_rs1_eq_x0, 
rvc_csr_eq_0x001, rvc_end };

ERROR: line over 90 characters
#1089: FILE: disas/riscv.c:1037:
+    { "c.addi4spn", rv_codec_ciw_4spn, rv_fmt_rd_rs1_imm, NULL, rv_op_addi, 
rv_op_addi, rv_op_addi },

WARNING: line over 80 characters
#1090: FILE: disas/riscv.c:1038:
+    { "c.fld", rv_codec_cl_ld, rv_fmt_frd_offset_rs1, NULL, rv_op_fld, 
rv_op_fld, 0 },

WARNING: line over 80 characters
#1091: FILE: disas/riscv.c:1039:
+    { "c.lw", rv_codec_cl_lw, rv_fmt_rd_offset_rs1, NULL, rv_op_lw, rv_op_lw, 
rv_op_lw },

WARNING: line over 80 characters
#1093: FILE: disas/riscv.c:1041:
+    { "c.fsd", rv_codec_cs_sd, rv_fmt_frs2_offset_rs1, NULL, rv_op_fsd, 
rv_op_fsd, 0 },

WARNING: line over 80 characters
#1094: FILE: disas/riscv.c:1042:
+    { "c.sw", rv_codec_cs_sw, rv_fmt_rs2_offset_rs1, NULL, rv_op_sw, rv_op_sw, 
rv_op_sw },

WARNING: line over 80 characters
#1096: FILE: disas/riscv.c:1044:
+    { "c.nop", rv_codec_ci_none, rv_fmt_none, NULL, rv_op_addi, rv_op_addi, 
rv_op_addi },

ERROR: line over 90 characters
#1097: FILE: disas/riscv.c:1045:
+    { "c.addi", rv_codec_ci, rv_fmt_rd_rs1_imm, NULL, rv_op_addi, rv_op_addi, 
rv_op_addi },

ERROR: line over 90 characters
#1099: FILE: disas/riscv.c:1047:
+    { "c.li", rv_codec_ci_li, rv_fmt_rd_rs1_imm, NULL, rv_op_addi, rv_op_addi, 
rv_op_addi },

ERROR: line over 90 characters
#1100: FILE: disas/riscv.c:1048:
+    { "c.addi16sp", rv_codec_ci_16sp, rv_fmt_rd_rs1_imm, NULL, rv_op_addi, 
rv_op_addi, rv_op_addi },

WARNING: line over 80 characters
#1101: FILE: disas/riscv.c:1049:
+    { "c.lui", rv_codec_ci_lui, rv_fmt_rd_imm, NULL, rv_op_lui, rv_op_lui, 
rv_op_lui },

ERROR: line over 90 characters
#1102: FILE: disas/riscv.c:1050:
+    { "c.srli", rv_codec_cb_sh6, rv_fmt_rd_rs1_imm, NULL, rv_op_srli, 
rv_op_srli, rv_op_srli },

ERROR: line over 90 characters
#1103: FILE: disas/riscv.c:1051:
+    { "c.srai", rv_codec_cb_sh6, rv_fmt_rd_rs1_imm, NULL, rv_op_srai, 
rv_op_srai, rv_op_srai },

ERROR: line over 90 characters
#1104: FILE: disas/riscv.c:1052:
+    { "c.andi", rv_codec_cb_imm, rv_fmt_rd_rs1_imm, NULL, rv_op_andi, 
rv_op_andi, rv_op_andi },

WARNING: line over 80 characters
#1105: FILE: disas/riscv.c:1053:
+    { "c.sub", rv_codec_cs, rv_fmt_rd_rs1_rs2, NULL, rv_op_sub, rv_op_sub, 
rv_op_sub },

WARNING: line over 80 characters
#1106: FILE: disas/riscv.c:1054:
+    { "c.xor", rv_codec_cs, rv_fmt_rd_rs1_rs2, NULL, rv_op_xor, rv_op_xor, 
rv_op_xor },

WARNING: line over 80 characters
#1107: FILE: disas/riscv.c:1055:
+    { "c.or", rv_codec_cs, rv_fmt_rd_rs1_rs2, NULL, rv_op_or, rv_op_or, 
rv_op_or },

WARNING: line over 80 characters
#1108: FILE: disas/riscv.c:1056:
+    { "c.and", rv_codec_cs, rv_fmt_rd_rs1_rs2, NULL, rv_op_and, rv_op_and, 
rv_op_and },

ERROR: line over 90 characters
#1109: FILE: disas/riscv.c:1057:
+    { "c.subw", rv_codec_cs, rv_fmt_rd_rs1_rs2, NULL, rv_op_subw, rv_op_subw, 
rv_op_subw },

ERROR: line over 90 characters
#1110: FILE: disas/riscv.c:1058:
+    { "c.addw", rv_codec_cs, rv_fmt_rd_rs1_rs2, NULL, rv_op_addw, rv_op_addw, 
rv_op_addw },

WARNING: line over 80 characters
#1111: FILE: disas/riscv.c:1059:
+    { "c.j", rv_codec_cj, rv_fmt_rd_offset, NULL, rv_op_jal, rv_op_jal, 
rv_op_jal },

ERROR: line over 90 characters
#1112: FILE: disas/riscv.c:1060:
+    { "c.beqz", rv_codec_cb, rv_fmt_rs1_rs2_offset, NULL, rv_op_beq, 
rv_op_beq, rv_op_beq },

ERROR: line over 90 characters
#1113: FILE: disas/riscv.c:1061:
+    { "c.bnez", rv_codec_cb, rv_fmt_rs1_rs2_offset, NULL, rv_op_bne, 
rv_op_bne, rv_op_bne },

ERROR: line over 90 characters
#1114: FILE: disas/riscv.c:1062:
+    { "c.slli", rv_codec_ci_sh6, rv_fmt_rd_rs1_imm, NULL, rv_op_slli, 
rv_op_slli, rv_op_slli },

ERROR: line over 90 characters
#1115: FILE: disas/riscv.c:1063:
+    { "c.fldsp", rv_codec_ci_ldsp, rv_fmt_frd_offset_rs1, NULL, rv_op_fld, 
rv_op_fld, rv_op_fld },

ERROR: line over 90 characters
#1116: FILE: disas/riscv.c:1064:
+    { "c.lwsp", rv_codec_ci_lwsp, rv_fmt_rd_offset_rs1, NULL, rv_op_lw, 
rv_op_lw, rv_op_lw },

WARNING: line over 80 characters
#1117: FILE: disas/riscv.c:1065:
+    { "c.flwsp", rv_codec_ci_lwsp, rv_fmt_frd_offset_rs1, NULL, rv_op_flw, 0, 
0 },

ERROR: line over 90 characters
#1118: FILE: disas/riscv.c:1066:
+    { "c.jr", rv_codec_cr_jr, rv_fmt_rd_rs1_offset, NULL, rv_op_jalr, 
rv_op_jalr, rv_op_jalr },

ERROR: line over 90 characters
#1119: FILE: disas/riscv.c:1067:
+    { "c.mv", rv_codec_cr_mv, rv_fmt_rd_rs1_rs2, NULL, rv_op_addi, rv_op_addi, 
rv_op_addi },

ERROR: line over 90 characters
#1120: FILE: disas/riscv.c:1068:
+    { "c.ebreak", rv_codec_ci_none, rv_fmt_none, NULL, rv_op_ebreak, 
rv_op_ebreak, rv_op_ebreak },

ERROR: line over 90 characters
#1121: FILE: disas/riscv.c:1069:
+    { "c.jalr", rv_codec_cr_jalr, rv_fmt_rd_rs1_offset, NULL, rv_op_jalr, 
rv_op_jalr, rv_op_jalr },

WARNING: line over 80 characters
#1122: FILE: disas/riscv.c:1070:
+    { "c.add", rv_codec_cr, rv_fmt_rd_rs1_rs2, NULL, rv_op_add, rv_op_add, 
rv_op_add },

ERROR: line over 90 characters
#1123: FILE: disas/riscv.c:1071:
+    { "c.fsdsp", rv_codec_css_sdsp, rv_fmt_frs2_offset_rs1, NULL, rv_op_fsd, 
rv_op_fsd, rv_op_fsd },

ERROR: line over 90 characters
#1124: FILE: disas/riscv.c:1072:
+    { "c.swsp", rv_codec_css_swsp, rv_fmt_rs2_offset_rs1, NULL, rv_op_sw, 
rv_op_sw, rv_op_sw },

WARNING: line over 80 characters
#1125: FILE: disas/riscv.c:1073:
+    { "c.fswsp", rv_codec_css_swsp, rv_fmt_frs2_offset_rs1, NULL, rv_op_fsw, 
0, 0 },

WARNING: line over 80 characters
#1126: FILE: disas/riscv.c:1074:
+    { "c.ld", rv_codec_cl_ld, rv_fmt_rd_offset_rs1, NULL, 0, rv_op_ld, 
rv_op_ld },

WARNING: line over 80 characters
#1127: FILE: disas/riscv.c:1075:
+    { "c.sd", rv_codec_cs_sd, rv_fmt_rs2_offset_rs1, NULL, 0, rv_op_sd, 
rv_op_sd },

WARNING: line over 80 characters
#1128: FILE: disas/riscv.c:1076:
+    { "c.addiw", rv_codec_ci, rv_fmt_rd_rs1_imm, NULL, 0, rv_op_addiw, 
rv_op_addiw },

WARNING: line over 80 characters
#1129: FILE: disas/riscv.c:1077:
+    { "c.ldsp", rv_codec_ci_ldsp, rv_fmt_rd_offset_rs1, NULL, 0, rv_op_ld, 
rv_op_ld },

WARNING: line over 80 characters
#1130: FILE: disas/riscv.c:1078:
+    { "c.sdsp", rv_codec_css_sdsp, rv_fmt_rs2_offset_rs1, NULL, 0, rv_op_sd, 
rv_op_sd },

WARNING: line over 80 characters
#1134: FILE: disas/riscv.c:1082:
+    { "c.sqsp", rv_codec_css_sqsp, rv_fmt_rs2_offset_rs1, NULL, 0, 0, rv_op_sq 
},

ERROR: trailing statements should be on next line
#1399: FILE: disas/riscv.c:1347:
+        case 0: op = rv_op_c_addi4spn; break;

ERROR: trailing statements should be on next line
#1407: FILE: disas/riscv.c:1355:
+        case 2: op = rv_op_c_lw; break;

ERROR: trailing statements should be on next line
#1422: FILE: disas/riscv.c:1370:
+        case 6: op = rv_op_c_sw; break;

ERROR: trailing statements should be on next line
#1436: FILE: disas/riscv.c:1384:
+            case 0: op = rv_op_c_nop; break;

ERROR: trailing statements should be on next line
#1437: FILE: disas/riscv.c:1385:
+            default: op = rv_op_c_addi; break;

ERROR: trailing statements should be on next line
#1447: FILE: disas/riscv.c:1395:
+        case 2: op = rv_op_c_li; break;

ERROR: trailing statements should be on next line
#1450: FILE: disas/riscv.c:1398:
+            case 2: op = rv_op_c_addi16sp; break;

ERROR: trailing statements should be on next line
#1451: FILE: disas/riscv.c:1399:
+            default: op = rv_op_c_lui; break;

ERROR: trailing statements should be on next line
#1462: FILE: disas/riscv.c:1410:
+            case 2: op = rv_op_c_andi; break;

ERROR: trailing statements should be on next line
#1465: FILE: disas/riscv.c:1413:
+                case 0: op = rv_op_c_sub; break;

ERROR: trailing statements should be on next line
#1466: FILE: disas/riscv.c:1414:
+                case 1: op = rv_op_c_xor; break;

ERROR: trailing statements should be on next line
#1467: FILE: disas/riscv.c:1415:
+                case 2: op = rv_op_c_or; break;

ERROR: trailing statements should be on next line
#1468: FILE: disas/riscv.c:1416:
+                case 3: op = rv_op_c_and; break;

ERROR: trailing statements should be on next line
#1469: FILE: disas/riscv.c:1417:
+                case 4: op = rv_op_c_subw; break;

ERROR: trailing statements should be on next line
#1470: FILE: disas/riscv.c:1418:
+                case 5: op = rv_op_c_addw; break;

ERROR: trailing statements should be on next line
#1475: FILE: disas/riscv.c:1423:
+        case 5: op = rv_op_c_j; break;

ERROR: trailing statements should be on next line
#1476: FILE: disas/riscv.c:1424:
+        case 6: op = rv_op_c_beqz; break;

ERROR: trailing statements should be on next line
#1477: FILE: disas/riscv.c:1425:
+        case 7: op = rv_op_c_bnez; break;

ERROR: trailing statements should be on next line
#1492: FILE: disas/riscv.c:1440:
+        case 2: op = rv_op_c_lwsp; break;

ERROR: trailing statements should be on next line
#1504: FILE: disas/riscv.c:1452:
+                case 0: op = rv_op_c_jr; break;

ERROR: trailing statements should be on next line
#1505: FILE: disas/riscv.c:1453:
+                default: op = rv_op_c_mv; break;

ERROR: trailing statements should be on next line
#1512: FILE: disas/riscv.c:1460:
+                    case 0: op = rv_op_c_ebreak; break;

ERROR: trailing statements should be on next line
#1513: FILE: disas/riscv.c:1461:
+                    default: op = rv_op_c_jalr; break;

ERROR: trailing statements should be on next line
#1516: FILE: disas/riscv.c:1464:
+                default: op = rv_op_c_add; break;

ERROR: trailing statements should be on next line
#1527: FILE: disas/riscv.c:1475:
+        case 6: op = rv_op_c_swsp; break;

ERROR: trailing statements should be on next line
#1541: FILE: disas/riscv.c:1489:
+            case 0: op = rv_op_lb; break;

ERROR: trailing statements should be on next line
#1542: FILE: disas/riscv.c:1490:
+            case 1: op = rv_op_lh; break;

ERROR: trailing statements should be on next line
#1543: FILE: disas/riscv.c:1491:
+            case 2: op = rv_op_lw; break;

ERROR: trailing statements should be on next line
#1544: FILE: disas/riscv.c:1492:
+            case 3: op = rv_op_ld; break;

ERROR: trailing statements should be on next line
#1545: FILE: disas/riscv.c:1493:
+            case 4: op = rv_op_lbu; break;

ERROR: trailing statements should be on next line
#1546: FILE: disas/riscv.c:1494:
+            case 5: op = rv_op_lhu; break;

ERROR: trailing statements should be on next line
#1547: FILE: disas/riscv.c:1495:
+            case 6: op = rv_op_lwu; break;

ERROR: trailing statements should be on next line
#1548: FILE: disas/riscv.c:1496:
+            case 7: op = rv_op_ldu; break;

ERROR: trailing statements should be on next line
#1553: FILE: disas/riscv.c:1501:
+            case 2: op = rv_op_flw; break;

ERROR: trailing statements should be on next line
#1554: FILE: disas/riscv.c:1502:
+            case 3: op = rv_op_fld; break;

ERROR: trailing statements should be on next line
#1555: FILE: disas/riscv.c:1503:
+            case 4: op = rv_op_flq; break;

ERROR: trailing statements should be on next line
#1560: FILE: disas/riscv.c:1508:
+            case 0: op = rv_op_fence; break;

ERROR: trailing statements should be on next line
#1561: FILE: disas/riscv.c:1509:
+            case 1: op = rv_op_fence_i; break;

ERROR: trailing statements should be on next line
#1562: FILE: disas/riscv.c:1510:
+            case 2: op = rv_op_lq; break;

ERROR: trailing statements should be on next line
#1567: FILE: disas/riscv.c:1515:
+            case 0: op = rv_op_addi; break;

ERROR: trailing statements should be on next line
#1570: FILE: disas/riscv.c:1518:
+                case 0: op = rv_op_slli; break;

ERROR: trailing statements should be on next line
#1573: FILE: disas/riscv.c:1521:
+            case 2: op = rv_op_slti; break;

ERROR: trailing statements should be on next line
#1574: FILE: disas/riscv.c:1522:
+            case 3: op = rv_op_sltiu; break;

ERROR: trailing statements should be on next line
#1575: FILE: disas/riscv.c:1523:
+            case 4: op = rv_op_xori; break;

ERROR: trailing statements should be on next line
#1578: FILE: disas/riscv.c:1526:
+                case 0: op = rv_op_srli; break;

ERROR: trailing statements should be on next line
#1579: FILE: disas/riscv.c:1527:
+                case 8: op = rv_op_srai; break;

ERROR: trailing statements should be on next line
#1582: FILE: disas/riscv.c:1530:
+            case 6: op = rv_op_ori; break;

ERROR: trailing statements should be on next line
#1583: FILE: disas/riscv.c:1531:
+            case 7: op = rv_op_andi; break;

ERROR: trailing statements should be on next line
#1586: FILE: disas/riscv.c:1534:
+        case 5: op = rv_op_auipc; break;

ERROR: trailing statements should be on next line
#1589: FILE: disas/riscv.c:1537:
+            case 0: op = rv_op_addiw; break;

ERROR: trailing statements should be on next line
#1592: FILE: disas/riscv.c:1540:
+                case 0: op = rv_op_slliw; break;

ERROR: trailing statements should be on next line
#1597: FILE: disas/riscv.c:1545:
+                case 0: op = rv_op_srliw; break;

ERROR: trailing statements should be on next line
#1598: FILE: disas/riscv.c:1546:
+                case 32: op = rv_op_sraiw; break;

ERROR: trailing statements should be on next line
#1605: FILE: disas/riscv.c:1553:
+            case 0: op = rv_op_sb; break;

ERROR: trailing statements should be on next line
#1606: FILE: disas/riscv.c:1554:
+            case 1: op = rv_op_sh; break;

ERROR: trailing statements should be on next line
#1607: FILE: disas/riscv.c:1555:
+            case 2: op = rv_op_sw; break;

ERROR: trailing statements should be on next line
#1608: FILE: disas/riscv.c:1556:
+            case 3: op = rv_op_sd; break;

ERROR: trailing statements should be on next line
#1609: FILE: disas/riscv.c:1557:
+            case 4: op = rv_op_sq; break;

ERROR: trailing statements should be on next line
#1614: FILE: disas/riscv.c:1562:
+            case 2: op = rv_op_fsw; break;

ERROR: trailing statements should be on next line
#1615: FILE: disas/riscv.c:1563:
+            case 3: op = rv_op_fsd; break;

ERROR: trailing statements should be on next line
#1616: FILE: disas/riscv.c:1564:
+            case 4: op = rv_op_fsq; break;

ERROR: trailing statements should be on next line
#1621: FILE: disas/riscv.c:1569:
+            case 2: op = rv_op_amoadd_w; break;

ERROR: trailing statements should be on next line
#1622: FILE: disas/riscv.c:1570:
+            case 3: op = rv_op_amoadd_d; break;

ERROR: trailing statements should be on next line
#1623: FILE: disas/riscv.c:1571:
+            case 4: op = rv_op_amoadd_q; break;

ERROR: trailing statements should be on next line
#1624: FILE: disas/riscv.c:1572:
+            case 10: op = rv_op_amoswap_w; break;

ERROR: trailing statements should be on next line
#1625: FILE: disas/riscv.c:1573:
+            case 11: op = rv_op_amoswap_d; break;

ERROR: trailing statements should be on next line
#1626: FILE: disas/riscv.c:1574:
+            case 12: op = rv_op_amoswap_q; break;

ERROR: trailing statements should be on next line
#1629: FILE: disas/riscv.c:1577:
+                case 0: op = rv_op_lr_w; break;

ERROR: trailing statements should be on next line
#1634: FILE: disas/riscv.c:1582:
+                case 0: op = rv_op_lr_d; break;

ERROR: trailing statements should be on next line
#1639: FILE: disas/riscv.c:1587:
+                case 0: op = rv_op_lr_q; break;

ERROR: trailing statements should be on next line
#1642: FILE: disas/riscv.c:1590:
+            case 26: op = rv_op_sc_w; break;

ERROR: trailing statements should be on next line
#1643: FILE: disas/riscv.c:1591:
+            case 27: op = rv_op_sc_d; break;

ERROR: trailing statements should be on next line
#1644: FILE: disas/riscv.c:1592:
+            case 28: op = rv_op_sc_q; break;

ERROR: trailing statements should be on next line
#1645: FILE: disas/riscv.c:1593:
+            case 34: op = rv_op_amoxor_w; break;

ERROR: trailing statements should be on next line
#1646: FILE: disas/riscv.c:1594:
+            case 35: op = rv_op_amoxor_d; break;

ERROR: trailing statements should be on next line
#1647: FILE: disas/riscv.c:1595:
+            case 36: op = rv_op_amoxor_q; break;

ERROR: trailing statements should be on next line
#1648: FILE: disas/riscv.c:1596:
+            case 66: op = rv_op_amoor_w; break;

ERROR: trailing statements should be on next line
#1649: FILE: disas/riscv.c:1597:
+            case 67: op = rv_op_amoor_d; break;

ERROR: trailing statements should be on next line
#1650: FILE: disas/riscv.c:1598:
+            case 68: op = rv_op_amoor_q; break;

ERROR: trailing statements should be on next line
#1651: FILE: disas/riscv.c:1599:
+            case 98: op = rv_op_amoand_w; break;

ERROR: trailing statements should be on next line
#1652: FILE: disas/riscv.c:1600:
+            case 99: op = rv_op_amoand_d; break;

ERROR: trailing statements should be on next line
#1653: FILE: disas/riscv.c:1601:
+            case 100: op = rv_op_amoand_q; break;

ERROR: trailing statements should be on next line
#1654: FILE: disas/riscv.c:1602:
+            case 130: op = rv_op_amomin_w; break;

ERROR: trailing statements should be on next line
#1655: FILE: disas/riscv.c:1603:
+            case 131: op = rv_op_amomin_d; break;

ERROR: trailing statements should be on next line
#1656: FILE: disas/riscv.c:1604:
+            case 132: op = rv_op_amomin_q; break;

ERROR: trailing statements should be on next line
#1657: FILE: disas/riscv.c:1605:
+            case 162: op = rv_op_amomax_w; break;

ERROR: trailing statements should be on next line
#1658: FILE: disas/riscv.c:1606:
+            case 163: op = rv_op_amomax_d; break;

ERROR: trailing statements should be on next line
#1659: FILE: disas/riscv.c:1607:
+            case 164: op = rv_op_amomax_q; break;

ERROR: trailing statements should be on next line
#1660: FILE: disas/riscv.c:1608:
+            case 194: op = rv_op_amominu_w; break;

ERROR: trailing statements should be on next line
#1661: FILE: disas/riscv.c:1609:
+            case 195: op = rv_op_amominu_d; break;

ERROR: trailing statements should be on next line
#1662: FILE: disas/riscv.c:1610:
+            case 196: op = rv_op_amominu_q; break;

ERROR: trailing statements should be on next line
#1663: FILE: disas/riscv.c:1611:
+            case 226: op = rv_op_amomaxu_w; break;

ERROR: trailing statements should be on next line
#1664: FILE: disas/riscv.c:1612:
+            case 227: op = rv_op_amomaxu_d; break;

ERROR: trailing statements should be on next line
#1665: FILE: disas/riscv.c:1613:
+            case 228: op = rv_op_amomaxu_q; break;

WARNING: line over 80 characters
#1669: FILE: disas/riscv.c:1617:
+            switch (((inst >> 22) & 0b1111111000) | ((inst >> 12) & 
0b0000000111)) {

ERROR: trailing statements should be on next line
#1670: FILE: disas/riscv.c:1618:
+            case 0: op = rv_op_add; break;

ERROR: trailing statements should be on next line
#1671: FILE: disas/riscv.c:1619:
+            case 1: op = rv_op_sll; break;

ERROR: trailing statements should be on next line
#1672: FILE: disas/riscv.c:1620:
+            case 2: op = rv_op_slt; break;

ERROR: trailing statements should be on next line
#1673: FILE: disas/riscv.c:1621:
+            case 3: op = rv_op_sltu; break;

ERROR: trailing statements should be on next line
#1674: FILE: disas/riscv.c:1622:
+            case 4: op = rv_op_xor; break;

ERROR: trailing statements should be on next line
#1675: FILE: disas/riscv.c:1623:
+            case 5: op = rv_op_srl; break;

ERROR: trailing statements should be on next line
#1676: FILE: disas/riscv.c:1624:
+            case 6: op = rv_op_or; break;

ERROR: trailing statements should be on next line
#1677: FILE: disas/riscv.c:1625:
+            case 7: op = rv_op_and; break;

ERROR: trailing statements should be on next line
#1678: FILE: disas/riscv.c:1626:
+            case 8: op = rv_op_mul; break;

ERROR: trailing statements should be on next line
#1679: FILE: disas/riscv.c:1627:
+            case 9: op = rv_op_mulh; break;

ERROR: trailing statements should be on next line
#1680: FILE: disas/riscv.c:1628:
+            case 10: op = rv_op_mulhsu; break;

ERROR: trailing statements should be on next line
#1681: FILE: disas/riscv.c:1629:
+            case 11: op = rv_op_mulhu; break;

ERROR: trailing statements should be on next line
#1682: FILE: disas/riscv.c:1630:
+            case 12: op = rv_op_div; break;

ERROR: trailing statements should be on next line
#1683: FILE: disas/riscv.c:1631:
+            case 13: op = rv_op_divu; break;

ERROR: trailing statements should be on next line
#1684: FILE: disas/riscv.c:1632:
+            case 14: op = rv_op_rem; break;

ERROR: trailing statements should be on next line
#1685: FILE: disas/riscv.c:1633:
+            case 15: op = rv_op_remu; break;

ERROR: trailing statements should be on next line
#1686: FILE: disas/riscv.c:1634:
+            case 256: op = rv_op_sub; break;

ERROR: trailing statements should be on next line
#1687: FILE: disas/riscv.c:1635:
+            case 261: op = rv_op_sra; break;

ERROR: trailing statements should be on next line
#1690: FILE: disas/riscv.c:1638:
+        case 13: op = rv_op_lui; break;

WARNING: line over 80 characters
#1692: FILE: disas/riscv.c:1640:
+            switch (((inst >> 22) & 0b1111111000) | ((inst >> 12) & 
0b0000000111)) {

ERROR: trailing statements should be on next line
#1693: FILE: disas/riscv.c:1641:
+            case 0: op = rv_op_addw; break;

ERROR: trailing statements should be on next line
#1694: FILE: disas/riscv.c:1642:
+            case 1: op = rv_op_sllw; break;

ERROR: trailing statements should be on next line
#1695: FILE: disas/riscv.c:1643:
+            case 5: op = rv_op_srlw; break;

ERROR: trailing statements should be on next line
#1696: FILE: disas/riscv.c:1644:
+            case 8: op = rv_op_mulw; break;

ERROR: trailing statements should be on next line
#1697: FILE: disas/riscv.c:1645:
+            case 12: op = rv_op_divw; break;

ERROR: trailing statements should be on next line
#1698: FILE: disas/riscv.c:1646:
+            case 13: op = rv_op_divuw; break;

ERROR: trailing statements should be on next line
#1699: FILE: disas/riscv.c:1647:
+            case 14: op = rv_op_remw; break;

ERROR: trailing statements should be on next line
#1700: FILE: disas/riscv.c:1648:
+            case 15: op = rv_op_remuw; break;

ERROR: trailing statements should be on next line
#1701: FILE: disas/riscv.c:1649:
+            case 256: op = rv_op_subw; break;

ERROR: trailing statements should be on next line
#1702: FILE: disas/riscv.c:1650:
+            case 261: op = rv_op_sraw; break;

ERROR: trailing statements should be on next line
#1707: FILE: disas/riscv.c:1655:
+            case 0: op = rv_op_fmadd_s; break;

ERROR: trailing statements should be on next line
#1708: FILE: disas/riscv.c:1656:
+            case 1: op = rv_op_fmadd_d; break;

ERROR: trailing statements should be on next line
#1709: FILE: disas/riscv.c:1657:
+            case 3: op = rv_op_fmadd_q; break;

ERROR: trailing statements should be on next line
#1714: FILE: disas/riscv.c:1662:
+            case 0: op = rv_op_fmsub_s; break;

ERROR: trailing statements should be on next line
#1715: FILE: disas/riscv.c:1663:
+            case 1: op = rv_op_fmsub_d; break;

ERROR: trailing statements should be on next line
#1716: FILE: disas/riscv.c:1664:
+            case 3: op = rv_op_fmsub_q; break;

ERROR: trailing statements should be on next line
#1721: FILE: disas/riscv.c:1669:
+            case 0: op = rv_op_fnmsub_s; break;

ERROR: trailing statements should be on next line
#1722: FILE: disas/riscv.c:1670:
+            case 1: op = rv_op_fnmsub_d; break;

ERROR: trailing statements should be on next line
#1723: FILE: disas/riscv.c:1671:
+            case 3: op = rv_op_fnmsub_q; break;

ERROR: trailing statements should be on next line
#1728: FILE: disas/riscv.c:1676:
+            case 0: op = rv_op_fnmadd_s; break;

ERROR: trailing statements should be on next line
#1729: FILE: disas/riscv.c:1677:
+            case 1: op = rv_op_fnmadd_d; break;

ERROR: trailing statements should be on next line
#1730: FILE: disas/riscv.c:1678:
+            case 3: op = rv_op_fnmadd_q; break;

ERROR: trailing statements should be on next line
#1735: FILE: disas/riscv.c:1683:
+            case 0: op = rv_op_fadd_s; break;

ERROR: trailing statements should be on next line
#1736: FILE: disas/riscv.c:1684:
+            case 1: op = rv_op_fadd_d; break;

ERROR: trailing statements should be on next line
#1737: FILE: disas/riscv.c:1685:
+            case 3: op = rv_op_fadd_q; break;

ERROR: trailing statements should be on next line
#1738: FILE: disas/riscv.c:1686:
+            case 4: op = rv_op_fsub_s; break;

ERROR: trailing statements should be on next line
#1739: FILE: disas/riscv.c:1687:
+            case 5: op = rv_op_fsub_d; break;

ERROR: trailing statements should be on next line
#1740: FILE: disas/riscv.c:1688:
+            case 7: op = rv_op_fsub_q; break;

ERROR: trailing statements should be on next line
#1741: FILE: disas/riscv.c:1689:
+            case 8: op = rv_op_fmul_s; break;

ERROR: trailing statements should be on next line
#1742: FILE: disas/riscv.c:1690:
+            case 9: op = rv_op_fmul_d; break;

ERROR: trailing statements should be on next line
#1743: FILE: disas/riscv.c:1691:
+            case 11: op = rv_op_fmul_q; break;

ERROR: trailing statements should be on next line
#1744: FILE: disas/riscv.c:1692:
+            case 12: op = rv_op_fdiv_s; break;

ERROR: trailing statements should be on next line
#1745: FILE: disas/riscv.c:1693:
+            case 13: op = rv_op_fdiv_d; break;

ERROR: trailing statements should be on next line
#1746: FILE: disas/riscv.c:1694:
+            case 15: op = rv_op_fdiv_q; break;

ERROR: trailing statements should be on next line
#1749: FILE: disas/riscv.c:1697:
+                case 0: op = rv_op_fsgnj_s; break;

ERROR: trailing statements should be on next line
#1750: FILE: disas/riscv.c:1698:
+                case 1: op = rv_op_fsgnjn_s; break;

ERROR: trailing statements should be on next line
#1751: FILE: disas/riscv.c:1699:
+                case 2: op = rv_op_fsgnjx_s; break;

ERROR: trailing statements should be on next line
#1756: FILE: disas/riscv.c:1704:
+                case 0: op = rv_op_fsgnj_d; break;

ERROR: trailing statements should be on next line
#1757: FILE: disas/riscv.c:1705:
+                case 1: op = rv_op_fsgnjn_d; break;

ERROR: trailing statements should be on next line
#1758: FILE: disas/riscv.c:1706:
+                case 2: op = rv_op_fsgnjx_d; break;

ERROR: trailing statements should be on next line
#1763: FILE: disas/riscv.c:1711:
+                case 0: op = rv_op_fsgnj_q; break;

ERROR: trailing statements should be on next line
#1764: FILE: disas/riscv.c:1712:
+                case 1: op = rv_op_fsgnjn_q; break;

ERROR: trailing statements should be on next line
#1765: FILE: disas/riscv.c:1713:
+                case 2: op = rv_op_fsgnjx_q; break;

ERROR: trailing statements should be on next line
#1770: FILE: disas/riscv.c:1718:
+                case 0: op = rv_op_fmin_s; break;

ERROR: trailing statements should be on next line
#1771: FILE: disas/riscv.c:1719:
+                case 1: op = rv_op_fmax_s; break;

ERROR: trailing statements should be on next line
#1776: FILE: disas/riscv.c:1724:
+                case 0: op = rv_op_fmin_d; break;

ERROR: trailing statements should be on next line
#1777: FILE: disas/riscv.c:1725:
+                case 1: op = rv_op_fmax_d; break;

ERROR: trailing statements should be on next line
#1782: FILE: disas/riscv.c:1730:
+                case 0: op = rv_op_fmin_q; break;

ERROR: trailing statements should be on next line
#1783: FILE: disas/riscv.c:1731:
+                case 1: op = rv_op_fmax_q; break;

ERROR: trailing statements should be on next line
#1788: FILE: disas/riscv.c:1736:
+                case 1: op = rv_op_fcvt_s_d; break;

ERROR: trailing statements should be on next line
#1789: FILE: disas/riscv.c:1737:
+                case 3: op = rv_op_fcvt_s_q; break;

ERROR: trailing statements should be on next line
#1794: FILE: disas/riscv.c:1742:
+                case 0: op = rv_op_fcvt_d_s; break;

ERROR: trailing statements should be on next line
#1795: FILE: disas/riscv.c:1743:
+                case 3: op = rv_op_fcvt_d_q; break;

ERROR: trailing statements should be on next line
#1800: FILE: disas/riscv.c:1748:
+                case 0: op = rv_op_fcvt_q_s; break;

ERROR: trailing statements should be on next line
#1801: FILE: disas/riscv.c:1749:
+                case 1: op = rv_op_fcvt_q_d; break;

ERROR: trailing statements should be on next line
#1806: FILE: disas/riscv.c:1754:
+                case 0: op = rv_op_fsqrt_s; break;

ERROR: trailing statements should be on next line
#1811: FILE: disas/riscv.c:1759:
+                case 0: op = rv_op_fsqrt_d; break;

ERROR: trailing statements should be on next line
#1816: FILE: disas/riscv.c:1764:
+                case 0: op = rv_op_fsqrt_q; break;

ERROR: trailing statements should be on next line
#1821: FILE: disas/riscv.c:1769:
+                case 0: op = rv_op_fle_s; break;

ERROR: trailing statements should be on next line
#1822: FILE: disas/riscv.c:1770:
+                case 1: op = rv_op_flt_s; break;

ERROR: trailing statements should be on next line
#1823: FILE: disas/riscv.c:1771:
+                case 2: op = rv_op_feq_s; break;

ERROR: trailing statements should be on next line
#1828: FILE: disas/riscv.c:1776:
+                case 0: op = rv_op_fle_d; break;

ERROR: trailing statements should be on next line
#1829: FILE: disas/riscv.c:1777:
+                case 1: op = rv_op_flt_d; break;

ERROR: trailing statements should be on next line
#1830: FILE: disas/riscv.c:1778:
+                case 2: op = rv_op_feq_d; break;

ERROR: trailing statements should be on next line
#1835: FILE: disas/riscv.c:1783:
+                case 0: op = rv_op_fle_q; break;

ERROR: trailing statements should be on next line
#1836: FILE: disas/riscv.c:1784:
+                case 1: op = rv_op_flt_q; break;

ERROR: trailing statements should be on next line
#1837: FILE: disas/riscv.c:1785:
+                case 2: op = rv_op_feq_q; break;

ERROR: trailing statements should be on next line
#1842: FILE: disas/riscv.c:1790:
+                case 0: op = rv_op_fcvt_w_s; break;

ERROR: trailing statements should be on next line
#1843: FILE: disas/riscv.c:1791:
+                case 1: op = rv_op_fcvt_wu_s; break;

ERROR: trailing statements should be on next line
#1844: FILE: disas/riscv.c:1792:
+                case 2: op = rv_op_fcvt_l_s; break;

ERROR: trailing statements should be on next line
#1845: FILE: disas/riscv.c:1793:
+                case 3: op = rv_op_fcvt_lu_s; break;

ERROR: trailing statements should be on next line
#1850: FILE: disas/riscv.c:1798:
+                case 0: op = rv_op_fcvt_w_d; break;

ERROR: trailing statements should be on next line
#1851: FILE: disas/riscv.c:1799:
+                case 1: op = rv_op_fcvt_wu_d; break;

ERROR: trailing statements should be on next line
#1852: FILE: disas/riscv.c:1800:
+                case 2: op = rv_op_fcvt_l_d; break;

ERROR: trailing statements should be on next line
#1853: FILE: disas/riscv.c:1801:
+                case 3: op = rv_op_fcvt_lu_d; break;

ERROR: trailing statements should be on next line
#1858: FILE: disas/riscv.c:1806:
+                case 0: op = rv_op_fcvt_w_q; break;

ERROR: trailing statements should be on next line
#1859: FILE: disas/riscv.c:1807:
+                case 1: op = rv_op_fcvt_wu_q; break;

ERROR: trailing statements should be on next line
#1860: FILE: disas/riscv.c:1808:
+                case 2: op = rv_op_fcvt_l_q; break;

ERROR: trailing statements should be on next line
#1861: FILE: disas/riscv.c:1809:
+                case 3: op = rv_op_fcvt_lu_q; break;

ERROR: trailing statements should be on next line
#1866: FILE: disas/riscv.c:1814:
+                case 0: op = rv_op_fcvt_s_w; break;

ERROR: trailing statements should be on next line
#1867: FILE: disas/riscv.c:1815:
+                case 1: op = rv_op_fcvt_s_wu; break;

ERROR: trailing statements should be on next line
#1868: FILE: disas/riscv.c:1816:
+                case 2: op = rv_op_fcvt_s_l; break;

ERROR: trailing statements should be on next line
#1869: FILE: disas/riscv.c:1817:
+                case 3: op = rv_op_fcvt_s_lu; break;

ERROR: trailing statements should be on next line
#1874: FILE: disas/riscv.c:1822:
+                case 0: op = rv_op_fcvt_d_w; break;

ERROR: trailing statements should be on next line
#1875: FILE: disas/riscv.c:1823:
+                case 1: op = rv_op_fcvt_d_wu; break;

ERROR: trailing statements should be on next line
#1876: FILE: disas/riscv.c:1824:
+                case 2: op = rv_op_fcvt_d_l; break;

ERROR: trailing statements should be on next line
#1877: FILE: disas/riscv.c:1825:
+                case 3: op = rv_op_fcvt_d_lu; break;

ERROR: trailing statements should be on next line
#1882: FILE: disas/riscv.c:1830:
+                case 0: op = rv_op_fcvt_q_w; break;

ERROR: trailing statements should be on next line
#1883: FILE: disas/riscv.c:1831:
+                case 1: op = rv_op_fcvt_q_wu; break;

ERROR: trailing statements should be on next line
#1884: FILE: disas/riscv.c:1832:
+                case 2: op = rv_op_fcvt_q_l; break;

ERROR: trailing statements should be on next line
#1885: FILE: disas/riscv.c:1833:
+                case 3: op = rv_op_fcvt_q_lu; break;

WARNING: line over 80 characters
#1889: FILE: disas/riscv.c:1837:
+                switch (((inst >> 17) & 0b11111000) | ((inst >> 12) & 
0b00000111)) {

ERROR: trailing statements should be on next line
#1890: FILE: disas/riscv.c:1838:
+                case 0: op = rv_op_fmv_x_s; break;

ERROR: trailing statements should be on next line
#1891: FILE: disas/riscv.c:1839:
+                case 1: op = rv_op_fclass_s; break;

WARNING: line over 80 characters
#1895: FILE: disas/riscv.c:1843:
+                switch (((inst >> 17) & 0b11111000) | ((inst >> 12) & 
0b00000111)) {

ERROR: trailing statements should be on next line
#1896: FILE: disas/riscv.c:1844:
+                case 0: op = rv_op_fmv_x_d; break;

ERROR: trailing statements should be on next line
#1897: FILE: disas/riscv.c:1845:
+                case 1: op = rv_op_fclass_d; break;

WARNING: line over 80 characters
#1901: FILE: disas/riscv.c:1849:
+                switch (((inst >> 17) & 0b11111000) | ((inst >> 12) & 
0b00000111)) {

ERROR: trailing statements should be on next line
#1902: FILE: disas/riscv.c:1850:
+                case 0: op = rv_op_fmv_x_q; break;

ERROR: trailing statements should be on next line
#1903: FILE: disas/riscv.c:1851:
+                case 1: op = rv_op_fclass_q; break;

WARNING: line over 80 characters
#1907: FILE: disas/riscv.c:1855:
+                switch (((inst >> 17) & 0b11111000) | ((inst >> 12) & 
0b00000111)) {

ERROR: trailing statements should be on next line
#1908: FILE: disas/riscv.c:1856:
+                case 0: op = rv_op_fmv_s_x; break;

WARNING: line over 80 characters
#1912: FILE: disas/riscv.c:1860:
+                switch (((inst >> 17) & 0b11111000) | ((inst >> 12) & 
0b00000111)) {

ERROR: trailing statements should be on next line
#1913: FILE: disas/riscv.c:1861:
+                case 0: op = rv_op_fmv_d_x; break;

WARNING: line over 80 characters
#1917: FILE: disas/riscv.c:1865:
+                switch (((inst >> 17) & 0b11111000) | ((inst >> 12) & 
0b00000111)) {

ERROR: trailing statements should be on next line
#1918: FILE: disas/riscv.c:1866:
+                case 0: op = rv_op_fmv_q_x; break;

ERROR: trailing statements should be on next line
#1925: FILE: disas/riscv.c:1873:
+            case 0: op = rv_op_addid; break;

ERROR: trailing statements should be on next line
#1928: FILE: disas/riscv.c:1876:
+                case 0: op = rv_op_sllid; break;

ERROR: trailing statements should be on next line
#1933: FILE: disas/riscv.c:1881:
+                case 0: op = rv_op_srlid; break;

ERROR: trailing statements should be on next line
#1934: FILE: disas/riscv.c:1882:
+                case 16: op = rv_op_sraid; break;

ERROR: trailing statements should be on next line
#1941: FILE: disas/riscv.c:1889:
+            case 0: op = rv_op_beq; break;

ERROR: trailing statements should be on next line
#1942: FILE: disas/riscv.c:1890:
+            case 1: op = rv_op_bne; break;

ERROR: trailing statements should be on next line
#1943: FILE: disas/riscv.c:1891:
+            case 4: op = rv_op_blt; break;

ERROR: trailing statements should be on next line
#1944: FILE: disas/riscv.c:1892:
+            case 5: op = rv_op_bge; break;

ERROR: trailing statements should be on next line
#1945: FILE: disas/riscv.c:1893:
+            case 6: op = rv_op_bltu; break;

ERROR: trailing statements should be on next line
#1946: FILE: disas/riscv.c:1894:
+            case 7: op = rv_op_bgeu; break;

ERROR: trailing statements should be on next line
#1951: FILE: disas/riscv.c:1899:
+            case 0: op = rv_op_jalr; break;

ERROR: trailing statements should be on next line
#1954: FILE: disas/riscv.c:1902:
+        case 27: op = rv_op_jal; break;

ERROR: line over 90 characters
#1958: FILE: disas/riscv.c:1906:
+                switch (((inst >> 20) & 0b111111100000) | ((inst >> 7) & 
0b000000011111)) {

ERROR: trailing statements should be on next line
#1961: FILE: disas/riscv.c:1909:
+                    case 0: op = rv_op_ecall; break;

ERROR: trailing statements should be on next line
#1962: FILE: disas/riscv.c:1910:
+                    case 32: op = rv_op_ebreak; break;

ERROR: trailing statements should be on next line
#1963: FILE: disas/riscv.c:1911:
+                    case 64: op = rv_op_uret; break;

ERROR: trailing statements should be on next line
#1970: FILE: disas/riscv.c:1918:
+                        case 0: op = rv_op_sret; break;

ERROR: trailing statements should be on next line
#1973: FILE: disas/riscv.c:1921:
+                    case 4: op = rv_op_sfence_vm; break;

ERROR: trailing statements should be on next line
#1976: FILE: disas/riscv.c:1924:
+                        case 0: op = rv_op_wfi; break;

ERROR: trailing statements should be on next line
#1981: FILE: disas/riscv.c:1929:
+                case 288: op = rv_op_sfence_vma; break;

ERROR: trailing statements should be on next line
#1984: FILE: disas/riscv.c:1932:
+                    case 64: op = rv_op_hret; break;

ERROR: trailing statements should be on next line
#1989: FILE: disas/riscv.c:1937:
+                    case 64: op = rv_op_mret; break;

ERROR: trailing statements should be on next line
#1994: FILE: disas/riscv.c:1942:
+                    case 576: op = rv_op_dret; break;

ERROR: trailing statements should be on next line
#1999: FILE: disas/riscv.c:1947:
+            case 1: op = rv_op_csrrw; break;

ERROR: trailing statements should be on next line
#2000: FILE: disas/riscv.c:1948:
+            case 2: op = rv_op_csrrs; break;

ERROR: trailing statements should be on next line
#2001: FILE: disas/riscv.c:1949:
+            case 3: op = rv_op_csrrc; break;

ERROR: trailing statements should be on next line
#2002: FILE: disas/riscv.c:1950:
+            case 5: op = rv_op_csrrwi; break;

ERROR: trailing statements should be on next line
#2003: FILE: disas/riscv.c:1951:
+            case 6: op = rv_op_csrrsi; break;

ERROR: trailing statements should be on next line
#2004: FILE: disas/riscv.c:1952:
+            case 7: op = rv_op_csrrci; break;

WARNING: line over 80 characters
#2008: FILE: disas/riscv.c:1956:
+            switch (((inst >> 22) & 0b1111111000) | ((inst >> 12) & 
0b0000000111)) {

ERROR: trailing statements should be on next line
#2009: FILE: disas/riscv.c:1957:
+            case 0: op = rv_op_addd; break;

ERROR: trailing statements should be on next line
#2010: FILE: disas/riscv.c:1958:
+            case 1: op = rv_op_slld; break;

ERROR: trailing statements should be on next line
#2011: FILE: disas/riscv.c:1959:
+            case 5: op = rv_op_srld; break;

ERROR: trailing statements should be on next line
#2012: FILE: disas/riscv.c:1960:
+            case 8: op = rv_op_muld; break;

ERROR: trailing statements should be on next line
#2013: FILE: disas/riscv.c:1961:
+            case 12: op = rv_op_divd; break;

ERROR: trailing statements should be on next line
#2014: FILE: disas/riscv.c:1962:
+            case 13: op = rv_op_divud; break;

ERROR: trailing statements should be on next line
#2015: FILE: disas/riscv.c:1963:
+            case 14: op = rv_op_remd; break;

ERROR: trailing statements should be on next line
#2016: FILE: disas/riscv.c:1964:
+            case 15: op = rv_op_remud; break;

ERROR: trailing statements should be on next line
#2017: FILE: disas/riscv.c:1965:
+            case 256: op = rv_op_subd; break;

ERROR: trailing statements should be on next line
#2018: FILE: disas/riscv.c:1966:
+            case 261: op = rv_op_srad; break;

ERROR: trailing statements should be on next line
#2781: FILE: disas/riscv.c:2729:
+        default: break;

ERROR: space prohibited between function name and open parenthesis '('
#3109: FILE: include/disas/bfd.h:432:
+int print_insn_riscv32          (bfd_vma, disassemble_info*);

ERROR: space prohibited between function name and open parenthesis '('
#3110: FILE: include/disas/bfd.h:433:
+int print_insn_riscv64          (bfd_vma, disassemble_info*);

total: 279 errors, 38 warnings, 3071 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/23: RISC-V CPU Helpers...
Checking PATCH 6/23: RISC-V FPU Support...
Checking PATCH 7/23: RISC-V GDB Stub...
Checking PATCH 8/23: RISC-V TCG Code Generation...
ERROR: spaces required around that ':' (ctx:VxE)
#631: FILE: target/riscv/translate.c:238:
+    CASE_OP_32_64(OPC_RISC_ADD):
                                ^

ERROR: spaces required around that ':' (ctx:VxE)
#634: FILE: target/riscv/translate.c:241:
+    CASE_OP_32_64(OPC_RISC_SUB):
                                ^

ERROR: spaces required around that ':' (ctx:VxE)
#688: FILE: target/riscv/translate.c:295:
+    CASE_OP_32_64(OPC_RISC_MUL):
                                ^

total: 3 errors, 0 warnings, 2338 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 9/23: RISC-V Physical Memory Protection...
Checking PATCH 10/23: RISC-V Linux User Emulation...
Checking PATCH 11/23: Add symbol table callback interface to load_elf...
Checking PATCH 12/23: RISC-V HTIF Console...
Checking PATCH 13/23: RISC-V HART Array...
Checking PATCH 14/23: SiFive RISC-V CLINT Block...
Checking PATCH 15/23: SiFive RISC-V PLIC Block...
Checking PATCH 16/23: RISC-V Spike Machines...
Checking PATCH 17/23: SiFive RISC-V Test Finisher...
Checking PATCH 18/23: RISC-V VirtIO Machine...
ERROR: suspect code indent for conditional statements (8, 10)
#123: FILE: hw/riscv/virt.c:103:
+        if (size == -1) {
+          error_report("qemu: could not load ramdisk '%s'", filename);

total: 1 errors, 0 warnings, 488 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 19/23: SiFive RISC-V UART Device...
Checking PATCH 20/23: SiFive RISC-V PRCI Block...
Checking PATCH 21/23: SiFive Freedom E300 RISC-V Machine...
Checking PATCH 22/23: SiFive Freedom U500 RISC-V Machine...
Checking PATCH 23/23: RISC-V Build Infrastructure...
WARNING: line over 80 characters
#219: FILE: scripts/qemu-binfmt-conf.sh:103:
+riscv32_magic='\x7fELF\x01\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\xf3\x00'

ERROR: line over 90 characters
#220: FILE: scripts/qemu-binfmt-conf.sh:104:
+riscv32_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'

WARNING: line over 80 characters
#223: FILE: scripts/qemu-binfmt-conf.sh:107:
+riscv64_magic='\x7fELF\x02\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\xf3\x00'

ERROR: line over 90 characters
#224: FILE: scripts/qemu-binfmt-conf.sh:108:
+riscv64_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'

total: 2 errors, 2 warnings, 149 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]