[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration |
Date: |
Mon, 26 Feb 2018 15:43:10 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 26/02/2018 13:55, Igor Mammedov wrote:
>>> So how about just adding a new option --mem-share to decide if that's a
>>> private memory or shared memory? That seems much straightforward way
> Above options are legacy (which we can't remove for compat reasons),
> their replacement is 'memory-backend-file' backend which has all of
> the above including 'share' property.
More precisely, we have added "-object memory-backend-file" to avoid
proliferation of options related to memory. Besides unifying the cases
of 1 and >1 NUMA node, using -object also has the advantage of
supporting memory hotplug.
You wrote "I find adding a backend for nonnuma pc RAM is roundabout way"
but basically the command line says "this VM has only one NUMA node,
backed by this memory object" which is a precise description of what the
VM memory looks like.
> So just add 'memdev' property to machine and reuse memory-backend-file
> with it instead of duplicating functionality in the legacy code.
That would however also have a different RAMBlock id, effectively
producing the same output as "-numa node,memdev=...".
I think this should be solved at the libvirt level. Libvirt should
write in the migration XML cookie whether the VM is using -object or
-mem-path to declare its memory, and newly-started VMs should always use
-object. This won't fix the problem for VMs that are already running,
but it will fix it the next time they are started.
Paolo
- Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration, (continued)
- Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration, Paolo Bonzini, 2018/02/05
- Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration, Tan, Jianfeng, 2018/02/07
- Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration, Igor Mammedov, 2018/02/07
- Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration, Tan, Jianfeng, 2018/02/07
- Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration, Igor Mammedov, 2018/02/08
- Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration, Tan, Jianfeng, 2018/02/08
- Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration, Igor Mammedov, 2018/02/08
- Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration, Tan, Jianfeng, 2018/02/23
- Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration, Tan, Jianfeng, 2018/02/23
- Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration, Igor Mammedov, 2018/02/26
- Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration,
Paolo Bonzini <=
- Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration, Tan, Jianfeng, 2018/02/26
- Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration, Tan, Jianfeng, 2018/02/26
- Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration, Igor Mammedov, 2018/02/28
- Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration, Dr. David Alan Gilbert, 2018/02/05
Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration, no-reply, 2018/02/05
Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration, Igor Mammedov, 2018/02/05