[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 23/36] rbd: Assign s->snap/image_name in qemu
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v3 23/36] rbd: Assign s->snap/image_name in qemu_rbd_open() |
Date: |
Mon, 26 Feb 2018 13:24:53 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 2018-02-23 20:25, Kevin Wolf wrote:
> Now that the options are already available in qemu_rbd_open() and not
> only parsed in qemu_rbd_connect(), we can assign s->snap and
> s->image_name there instead of passing the fields by reference to
> qemu_rbd_connect().
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/rbd.c | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 16/36] file-win32: Support .bdrv_co_create, (continued)
- [Qemu-devel] [PATCH v3 16/36] file-win32: Support .bdrv_co_create, Kevin Wolf, 2018/02/23
- [Qemu-devel] [PATCH v3 14/36] block: x-blockdev-create QMP command, Kevin Wolf, 2018/02/23
- [Qemu-devel] [PATCH v3 15/36] file-posix: Support .bdrv_co_create, Kevin Wolf, 2018/02/23
- [Qemu-devel] [PATCH v3 12/36] qcow2: Use visitor for options in qcow2_create(), Kevin Wolf, 2018/02/23
- [Qemu-devel] [PATCH v3 17/36] gluster: Support .bdrv_co_create, Kevin Wolf, 2018/02/23
- [Qemu-devel] [PATCH v3 18/36] rbd: Fix use after free in qemu_rbd_set_keypairs() error path, Kevin Wolf, 2018/02/23
- [Qemu-devel] [PATCH v3 19/36] rbd: Factor out qemu_rbd_connect(), Kevin Wolf, 2018/02/23
- [Qemu-devel] [PATCH v3 21/36] rbd: Pass BlockdevOptionsRbd to qemu_rbd_connect(), Kevin Wolf, 2018/02/23
- [Qemu-devel] [PATCH v3 23/36] rbd: Assign s->snap/image_name in qemu_rbd_open(), Kevin Wolf, 2018/02/23
- Re: [Qemu-devel] [PATCH v3 23/36] rbd: Assign s->snap/image_name in qemu_rbd_open(),
Max Reitz <=
- [Qemu-devel] [PATCH v3 22/36] rbd: Support .bdrv_co_create, Kevin Wolf, 2018/02/23
- [Qemu-devel] [PATCH v3 20/36] rbd: Remove non-schema options from runtime_opts, Kevin Wolf, 2018/02/23
- [Qemu-devel] [PATCH v3 24/36] rbd: Use qemu_rbd_connect() in qemu_rbd_do_create(), Kevin Wolf, 2018/02/23
- [Qemu-devel] [PATCH v3 25/36] nfs: Use QAPI options in nfs_client_open(), Kevin Wolf, 2018/02/23
- [Qemu-devel] [PATCH v3 26/36] nfs: Support .bdrv_co_create, Kevin Wolf, 2018/02/23
- [Qemu-devel] [PATCH v3 27/36] sheepdog: QAPIfy "redundancy" create option, Kevin Wolf, 2018/02/23
- [Qemu-devel] [PATCH v3 29/36] ssh: Use QAPI BlockdevOptionsSsh object, Kevin Wolf, 2018/02/23
- [Qemu-devel] [PATCH v3 28/36] sheepdog: Support .bdrv_co_create, Kevin Wolf, 2018/02/23