Re: [Qemu-devel] [PATCH 5/6] ahci-test: fix opts leak of skip tests

[John Snow]

On 02/15/2018 04:25 PM, Marc-André Lureau wrote:
> Fixes the following ASAN report:
> 
> Direct leak of 128 byte(s) in 8 object(s) allocated from:
>     #0 0x7fefce311850 in malloc (/lib64/libasan.so.4+0xde850)
>     #1 0x7fefcdd5ef0c in g_malloc ../glib/gmem.c:94
>     #2 0x559b976faff0 in create_ahci_io_test 
> /home/elmarco/src/qemu/tests/ahci-test.c:1810
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  tests/ahci-test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/ahci-test.c b/tests/ahci-test.c
> index 7aa5af428c..1bd3cc7ca8 100644
> --- a/tests/ahci-test.c
> +++ b/tests/ahci-test.c
> @@ -1822,6 +1822,7 @@ static void create_ahci_io_test(enum IOMode type, enum 
> AddrMode addr,
>      if ((addr == ADDR_MODE_LBA48) && (offset == OFFSET_HIGH) &&
>          (mb_to_sectors(test_image_size_mb) <= 0xFFFFFFF)) {
>          g_test_message("%s: skipped; test image too small", name);
> +        g_free(opts);
>          g_free(name);
>          return;
>      }
> 

Whupps.

Thanks.

Reviewed-by: John Snow <address@hidden>

And, feel free to stage this in whomever's branch, it won't conflict
with anything:

Acked-by: John Snow <address@hidden>