qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 10/12] s390-ccw: read user input for boot ind


From: Collin L. Walling
Subject: Re: [Qemu-devel] [PATCH v6 10/12] s390-ccw: read user input for boot index via the SCLP console
Date: Fri, 16 Feb 2018 10:13:36 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 02/16/2018 10:03 AM, David Hildenbrand wrote:
On 15.02.2018 23:54, Collin L. Walling wrote:
[...]
+
  static int get_boot_index(int entries)
  {
-    return 0; /* Implemented next patch */
+    int boot_index;
+    bool retry = false;
+    char tmp[5];
+
+    do {
+        boot_menu_prompt(retry);
+        boot_index = get_index();
+        retry = true;
+    } while (boot_index < 0 || boot_index >= entries);
+
Can you add a comment like

/*
  * We might still have pending SERVICE interrupts. Print something to
  * definitely clear it.
  */

I handle clearing the pending int in the next patch.

[...]

--
- Collin L Walling




reply via email to

[Prev in Thread] Current Thread [Next in Thread]