[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RfC PATCH v3 5/5] vfio/display: adding region support
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [RfC PATCH v3 5/5] vfio/display: adding region support |
Date: |
Fri, 16 Feb 2018 15:01:18 +0100 |
User-agent: |
NeoMutt/20171215 |
> > +static int vfio_display_region_init(VFIOPCIDevice *vdev, Error **errp)
> > +{
> > + vdev->dpy = g_new0(VFIODisplay, 1);
> > + vdev->dpy->con = graphic_console_init(DEVICE(vdev), 0,
> > + &vfio_display_region_ops,
> > + vdev);
> > + /* TODO: disable hotplug (there is no graphic_console_close) */
>
> via DeviceClass.hotpluggable? I know that QE will immediately test
> this, so it needs to be sorted out sooner than later.
Hmm, I think setting DeviceClass.hotpluggable would tag all vfio devices
as not hotpluggable, not only the one we just created a display for.
cheers,
Gerd
- [Qemu-devel] [RfC PATCH v3 0/5] vfio: add display support, Gerd Hoffmann, 2018/02/13
- [Qemu-devel] [RfC PATCH v3 5/5] vfio/display: adding region support, Gerd Hoffmann, 2018/02/13
- [Qemu-devel] [RfC PATCH v3 3/5] ui/pixman: add qemu_drm_format_to_pixman(), Gerd Hoffmann, 2018/02/13
- [Qemu-devel] [RfC PATCH v3 4/5] vfio/display: core & wireup, Gerd Hoffmann, 2018/02/13
- [Qemu-devel] [RfC PATCH v3 2/5] standard-headers: add drm/drm_fourcc.h, Gerd Hoffmann, 2018/02/13
- [Qemu-devel] [RfC PATCH v3 1/5] linux-headers: update to 4.16-rc1, Gerd Hoffmann, 2018/02/13