[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 01/10] migration/xen: Check return value of qemu_fclo
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[Qemu-devel] [PULL 01/10] migration/xen: Check return value of qemu_fclose |
Date: |
Wed, 14 Feb 2018 15:39:29 +0000 |
From: Ross Lagerwall <address@hidden>
QEMUFile uses buffered IO so when writing small amounts (such as the Xen
device state file), the actual write call and any errors that may occur
only happen as part of qemu_fclose(). Therefore, report IO errors when
saving the device state under Xen by checking the return value of
qemu_fclose().
Signed-off-by: Ross Lagerwall <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
---
migration/savevm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/migration/savevm.c b/migration/savevm.c
index 3f611c02e8..68b652ff76 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -2284,8 +2284,7 @@ void qmp_xen_save_devices_state(const char *filename,
bool has_live, bool live,
f = qemu_fopen_channel_output(QIO_CHANNEL(ioc));
object_unref(OBJECT(ioc));
ret = qemu_save_device_state(f);
- qemu_fclose(f);
- if (ret < 0) {
+ if (ret < 0 || qemu_fclose(f) < 0) {
error_setg(errp, QERR_IO_ERROR);
} else {
/* libxl calls the QMP command "stop" before calling
--
2.14.3
- [Qemu-devel] [PULL 00/10] migration queue, Dr. David Alan Gilbert (git), 2018/02/14
- [Qemu-devel] [PULL 01/10] migration/xen: Check return value of qemu_fclose,
Dr. David Alan Gilbert (git) <=
- [Qemu-devel] [PULL 04/10] migration: Fix early failure cleanup, Dr. David Alan Gilbert (git), 2018/02/14
- [Qemu-devel] [PULL 07/10] migration: reuse mis->userfault_quit_fd, Dr. David Alan Gilbert (git), 2018/02/14
- [Qemu-devel] [PULL 09/10] migration: allow send_rq to fail, Dr. David Alan Gilbert (git), 2018/02/14
- [Qemu-devel] [PULL 05/10] tests/migration: Add test for migration to bad destination, Dr. David Alan Gilbert (git), 2018/02/14
- [Qemu-devel] [PULL 02/10] migration: improve documentation of postcopy-ram, Dr. David Alan Gilbert (git), 2018/02/14
- [Qemu-devel] [PULL 06/10] migration: better error handling with QEMUFile, Dr. David Alan Gilbert (git), 2018/02/14
- [Qemu-devel] [PULL 03/10] tests/migration: Add source to PC boot block, Dr. David Alan Gilbert (git), 2018/02/14
- [Qemu-devel] [PULL 10/10] migration: pass MigrationState to migrate_init(), Dr. David Alan Gilbert (git), 2018/02/14
- [Qemu-devel] [PULL 08/10] migration: provide postcopy_fault_thread_notify(), Dr. David Alan Gilbert (git), 2018/02/14
- Re: [Qemu-devel] [PULL 00/10] migration queue, Peter Maydell, 2018/02/15