[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user: Use *at functions to implement inte
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] linux-user: Use *at functions to implement interp_prefix |
|
Date: |
Tue, 13 Feb 2018 16:50:11 +0000 |
On 13 February 2018 at 16:43, Peter Maydell <address@hidden> wrote:
> OTOH, maybe we should just go ahead without weird games with dup2 and
> see whether any real code gets confused...
Here's some real-world code that would break with this patch
as it stands, though dup2 games wouldn't be the fix in this case:
https://github.com/xinetd-org/xinetd/blob/master/xinetd/init.c#L79
(it iterates through all fds above 2 closing them, and we don't
protect against the guest being able to perform syscalls on
interp_dirfd)
thanks
-- PMM