Re: [Qemu-devel] [PATCH] s390/stattrib: Make SaveVMHandlers data static

[Richard Henderson]

On 02/12/2018 07:49 AM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
> 
> There's no need for this to be dynamic, make it static.
> 
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> ---
>  hw/s390x/s390-stattrib.c | 26 +++++++++++++-------------
>  1 file changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/hw/s390x/s390-stattrib.c b/hw/s390x/s390-stattrib.c
> index a1d2135a60..adf07ef312 100644
> --- a/hw/s390x/s390-stattrib.c
> +++ b/hw/s390x/s390-stattrib.c
> @@ -365,22 +365,22 @@ static inline void 
> s390_stattrib_set_migration_enabled(Object *obj, bool value,
>      s->migration_enabled = value;
>  }
>  
> +static SaveVMHandlers savevm_s390_stattrib_handlers = {
> +    .save_setup = cmma_save_setup,
> +    .save_live_iterate = cmma_save_iterate,
> +    .save_live_complete_precopy = cmma_save_complete,
> +    .save_live_pending = cmma_save_pending,
> +    .save_cleanup = cmma_save_cleanup,
> +    .load_state = cmma_load,
> +    .is_active = cmma_active,
> +};

Reviewed-by: Richard Henderson <address@hidden>

Bonus points for the follow-on to make this const.  I realize that
register_savevm_live is not currently prepared for this, so pushing the
qualifier down will take some doing.


r~