[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] hw/arm/aspeed: directly map the serial d
From: |
Andrew Jeffery |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] hw/arm/aspeed: directly map the serial device to the system address space |
Date: |
Mon, 12 Feb 2018 10:01:30 +1030 |
On Fri, 2018-02-09 at 05:57 -0300, Philippe Mathieu-Daudé wrote:
> (qemu) info mtree
> address-space: cpu-memory-0
> 0000000000000000-ffffffffffffffff (prio 0, i/o): system
> 0000000000000000-0000000007ffffff (prio 0, rom): aspeed.boot_rom
> 000000001e600000-000000001e7fffff (prio -1, i/o): aspeed_soc.io
> - 000000001e784000-000000001e78401f (prio 0, i/o): serial
> 000000001e620000-000000001e6200ff (prio 0, i/o):
> aspeed.smc.ast2500-fmc
> 000000001e630000-000000001e6300ff (prio 0, i/o):
> aspeed.smc.ast2500-spi1
> [...]
> 000000001e720000-000000001e728fff (prio 0, ram): aspeed.sram
> 000000001e782000-000000001e782fff (prio 0, i/o): aspeed.timer
> + 000000001e784000-000000001e78401f (prio 0, i/o): serial
> 000000001e785000-000000001e78501f (prio 0, i/o): aspeed.wdt
> 000000001e785020-000000001e78503f (prio 0, i/o): aspeed.wdt
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Andrew Jeffery <address@hidden>
> ---
> hw/arm/aspeed_soc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c
> index c83b7e207b..2a5d041b3b 100644
> --- a/hw/arm/aspeed_soc.c
> +++ b/hw/arm/aspeed_soc.c
> @@ -257,7 +257,8 @@ static void aspeed_soc_realize(DeviceState *dev,
> Error **errp)
> /* UART - attach an 8250 to the IO space as our UART5 */
> if (serial_hds[0]) {
> qemu_irq uart5 = qdev_get_gpio_in(DEVICE(&s->vic),
> uart_irqs[4]);
> - serial_mm_init(&s->iomem, ASPEED_SOC_UART_5_BASE, 2,
> + serial_mm_init(get_system_memory(),
> + ASPEED_SOC_IOMEM_BASE +
> ASPEED_SOC_UART_5_BASE, 2,
> uart5, 38400, serial_hds[0],
> DEVICE_LITTLE_ENDIAN);
> }
>
signature.asc
Description: This is a digitally signed message part