[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 09/14] pci: Use pci_config_size in pci_data_*
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v5 09/14] pci: Use pci_config_size in pci_data_* accessors |
Date: |
Thu, 8 Feb 2018 18:08:06 +0000 |
On 8 February 2018 at 17:43, Andrey Smirnov <address@hidden> wrote:
> My only justification for this change was suggestion from Marcel to
> use pci_data_* functions, instead of calling pci_host_config_*_common
> explicitly in designware.c introduced in next patch in the series. My
> v4 patches incorrectly limited config space size to 256, so such
> replacement didn't require this patch, but switching pci_data_* to use
> pci_config_size() seemed harmless enough. I am more than happy to got
> back to using pci_host_config_*_common in designware.c and dropping
> this patch.
OK. I'll keep patches 1-8, 11 and 13 in target-arm, and drop 9, 10,
12 and 14 for the moment.
thanks
-- PMM
- [Qemu-devel] [PATCH v5 05/14] i.MX: Add code to emulate i.MX7 SNVS IP-block, (continued)
- [Qemu-devel] [PATCH v5 05/14] i.MX: Add code to emulate i.MX7 SNVS IP-block, Andrey Smirnov, 2018/02/06
- [Qemu-devel] [PATCH v5 07/14] i.MX: Add i.MX7 GPT variant, Andrey Smirnov, 2018/02/06
- [Qemu-devel] [PATCH v5 08/14] i.MX: Add implementation of i.MX7 GPR IP block, Andrey Smirnov, 2018/02/06
- [Qemu-devel] [PATCH v5 06/14] i.MX: Add code to emulate GPCv2 IP block, Andrey Smirnov, 2018/02/06
- [Qemu-devel] [PATCH v5 09/14] pci: Use pci_config_size in pci_data_* accessors, Andrey Smirnov, 2018/02/06
[Qemu-devel] [PATCH v5 11/14] usb: Add basic code to emulate Chipidea USB IP, Andrey Smirnov, 2018/02/06
[Qemu-devel] [PATCH v5 13/14] hw/arm: Move virt's PSCI DT fixup code to arm/boot.c, Andrey Smirnov, 2018/02/06
[Qemu-devel] [PATCH v5 10/14] pci: Add support for Designware IP block, Andrey Smirnov, 2018/02/06
- Re: [Qemu-devel] [PATCH v5 10/14] pci: Add support for Designware IP block, Michael S. Tsirkin, 2018/02/08
- Re: [Qemu-devel] [PATCH v5 10/14] pci: Add support for Designware IP block, Andrey Smirnov, 2018/02/08
- Re: [Qemu-devel] [PATCH v5 10/14] pci: Add support for Designware IP block, Michael S. Tsirkin, 2018/02/08
- Re: [Qemu-devel] [PATCH v5 10/14] pci: Add support for Designware IP block, Andrey Smirnov, 2018/02/08
- Re: [Qemu-devel] [PATCH v5 10/14] pci: Add support for Designware IP block, Michael S. Tsirkin, 2018/02/08
- Re: [Qemu-devel] [PATCH v5 10/14] pci: Add support for Designware IP block, Andrey Smirnov, 2018/02/08