Re: [Qemu-devel] [PATCH v6 18/23] sev: emit the SEV_MEASUREMENT event

[Brijesh Singh]

On Fri, Feb 2, 2018 at 9:16 AM, Daniel P. Berrangé <address@hidden>
wrote:

> On Fri, Feb 02, 2018 at 09:11:41AM -0600, Brijesh Singh wrote:
> >
> >
> > On 02/01/2018 11:27 AM, Dr. David Alan Gilbert wrote:
> > > * Brijesh Singh (address@hidden) wrote:
> > > >
> > > >
> > > > On 1/30/18 2:08 PM, Dr. David Alan Gilbert wrote:
> > > > > * Brijesh Singh (address@hidden) wrote:
> > > > > > During machine creation we encrypted the guest bios image, the
> > > > > > LAUNCH_MEASURE command can be used to retrieve the measurement of
> > > > > > the encrypted memory region. Emit the SEV_MEASUREMENT event so
> that
> > > > > > libvirt can grab the measurement value as soon as we are done
> with
> > > > > > creating the encrypted machine.
> > > > > Can you ust clarify what happens if the libvirt has disconnected
> and
> > > > > reconnected to qemu and so didn't see the event?  Can the
> reconnecting
> > > > > libvirt query it and find out it's ready/not ready yet?
> > > >
> > > > Dave,
> > > >
> > > > I have not looked into details between libvirt and qemu interaction
> to
> > > > comment how and when the events will be delivered. Recently, one of
> my
> > > > colleague was implementing libvirt interface for the SEV guest and
> ran
> > > > into somewhat a similar challenge and posted question on libvirt
> mailing
> > > > list [1].
> > > >
> > > > In previous discussion on qemu mailing list, we agreed to implement
> SEV
> > > > MEASUREMENT event which can be seen by libvirt. That's what this
> patch
> > > > is doing.
> > > >
> > > > But during the libvirt implementation it seems that qemu monitor
> > > > silently drops all the events before it get the first
> qmp_capabilities
> > > > command. At a quick glance it seems on reconnect, libvirt issues
> > > > qmp_capabilities command and any event issued before the
> > > > qmp_capabilities command will never to delivered to libvirt. we are
> > > > looking for  help from libvirt/qemu monitor experts on how we solve
> this
> > > > problem. Our goal is to provide the measurement to libvirt before
> > > > libvirt issues "continue" command. Since event can't be seen by
> libvirt
> > > > before it resumes the guest hence I was wondering if we should we
> should
> > > > drop the SEV measurement event and consider adding a new QMP command
> to
> > > > query the SEV measurement.
> > >
> > > Yep, I'll leave it to the libvirt contacts for the best way they'd like
> > > to see that, as Eric says there's nothing wrong with having both the
> > > command and event if useful.  Also keep in mind coping with a guest
> that
> > > crashes early or that measurement never arrives.
> > >
> >
> > Yep, lets see what libvirt experts say about it.
> >
> > Hi Daniel,
> >
> > Do you have any recommendation on whether we should consider adding a new
> > QMP to retrieve the measurement or we do event or both? Please note that
> the
> > launch measurement is generate only once for the lifetime of the guest.
> The
> > measurement will be available after qmeu encrypts the guest bios during
> the
> > machine initialization time.
>
> IIUC, the measurement event is only required during the initial QEMU
> startup sequence. Once the guest CPUs are running this info is not needed
> any more.
>

That is correct.



>
> If libvirtd crashes/restarts in the middle of QEMU startup sequence it is
> game over from libvirt's POV. Libvirtd won't try to carry on starting that
> guest when it restarts. So I don't think there's a compelling need for a
> command to query the measurement from libvirt's POV, the event is fine.
>
>

Sorry for the late response, somehow this email was never delievered to my
AMD account hence I was not able to see the response on-time.

Anyway, the main issue is event emitted before "qmp_capabilities" are
dropped silently , see [1] . In our case, the measurement event is emitted
during the machine creation time, libvirt was still waiting to reconnect
the monitor when event was emitted hence libvirt never gets the event.
Because of this, I am not able to see any strong reason to emit the event.
Do you see any issue with libvirt issuing a  'query-sev-launch-measure' to
get the measurement on reconnect ?

[1] https://github.com/qemu/qemu/blob/master/monitor.c#L418



That all said, I think it might be useful to have a command to query the
> SEV measurement purely as a debugging aid, if some admin / support person
> wants to get hold of this info for some reason...
>
> Regards,
> Daniel
> --
> |: https://berrange.com      -o-    https://www.flickr.com/photos/
> dberrange :|
> |: https://libvirt.org         -o-
> https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-    https://www.instagram.com/
> dberrange :|
>
>