Re: [Qemu-devel] [PATCH 2/2] qmp: document query-cpus performance issue

[Daniel P . Berrangé]

On Wed, Feb 07, 2018 at 12:50:14PM -0500, Luiz Capitulino wrote:
> Signed-off-by: Luiz Capitulino <address@hidden>
> ---
>  qapi-schema.json | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 82d6f12b53..0665a14dba 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -526,6 +526,10 @@
>  #
>  # Returns a list of information about each virtual CPU.
>  #
> +# WARNING: This command incurs a performance penalty for latency
> +#          sensitive workloads and hence it's not recommended to
> +#          to be used in production. Use query-cpus-fast instead

I suggest being more explicit about exactly what the problem is, so people
understand implications if they choose to still use it. ie

  This command causes vCPU threads to exit to userspace, which causes
  an small interruption guest CPU execution. This will have a negative
  impact on realtime guests and other latency sensitive guest workloads.
  It is recommended to use query-cpus-fast instead of this command to
  avoid the vCPU interruption.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|