Re: [Qemu-devel] [PATCH v7 26/26] qmp: add query-sev-launch-measure command

[Eric Blake]

On 02/07/2018 10:06 AM, Brijesh Singh wrote:
> The command can be used by libvirt to retrieve the measurement of SEV guest.
> This measurement is a signature of the memory contents that was encrypted
> through the LAUNCH_UPDATE_DATA.
>
> Cc: "Daniel P. Berrangé" <address@hidden>
> Cc: "Dr. David Alan Gilbert" <address@hidden>
> Cc: Markus Armbruster <address@hidden>
> Signed-off-by: Brijesh Singh <address@hidden>
> ---
>   qapi-schema.json | 30 ++++++++++++++++++++++++++++++
>   qmp.c            | 14 ++++++++++++++
>   2 files changed, 44 insertions(+)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 447ebb15266e..19331bff8883 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3236,3 +3236,33 @@
>   #
>   ##
>   { 'command': 'query-sev', 'returns': 'SevInfo' }
> +
> +##
> +# @SevLaunchMeasureInfo:
> +#
> +# SEV Guest Launch measurement information
> +#
> +# @data: the measurement value encoded in base64
> +#
> +# Since: 2.12
> +#
> +# Notes: If measurement is not available then a null measurement is returned.

Null measurement, as in empty string?  Would it be better to have 
query-sev-launch-measure return an error instead of an 
SevLaunchMeasureInfo with a null measurement in that case?

> +##
> +{ 'struct': 'SevLaunchMeasureInfo', 'data': {'data': 'str'} }
> +
> +##
> +# @query-sev-launch-measure:
> +#
> +# Query the SEV guest launch information.
> +#
> +# Returns: The @SevLaunchMeasureInfo for the guest
> +#
> +# Since: 2.12
> +#
> +# Example:
> +#
> +# -> { "execute": "query-sev-launch-measure" }
> +# <- { "return": { "data": "4l8LXeNlSPUDlXPJG5966/8%YZ" } }
> +#


--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org