Re: [Qemu-devel] [RFC PATCH 00/34] Hyper-V / VMBus

qemu-devel
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 00/34] Hyper-V / VMBus

From:	no-reply
Subject:	Re: [Qemu-devel] [RFC PATCH 00/34] Hyper-V / VMBus
Date:	Tue, 6 Feb 2018 13:56:39 -0800 (PST)
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [RFC PATCH 00/34] Hyper-V / VMBus

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
98adc64f2b hv-net: define default rom file name
32dd25dfe6 vmbus: add support for rom files
983ba13ed2 loader: allow arbitrary basename for fw_cfg file roms
3e4e616672 hv-net: add .bootindex support
9b49f45b61 net: add Hyper-V/VMBus net adapter
8b3b6a7831 net: add Hyper-V/VMBus network protocol definitions
932a14d315 net: add RNDIS definitions
58ff5f3675 tests: hv-scsi: add start-stop test
f81c7ad4b7 hv-scsi: limit the number of requests per notification
62d0ac72b5 scsi: add Hyper-V/VMBus SCSI controller
438b47b468 scsi: add Hyper-V/VMBus SCSI protocol definitions
4baa88ac14 i386: en/disable vmbus by a machine property
7e9adc9af7 i386: Hyper-V VMBus ACPI DSDT entry
1c19b65fab vmbus: build configuration
4471f1afca vmbus: vmbus implementation
6aff6ba275 vmbus: add vmbus protocol definitions
601a95fc0a hyperv: add support for KVM_HYPERV_EVENTFD
9ec270a97e import HYPERV_EVENTFD stuff from kernel
cbfeb5e77c hyperv: update copyright notices
77d9e62db5 hyperv_testdev: add SynIC message and event testmodes
6bf86c8237 hyperv: process POST_MESSAGE hypercall
52d482a30c hyperv: process SIGNAL_EVENT hypercall
be4ed13446 hyperv: add synic event flag signaling
58a94ec55e hyperv: add synic message delivery
921fcaab97 hyperv: make overlay pages for SynIC
8540e6cff0 hyperv: block SynIC use in QEMU in incompatible configurations
0a8a729b0b hyperv: qom-ify SynIC
1f9fba8cb0 hyperv: make HvSintRoute reference-counted
4d649ce401 hyperv: address HvSintRoute by X86CPU pointer
96cc3d2e21 hyperv: allow passing arbitrary data to sint ack callback
93ceab6b34 hyperv: synic: only setup ack notifier if there's a callback
fa7482c5ff hyperv: cosmetic: g_malloc -> g_new
63d46e7b96 hyperv_testdev: refactor for readability
ff514f8890 hyperv: ensure VP index equal to QEMU cpu_index

=== OUTPUT BEGIN ===
Checking PATCH 1/34: hyperv: ensure VP index equal to QEMU cpu_index...
Checking PATCH 2/34: hyperv_testdev: refactor for readability...
Checking PATCH 3/34: hyperv: cosmetic: g_malloc -> g_new...
Checking PATCH 4/34: hyperv: synic: only setup ack notifier if there's a 
callback...
Checking PATCH 5/34: hyperv: allow passing arbitrary data to sint ack 
callback...
Checking PATCH 6/34: hyperv: address HvSintRoute by X86CPU pointer...
Checking PATCH 7/34: hyperv: make HvSintRoute reference-counted...
Checking PATCH 8/34: hyperv: qom-ify SynIC...
Checking PATCH 9/34: hyperv: block SynIC use in QEMU in incompatible 
configurations...
Checking PATCH 10/34: hyperv: make overlay pages for SynIC...
Checking PATCH 11/34: hyperv: add synic message delivery...
Checking PATCH 12/34: hyperv: add synic event flag signaling...
Checking PATCH 13/34: hyperv: process SIGNAL_EVENT hypercall...
Checking PATCH 14/34: hyperv: process POST_MESSAGE hypercall...
Checking PATCH 15/34: hyperv_testdev: add SynIC message and event testmodes...
Checking PATCH 16/34: hyperv: update copyright notices...
Checking PATCH 17/34: import HYPERV_EVENTFD stuff from kernel...
Checking PATCH 18/34: hyperv: add support for KVM_HYPERV_EVENTFD...
Checking PATCH 19/34: vmbus: add vmbus protocol definitions...
ERROR: do not use C99 // comments
#133: FILE: include/hw/vmbus/vmbus-proto.h:114:
+    uint8_t  monitor_flags;      // VMBUS_OFFER_MONITOR_*

ERROR: do not use C99 // comments
#134: FILE: include/hw/vmbus/vmbus-proto.h:115:
+    uint16_t interrupt_flags;    // VMBUS_OFFER_INTERRUPT_*

ERROR: do not use C99 // comments
#211: FILE: include/hw/vmbus/vmbus-proto.h:192:
+    uint32_t feature_bits;     // VMBUS_RING_BUFFER_FEAT_*

total: 3 errors, 0 warnings, 222 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 20/34: vmbus: vmbus implementation...
ERROR: open brace '{' following struct go on the same line
#91: FILE: hw/vmbus/vmbus.c:32:
+typedef struct VMBusGpadl
+{

ERROR: open brace '{' following struct go on the same line
#130: FILE: hw/vmbus/vmbus.c:71:
+typedef struct VMBusChannel
+{

ERROR: open brace '{' following struct go on the same line
#171: FILE: hw/vmbus/vmbus.c:112:
+typedef struct VMBus
+{

ERROR: memory barrier without comment
#566: FILE: hw/vmbus/vmbus.c:507:
+    smp_mb();

ERROR: memory barrier without comment
#627: FILE: hw/vmbus/vmbus.c:568:
+    smp_mb();

ERROR: "(foo*)" should be "(foo *)"
#1468: FILE: hw/vmbus/vmbus.c:1409:
+    vmbus_msg = (struct vmbus_message_header*)msg->payload;

ERROR: "(foo*)" should be "(foo *)"
#1957: FILE: hw/vmbus/vmbus.c:1898:
+    msg = (struct vmbus_message_header*)msgdata;

ERROR: space required before the open parenthesis '('
#2009: FILE: hw/vmbus/vmbus.c:1950:
+    switch(vmbus->state) {

WARNING: line over 80 characters
#2246: FILE: hw/vmbus/vmbus.c:2187:
+        VMSTATE_STRUCT_VARRAY_POINTER_UINT16(channels, VMBusDevice, 
num_channels,

ERROR: spaces required around that '*' (ctx:VxV)
#2441: FILE: hw/vmbus/vmbus.c:2382:
+    .subsections = (const VMStateDescription*[]) {
                                             ^

ERROR: do not use C99 // comments
#2485: FILE: hw/vmbus/vmbus.c:2426:
+    // return qdev_find_recursive(sysbus_get_default(), TYPE_VMBUS_BRIDGE);

total: 10 errors, 1 warnings, 2558 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 21/34: vmbus: build configuration...
Checking PATCH 22/34: i386: Hyper-V VMBus ACPI DSDT entry...
Checking PATCH 23/34: i386: en/disable vmbus by a machine property...
Checking PATCH 24/34: scsi: add Hyper-V/VMBus SCSI protocol definitions...
WARNING: line over 80 characters
#81: FILE: hw/scsi/hvscsi-proto.h:61:
+#define HV_SRB_FLAGS_UNSPECIFIED_DIRECTION      (SRB_FLAGS_DATA_IN | 
SRB_FLAGS_DATA_OUT)

ERROR: do not use C99 // comments
#157: FILE: hw/scsi/hvscsi-proto.h:137:
+    uint32_t flags;             // HV_STOR_FLAG_* */

total: 1 errors, 1 warnings, 150 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 25/34: scsi: add Hyper-V/VMBus SCSI controller...
ERROR: open brace '{' following struct go on the same line
#71: FILE: hw/scsi/hv-scsi.c:42:
+typedef struct HvScsiReq
+{

ERROR: initializer for struct SCSIBusInfo should normally be const
#175: FILE: hw/scsi/hv-scsi.c:146:
+static struct SCSIBusInfo hv_scsi_info = {

total: 2 errors, 0 warnings, 412 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 26/34: hv-scsi: limit the number of requests per notification...
Checking PATCH 27/34: tests: hv-scsi: add start-stop test...
Checking PATCH 28/34: net: add RNDIS definitions...
ERROR: code indent should never use tabs
#26: FILE: hw/net/rndis.h:7:
+#define RNDIS_MAJOR_VERSION^I^I0x00000001$

ERROR: code indent should never use tabs
#27: FILE: hw/net/rndis.h:8:
+#define RNDIS_MINOR_VERSION^I^I0x00000000$

ERROR: code indent should never use tabs
#30: FILE: hw/net/rndis.h:11:
+#define RNDIS_DF_CONNECTIONLESS^I^I0x00000001U$

ERROR: code indent should never use tabs
#31: FILE: hw/net/rndis.h:12:
+#define RNDIS_DF_CONNECTION_ORIENTED^I0x00000002U$

ERROR: code indent should never use tabs
#32: FILE: hw/net/rndis.h:13:
+#define RNDIS_DF_RAW_DATA^I^I0x00000004U$

ERROR: code indent should never use tabs
#39: FILE: hw/net/rndis.h:20:
+#define RNDIS_MSG_COMPLETION^I0x80000000$

ERROR: code indent should never use tabs
#40: FILE: hw/net/rndis.h:21:
+#define RNDIS_MSG_PACKET^I0x00000001^I/* 1-N packets */$

ERROR: code indent should never use tabs
#41: FILE: hw/net/rndis.h:22:
+#define RNDIS_MSG_INIT^I^I0x00000002$

ERROR: code indent should never use tabs
#42: FILE: hw/net/rndis.h:23:
+#define RNDIS_MSG_INIT_C^I(RNDIS_MSG_INIT|RNDIS_MSG_COMPLETION)$

ERROR: spaces required around that '|' (ctx:VxV)
#42: FILE: hw/net/rndis.h:23:
+#define RNDIS_MSG_INIT_C       (RNDIS_MSG_INIT|RNDIS_MSG_COMPLETION)
                                               ^

ERROR: code indent should never use tabs
#43: FILE: hw/net/rndis.h:24:
+#define RNDIS_MSG_HALT^I^I0x00000003$

ERROR: code indent should never use tabs
#44: FILE: hw/net/rndis.h:25:
+#define RNDIS_MSG_QUERY^I^I0x00000004$

ERROR: code indent should never use tabs
#45: FILE: hw/net/rndis.h:26:
+#define RNDIS_MSG_QUERY_C^I(RNDIS_MSG_QUERY|RNDIS_MSG_COMPLETION)$

ERROR: spaces required around that '|' (ctx:VxV)
#45: FILE: hw/net/rndis.h:26:
+#define RNDIS_MSG_QUERY_C      (RNDIS_MSG_QUERY|RNDIS_MSG_COMPLETION)
                                                ^

ERROR: code indent should never use tabs
#46: FILE: hw/net/rndis.h:27:
+#define RNDIS_MSG_SET^I^I0x00000005$

ERROR: code indent should never use tabs
#47: FILE: hw/net/rndis.h:28:
+#define RNDIS_MSG_SET_C^I^I(RNDIS_MSG_SET|RNDIS_MSG_COMPLETION)$

ERROR: spaces required around that '|' (ctx:VxV)
#47: FILE: hw/net/rndis.h:28:
+#define RNDIS_MSG_SET_C                (RNDIS_MSG_SET|RNDIS_MSG_COMPLETION)
                                                      ^

ERROR: code indent should never use tabs
#48: FILE: hw/net/rndis.h:29:
+#define RNDIS_MSG_RESET^I^I0x00000006$

ERROR: code indent should never use tabs
#49: FILE: hw/net/rndis.h:30:
+#define RNDIS_MSG_RESET_C^I(RNDIS_MSG_RESET|RNDIS_MSG_COMPLETION)$

ERROR: spaces required around that '|' (ctx:VxV)
#49: FILE: hw/net/rndis.h:30:
+#define RNDIS_MSG_RESET_C      (RNDIS_MSG_RESET|RNDIS_MSG_COMPLETION)
                                                ^

ERROR: code indent should never use tabs
#50: FILE: hw/net/rndis.h:31:
+#define RNDIS_MSG_INDICATE^I0x00000007$

ERROR: code indent should never use tabs
#51: FILE: hw/net/rndis.h:32:
+#define RNDIS_MSG_KEEPALIVE^I0x00000008$

ERROR: code indent should never use tabs
#52: FILE: hw/net/rndis.h:33:
+#define RNDIS_MSG_KEEPALIVE_C^I(RNDIS_MSG_KEEPALIVE|RNDIS_MSG_COMPLETION)$

ERROR: spaces required around that '|' (ctx:VxV)
#52: FILE: hw/net/rndis.h:33:
+#define RNDIS_MSG_KEEPALIVE_C  (RNDIS_MSG_KEEPALIVE|RNDIS_MSG_COMPLETION)
                                                    ^

ERROR: code indent should never use tabs
#57: FILE: hw/net/rndis.h:38:
+#define RNDIS_MSG_BUS^I^I0xff000001$

ERROR: code indent should never use tabs
#60: FILE: hw/net/rndis.h:41:
+#define^IRNDIS_STATUS_SUCCESS^I^I^I0x00000000$

ERROR: code indent should never use tabs
#61: FILE: hw/net/rndis.h:42:
+#define RNDIS_STATUS_PENDING^I^I^I0x00000103$

ERROR: code indent should never use tabs
#64: FILE: hw/net/rndis.h:45:
+#define RNDIS_STATUS_NOT_RECOGNIZED^I^I0x00010001$

ERROR: code indent should never use tabs
#65: FILE: hw/net/rndis.h:46:
+#define RNDIS_STATUS_NOT_COPIED^I^I^I0x00010002$

ERROR: code indent should never use tabs
#66: FILE: hw/net/rndis.h:47:
+#define RNDIS_STATUS_NOT_ACCEPTED^I^I0x00010003$

ERROR: code indent should never use tabs
#67: FILE: hw/net/rndis.h:48:
+#define RNDIS_STATUS_CALL_ACTIVE^I^I0x00010007$

ERROR: code indent should never use tabs
#69: FILE: hw/net/rndis.h:50:
+#define RNDIS_STATUS_ONLINE^I^I^I0x40010003$

ERROR: code indent should never use tabs
#70: FILE: hw/net/rndis.h:51:
+#define RNDIS_STATUS_RESET_START^I^I0x40010004$

ERROR: code indent should never use tabs
#71: FILE: hw/net/rndis.h:52:
+#define RNDIS_STATUS_RESET_END^I^I^I0x40010005$

ERROR: code indent should never use tabs
#72: FILE: hw/net/rndis.h:53:
+#define RNDIS_STATUS_RING_STATUS^I^I0x40010006$

ERROR: code indent should never use tabs
#73: FILE: hw/net/rndis.h:54:
+#define RNDIS_STATUS_CLOSED^I^I^I0x40010007$

ERROR: code indent should never use tabs
#74: FILE: hw/net/rndis.h:55:
+#define RNDIS_STATUS_WAN_LINE_UP^I^I0x40010008$

ERROR: code indent should never use tabs
#75: FILE: hw/net/rndis.h:56:
+#define RNDIS_STATUS_WAN_LINE_DOWN^I^I0x40010009$

ERROR: code indent should never use tabs
#76: FILE: hw/net/rndis.h:57:
+#define RNDIS_STATUS_WAN_FRAGMENT^I^I0x4001000A$

ERROR: code indent should never use tabs
#77: FILE: hw/net/rndis.h:58:
+#define^IRNDIS_STATUS_MEDIA_CONNECT^I^I0x4001000B$

ERROR: code indent should never use tabs
#78: FILE: hw/net/rndis.h:59:
+#define^IRNDIS_STATUS_MEDIA_DISCONNECT^I^I0x4001000C$

ERROR: code indent should never use tabs
#79: FILE: hw/net/rndis.h:60:
+#define RNDIS_STATUS_HARDWARE_LINE_UP^I^I0x4001000D$

ERROR: code indent should never use tabs
#80: FILE: hw/net/rndis.h:61:
+#define RNDIS_STATUS_HARDWARE_LINE_DOWN^I^I0x4001000E$

ERROR: code indent should never use tabs
#81: FILE: hw/net/rndis.h:62:
+#define RNDIS_STATUS_INTERFACE_UP^I^I0x4001000F$

ERROR: code indent should never use tabs
#82: FILE: hw/net/rndis.h:63:
+#define RNDIS_STATUS_INTERFACE_DOWN^I^I0x40010010$

ERROR: code indent should never use tabs
#83: FILE: hw/net/rndis.h:64:
+#define RNDIS_STATUS_MEDIA_BUSY^I^I^I0x40010011$

ERROR: code indent should never use tabs
#84: FILE: hw/net/rndis.h:65:
+#define^IRNDIS_STATUS_MEDIA_SPECIFIC_INDICATION^I0x40010012$

ERROR: code indent should never use tabs
#85: FILE: hw/net/rndis.h:66:
+#define RNDIS_STATUS_WW_INDICATION^I^IRDIA_SPECIFIC_INDICATION$

ERROR: code indent should never use tabs
#86: FILE: hw/net/rndis.h:67:
+#define RNDIS_STATUS_LINK_SPEED_CHANGE^I^I0x40010013L$

ERROR: code indent should never use tabs
#87: FILE: hw/net/rndis.h:68:
+#define RNDIS_STATUS_NETWORK_CHANGE^I^I0x40010018$

ERROR: code indent should never use tabs
#89: FILE: hw/net/rndis.h:70:
+#define RNDIS_STATUS_NOT_RESETTABLE^I^I0x80010001$

ERROR: code indent should never use tabs
#90: FILE: hw/net/rndis.h:71:
+#define RNDIS_STATUS_SOFT_ERRORS^I^I0x80010003$

ERROR: code indent should never use tabs
#91: FILE: hw/net/rndis.h:72:
+#define RNDIS_STATUS_HARD_ERRORS^I^I0x80010004$

ERROR: code indent should never use tabs
#92: FILE: hw/net/rndis.h:73:
+#define RNDIS_STATUS_BUFFER_OVERFLOW^I^I0x80000005$

ERROR: code indent should never use tabs
#94: FILE: hw/net/rndis.h:75:
+#define^IRNDIS_STATUS_FAILURE^I^I^I0xC0000001$

ERROR: code indent should never use tabs
#95: FILE: hw/net/rndis.h:76:
+#define RNDIS_STATUS_RESOURCES^I^I^I0xC000009A$

ERROR: code indent should never use tabs
#96: FILE: hw/net/rndis.h:77:
+#define^IRNDIS_STATUS_NOT_SUPPORTED^I^I0xc00000BB$

ERROR: code indent should never use tabs
#97: FILE: hw/net/rndis.h:78:
+#define RNDIS_STATUS_CLOSING^I^I^I0xC0010002$

ERROR: code indent should never use tabs
#98: FILE: hw/net/rndis.h:79:
+#define RNDIS_STATUS_BAD_VERSION^I^I0xC0010004$

ERROR: code indent should never use tabs
#99: FILE: hw/net/rndis.h:80:
+#define RNDIS_STATUS_BAD_CHARACTERISTICS^I0xC0010005$

ERROR: code indent should never use tabs
#100: FILE: hw/net/rndis.h:81:
+#define RNDIS_STATUS_ADAPTER_NOT_FOUND^I^I0xC0010006$

ERROR: code indent should never use tabs
#101: FILE: hw/net/rndis.h:82:
+#define RNDIS_STATUS_OPEN_FAILED^I^I0xC0010007$

ERROR: code indent should never use tabs
#102: FILE: hw/net/rndis.h:83:
+#define RNDIS_STATUS_DEVICE_FAILED^I^I0xC0010008$

ERROR: code indent should never use tabs
#103: FILE: hw/net/rndis.h:84:
+#define RNDIS_STATUS_MULTICAST_FULL^I^I0xC0010009$

ERROR: code indent should never use tabs
#104: FILE: hw/net/rndis.h:85:
+#define RNDIS_STATUS_MULTICAST_EXISTS^I^I0xC001000A$

ERROR: code indent should never use tabs
#105: FILE: hw/net/rndis.h:86:
+#define RNDIS_STATUS_MULTICAST_NOT_FOUND^I0xC001000B$

ERROR: code indent should never use tabs
#106: FILE: hw/net/rndis.h:87:
+#define RNDIS_STATUS_REQUEST_ABORTED^I^I0xC001000C$

ERROR: code indent should never use tabs
#107: FILE: hw/net/rndis.h:88:
+#define RNDIS_STATUS_RESET_IN_PROGRESS^I^I0xC001000D$

ERROR: code indent should never use tabs
#108: FILE: hw/net/rndis.h:89:
+#define RNDIS_STATUS_CLOSING_INDICATING^I^I0xC001000E$

ERROR: code indent should never use tabs
#109: FILE: hw/net/rndis.h:90:
+#define RNDIS_STATUS_INVALID_PACKET^I^I0xC001000F$

ERROR: code indent should never use tabs
#110: FILE: hw/net/rndis.h:91:
+#define RNDIS_STATUS_OPEN_LIST_FULL^I^I0xC0010010$

ERROR: code indent should never use tabs
#111: FILE: hw/net/rndis.h:92:
+#define RNDIS_STATUS_ADAPTER_NOT_READY^I^I0xC0010011$

ERROR: code indent should never use tabs
#112: FILE: hw/net/rndis.h:93:
+#define RNDIS_STATUS_ADAPTER_NOT_OPEN^I^I0xC0010012$

ERROR: code indent should never use tabs
#113: FILE: hw/net/rndis.h:94:
+#define RNDIS_STATUS_NOT_INDICATING^I^I0xC0010013$

ERROR: code indent should never use tabs
#114: FILE: hw/net/rndis.h:95:
+#define RNDIS_STATUS_INVALID_LENGTH^I^I0xC0010014$

ERROR: code indent should never use tabs
#115: FILE: hw/net/rndis.h:96:
+#define^IRNDIS_STATUS_INVALID_DATA^I^I0xC0010015$

ERROR: code indent should never use tabs
#116: FILE: hw/net/rndis.h:97:
+#define RNDIS_STATUS_BUFFER_TOO_SHORT^I^I0xC0010016$

ERROR: code indent should never use tabs
#117: FILE: hw/net/rndis.h:98:
+#define RNDIS_STATUS_INVALID_OID^I^I0xC0010017$

ERROR: code indent should never use tabs
#118: FILE: hw/net/rndis.h:99:
+#define RNDIS_STATUS_ADAPTER_REMOVED^I^I0xC0010018$

ERROR: code indent should never use tabs
#119: FILE: hw/net/rndis.h:100:
+#define RNDIS_STATUS_UNSUPPORTED_MEDIA^I^I0xC0010019$

ERROR: code indent should never use tabs
#120: FILE: hw/net/rndis.h:101:
+#define RNDIS_STATUS_GROUP_ADDRESS_IN_USE^I0xC001001A$

ERROR: code indent should never use tabs
#121: FILE: hw/net/rndis.h:102:
+#define RNDIS_STATUS_FILE_NOT_FOUND^I^I0xC001001B$

ERROR: code indent should never use tabs
#122: FILE: hw/net/rndis.h:103:
+#define RNDIS_STATUS_ERROR_READING_FILE^I^I0xC001001C$

ERROR: code indent should never use tabs
#123: FILE: hw/net/rndis.h:104:
+#define RNDIS_STATUS_ALREADY_MAPPED^I^I0xC001001D$

ERROR: code indent should never use tabs
#124: FILE: hw/net/rndis.h:105:
+#define RNDIS_STATUS_RESOURCE_CONFLICT^I^I0xC001001E$

ERROR: code indent should never use tabs
#125: FILE: hw/net/rndis.h:106:
+#define RNDIS_STATUS_NO_CABLE^I^I^I0xC001001F$

ERROR: code indent should never use tabs
#127: FILE: hw/net/rndis.h:108:
+#define RNDIS_STATUS_INVALID_SAP^I^I0xC0010020$

ERROR: code indent should never use tabs
#128: FILE: hw/net/rndis.h:109:
+#define RNDIS_STATUS_SAP_IN_USE^I^I^I0xC0010021$

ERROR: code indent should never use tabs
#129: FILE: hw/net/rndis.h:110:
+#define RNDIS_STATUS_INVALID_ADDRESS^I^I0xC0010022$

ERROR: code indent should never use tabs
#130: FILE: hw/net/rndis.h:111:
+#define RNDIS_STATUS_VC_NOT_ACTIVATED^I^I0xC0010023$

ERROR: code indent should never use tabs
#131: FILE: hw/net/rndis.h:112:
+#define RNDIS_STATUS_DEST_OUT_OF_ORDER^I^I0xC0010024$

ERROR: code indent should never use tabs
#132: FILE: hw/net/rndis.h:113:
+#define RNDIS_STATUS_VC_NOT_AVAILABLE^I^I0xC0010025$

ERROR: code indent should never use tabs
#133: FILE: hw/net/rndis.h:114:
+#define RNDIS_STATUS_CELLRATE_NOT_AVAILABLE^I0xC0010026$

ERROR: code indent should never use tabs
#134: FILE: hw/net/rndis.h:115:
+#define RNDIS_STATUS_INCOMPATABLE_QOS^I^I0xC0010027$

ERROR: code indent should never use tabs
#135: FILE: hw/net/rndis.h:116:
+#define RNDIS_STATUS_AAL_PARAMS_UNSUPPORTED^I0xC0010028$

ERROR: code indent should never use tabs
#136: FILE: hw/net/rndis.h:117:
+#define RNDIS_STATUS_NO_ROUTE_TO_DESTINATION^I0xC0010029$

ERROR: code indent should never use tabs
#138: FILE: hw/net/rndis.h:119:
+#define RNDIS_STATUS_TOKEN_RING_OPEN_ERROR^I0xC0011000$

ERROR: code indent should never use tabs
#141: FILE: hw/net/rndis.h:122:
+#define^IRNDIS_PHYSICAL_MEDIUM_UNSPECIFIED^I0x00000000$

ERROR: code indent should never use tabs
#142: FILE: hw/net/rndis.h:123:
+#define^IRNDIS_PHYSICAL_MEDIUM_WIRELESS_LAN^I0x00000001$

ERROR: code indent should never use tabs
#143: FILE: hw/net/rndis.h:124:
+#define^IRNDIS_PHYSICAL_MEDIUM_CABLE_MODEM^I0x00000002$

ERROR: code indent should never use tabs
#144: FILE: hw/net/rndis.h:125:
+#define^IRNDIS_PHYSICAL_MEDIUM_PHONE_LINE^I0x00000003$

ERROR: code indent should never use tabs
#145: FILE: hw/net/rndis.h:126:
+#define^IRNDIS_PHYSICAL_MEDIUM_POWER_LINE^I0x00000004$

ERROR: code indent should never use tabs
#146: FILE: hw/net/rndis.h:127:
+#define^IRNDIS_PHYSICAL_MEDIUM_DSL^I^I0x00000005$

ERROR: code indent should never use tabs
#147: FILE: hw/net/rndis.h:128:
+#define^IRNDIS_PHYSICAL_MEDIUM_FIBRE_CHANNEL^I0x00000006$

ERROR: code indent should never use tabs
#148: FILE: hw/net/rndis.h:129:
+#define^IRNDIS_PHYSICAL_MEDIUM_1394^I^I0x00000007$

ERROR: code indent should never use tabs
#149: FILE: hw/net/rndis.h:130:
+#define^IRNDIS_PHYSICAL_MEDIUM_WIRELESS_WAN^I0x00000008$

ERROR: code indent should never use tabs
#150: FILE: hw/net/rndis.h:131:
+#define^IRNDIS_PHYSICAL_MEDIUM_MAX^I^I0x00000009$

ERROR: code indent should never use tabs
#153: FILE: hw/net/rndis.h:134:
+#define RNDIS_MEDIUM_UNSPECIFIED^I^I0x00000000$

ERROR: code indent should never use tabs
#154: FILE: hw/net/rndis.h:135:
+#define RNDIS_MEDIUM_802_3^I^I^I0x00000000$

ERROR: code indent should never use tabs
#155: FILE: hw/net/rndis.h:136:
+#define RNDIS_MEDIUM_802_5^I^I^I0x00000001$

ERROR: code indent should never use tabs
#156: FILE: hw/net/rndis.h:137:
+#define RNDIS_MEDIUM_FDDI^I^I^I0x00000002$

ERROR: code indent should never use tabs
#157: FILE: hw/net/rndis.h:138:
+#define RNDIS_MEDIUM_WAN^I^I^I0x00000003$

ERROR: code indent should never use tabs
#158: FILE: hw/net/rndis.h:139:
+#define RNDIS_MEDIUM_LOCAL_TALK^I^I^I0x00000004$

ERROR: code indent should never use tabs
#159: FILE: hw/net/rndis.h:140:
+#define RNDIS_MEDIUM_ARCNET_RAW^I^I^I0x00000006$

ERROR: code indent should never use tabs
#160: FILE: hw/net/rndis.h:141:
+#define RNDIS_MEDIUM_ARCNET_878_2^I^I0x00000007$

ERROR: code indent should never use tabs
#161: FILE: hw/net/rndis.h:142:
+#define RNDIS_MEDIUM_ATM^I^I^I0x00000008$

ERROR: code indent should never use tabs
#162: FILE: hw/net/rndis.h:143:
+#define RNDIS_MEDIUM_WIRELESS_LAN^I^I0x00000009$

ERROR: code indent should never use tabs
#163: FILE: hw/net/rndis.h:144:
+#define RNDIS_MEDIUM_IRDA^I^I^I0x0000000A$

ERROR: code indent should never use tabs
#164: FILE: hw/net/rndis.h:145:
+#define RNDIS_MEDIUM_BPC^I^I^I0x0000000B$

ERROR: code indent should never use tabs
#165: FILE: hw/net/rndis.h:146:
+#define RNDIS_MEDIUM_CO_WAN^I^I^I0x0000000C$

ERROR: code indent should never use tabs
#166: FILE: hw/net/rndis.h:147:
+#define RNDIS_MEDIUM_1394^I^I^I0x0000000D$

ERROR: code indent should never use tabs
#168: FILE: hw/net/rndis.h:149:
+#define RNDIS_MEDIUM_MAX^I^I^I0x0000000E$

ERROR: code indent should never use tabs
#171: FILE: hw/net/rndis.h:152:
+#define RNDIS_MEDIA_STATE_CONNECTED^I^I0x00000000$

ERROR: code indent should never use tabs
#172: FILE: hw/net/rndis.h:153:
+#define RNDIS_MEDIA_STATE_DISCONNECTED^I^I0x00000001$

ERROR: code indent should never use tabs
#175: FILE: hw/net/rndis.h:156:
+#define RNDIS_PACKET_TYPE_DIRECTED^I^I0x00000001$

ERROR: code indent should never use tabs
#176: FILE: hw/net/rndis.h:157:
+#define RNDIS_PACKET_TYPE_MULTICAST^I^I0x00000002$

ERROR: code indent should never use tabs
#177: FILE: hw/net/rndis.h:158:
+#define RNDIS_PACKET_TYPE_ALL_MULTICAST^I^I0x00000004$

ERROR: code indent should never use tabs
#178: FILE: hw/net/rndis.h:159:
+#define RNDIS_PACKET_TYPE_BROADCAST^I^I0x00000008$

ERROR: code indent should never use tabs
#179: FILE: hw/net/rndis.h:160:
+#define RNDIS_PACKET_TYPE_SOURCE_ROUTING^I0x00000010$

ERROR: code indent should never use tabs
#180: FILE: hw/net/rndis.h:161:
+#define RNDIS_PACKET_TYPE_PROMISCUOUS^I^I0x00000020$

ERROR: code indent should never use tabs
#181: FILE: hw/net/rndis.h:162:
+#define RNDIS_PACKET_TYPE_SMT^I^I^I0x00000040$

ERROR: code indent should never use tabs
#182: FILE: hw/net/rndis.h:163:
+#define RNDIS_PACKET_TYPE_ALL_LOCAL^I^I0x00000080$

ERROR: code indent should never use tabs
#183: FILE: hw/net/rndis.h:164:
+#define RNDIS_PACKET_TYPE_GROUP^I^I^I0x00001000$

ERROR: code indent should never use tabs
#184: FILE: hw/net/rndis.h:165:
+#define RNDIS_PACKET_TYPE_ALL_FUNCTIONAL^I0x00002000$

ERROR: code indent should never use tabs
#185: FILE: hw/net/rndis.h:166:
+#define RNDIS_PACKET_TYPE_FUNCTIONAL^I^I0x00004000$

ERROR: code indent should never use tabs
#186: FILE: hw/net/rndis.h:167:
+#define RNDIS_PACKET_TYPE_MAC_FRAME^I^I0x00008000$

ERROR: code indent should never use tabs
#189: FILE: hw/net/rndis.h:170:
+#define RNDIS_MINIPORT_BUS_MASTER^I^I^I0x00000001$

ERROR: code indent should never use tabs
#190: FILE: hw/net/rndis.h:171:
+#define RNDIS_MINIPORT_WDM_DRIVER^I^I^I0x00000002$

ERROR: code indent should never use tabs
#191: FILE: hw/net/rndis.h:172:
+#define RNDIS_MINIPORT_SG_LIST^I^I^I^I0x00000004$

ERROR: code indent should never use tabs
#192: FILE: hw/net/rndis.h:173:
+#define RNDIS_MINIPORT_SUPPORTS_MEDIA_QUERY^I^I0x00000008$

ERROR: code indent should never use tabs
#193: FILE: hw/net/rndis.h:174:
+#define RNDIS_MINIPORT_INDICATES_PACKETS^I^I0x00000010$

ERROR: code indent should never use tabs
#194: FILE: hw/net/rndis.h:175:
+#define RNDIS_MINIPORT_IGNORE_PACKET_QUEUE^I^I0x00000020$

ERROR: code indent should never use tabs
#195: FILE: hw/net/rndis.h:176:
+#define RNDIS_MINIPORT_IGNORE_REQUEST_QUEUE^I^I0x00000040$

ERROR: code indent should never use tabs
#196: FILE: hw/net/rndis.h:177:
+#define RNDIS_MINIPORT_IGNORE_TOKEN_RING_ERRORS^I^I0x00000080$

ERROR: code indent should never use tabs
#197: FILE: hw/net/rndis.h:178:
+#define RNDIS_MINIPORT_INTERMEDIATE_DRIVER^I^I0x00000100$

ERROR: code indent should never use tabs
#198: FILE: hw/net/rndis.h:179:
+#define RNDIS_MINIPORT_IS_NDIS_5^I^I^I0x00000200$

ERROR: code indent should never use tabs
#199: FILE: hw/net/rndis.h:180:
+#define RNDIS_MINIPORT_IS_CO^I^I^I^I0x00000400$

ERROR: code indent should never use tabs
#200: FILE: hw/net/rndis.h:181:
+#define RNDIS_MINIPORT_DESERIALIZE^I^I^I0x00000800$

ERROR: code indent should never use tabs
#201: FILE: hw/net/rndis.h:182:
+#define RNDIS_MINIPORT_REQUIRES_MEDIA_POLLING^I^I0x00001000$

ERROR: code indent should never use tabs
#202: FILE: hw/net/rndis.h:183:
+#define RNDIS_MINIPORT_SUPPORTS_MEDIA_SENSE^I^I0x00002000$

ERROR: code indent should never use tabs
#203: FILE: hw/net/rndis.h:184:
+#define RNDIS_MINIPORT_NETBOOT_CARD^I^I^I0x00004000$

ERROR: code indent should never use tabs
#204: FILE: hw/net/rndis.h:185:
+#define RNDIS_MINIPORT_PM_SUPPORTED^I^I^I0x00008000$

ERROR: code indent should never use tabs
#205: FILE: hw/net/rndis.h:186:
+#define RNDIS_MINIPORT_SUPPORTS_MAC_ADDRESS_OVERWRITE^I0x00010000$

ERROR: code indent should never use tabs
#206: FILE: hw/net/rndis.h:187:
+#define RNDIS_MINIPORT_USES_SAFE_BUFFER_APIS^I^I0x00020000$

ERROR: code indent should never use tabs
#207: FILE: hw/net/rndis.h:188:
+#define RNDIS_MINIPORT_HIDDEN^I^I^I^I0x00040000$

ERROR: code indent should never use tabs
#208: FILE: hw/net/rndis.h:189:
+#define RNDIS_MINIPORT_SWENUM^I^I^I^I0x00080000$

ERROR: code indent should never use tabs
#209: FILE: hw/net/rndis.h:190:
+#define RNDIS_MINIPORT_SURPRISE_REMOVE_OK^I^I0x00100000$

ERROR: code indent should never use tabs
#210: FILE: hw/net/rndis.h:191:
+#define RNDIS_MINIPORT_NO_HALT_ON_SUSPEND^I^I0x00200000$

ERROR: code indent should never use tabs
#211: FILE: hw/net/rndis.h:192:
+#define RNDIS_MINIPORT_HARDWARE_DEVICE^I^I^I0x00400000$

ERROR: code indent should never use tabs
#212: FILE: hw/net/rndis.h:193:
+#define RNDIS_MINIPORT_SUPPORTS_CANCEL_SEND_PACKETS^I0x00800000$

ERROR: code indent should never use tabs
#213: FILE: hw/net/rndis.h:194:
+#define RNDIS_MINIPORT_64BITS_DMA^I^I^I0x01000000$

ERROR: code indent should never use tabs
#215: FILE: hw/net/rndis.h:196:
+#define RNDIS_MAC_OPTION_COPY_LOOKAHEAD_DATA^I^I0x00000001$

ERROR: code indent should never use tabs
#216: FILE: hw/net/rndis.h:197:
+#define RNDIS_MAC_OPTION_RECEIVE_SERIALIZED^I^I0x00000002$

ERROR: code indent should never use tabs
#217: FILE: hw/net/rndis.h:198:
+#define RNDIS_MAC_OPTION_TRANSFERS_NOT_PEND^I^I0x00000004$

ERROR: code indent should never use tabs
#218: FILE: hw/net/rndis.h:199:
+#define RNDIS_MAC_OPTION_NO_LOOPBACK^I^I^I0x00000008$

ERROR: code indent should never use tabs
#219: FILE: hw/net/rndis.h:200:
+#define RNDIS_MAC_OPTION_FULL_DUPLEX^I^I^I0x00000010$

ERROR: code indent should never use tabs
#220: FILE: hw/net/rndis.h:201:
+#define RNDIS_MAC_OPTION_EOTX_INDICATION^I^I0x00000020$

ERROR: code indent should never use tabs
#221: FILE: hw/net/rndis.h:202:
+#define RNDIS_MAC_OPTION_8021P_PRIORITY^I^I^I0x00000040$

ERROR: code indent should never use tabs
#222: FILE: hw/net/rndis.h:203:
+#define RNDIS_MAC_OPTION_RESERVED^I^I^I0x80000000$

ERROR: code indent should never use tabs
#226: FILE: hw/net/rndis.h:207:
+#define RNDIS_OID_GEN_SUPPORTED_LIST^I^I0x00010101$

ERROR: code indent should never use tabs
#227: FILE: hw/net/rndis.h:208:
+#define RNDIS_OID_GEN_HARDWARE_STATUS^I^I0x00010102$

ERROR: code indent should never use tabs
#228: FILE: hw/net/rndis.h:209:
+#define RNDIS_OID_GEN_MEDIA_SUPPORTED^I^I0x00010103$

ERROR: code indent should never use tabs
#229: FILE: hw/net/rndis.h:210:
+#define RNDIS_OID_GEN_MEDIA_IN_USE^I^I0x00010104$

ERROR: code indent should never use tabs
#230: FILE: hw/net/rndis.h:211:
+#define RNDIS_OID_GEN_MAXIMUM_LOOKAHEAD^I^I0x00010105$

ERROR: code indent should never use tabs
#231: FILE: hw/net/rndis.h:212:
+#define RNDIS_OID_GEN_MAXIMUM_FRAME_SIZE^I0x00010106$

ERROR: code indent should never use tabs
#232: FILE: hw/net/rndis.h:213:
+#define RNDIS_OID_GEN_LINK_SPEED^I^I0x00010107$

ERROR: code indent should never use tabs
#233: FILE: hw/net/rndis.h:214:
+#define RNDIS_OID_GEN_TRANSMIT_BUFFER_SPACE^I0x00010108$

ERROR: code indent should never use tabs
#234: FILE: hw/net/rndis.h:215:
+#define RNDIS_OID_GEN_RECEIVE_BUFFER_SPACE^I0x00010109$

ERROR: code indent should never use tabs
#235: FILE: hw/net/rndis.h:216:
+#define RNDIS_OID_GEN_TRANSMIT_BLOCK_SIZE^I0x0001010A$

ERROR: code indent should never use tabs
#236: FILE: hw/net/rndis.h:217:
+#define RNDIS_OID_GEN_RECEIVE_BLOCK_SIZE^I0x0001010B$

ERROR: code indent should never use tabs
#237: FILE: hw/net/rndis.h:218:
+#define RNDIS_OID_GEN_VENDOR_ID^I^I^I0x0001010C$

ERROR: code indent should never use tabs
#238: FILE: hw/net/rndis.h:219:
+#define RNDIS_OID_GEN_VENDOR_DESCRIPTION^I0x0001010D$

ERROR: code indent should never use tabs
#239: FILE: hw/net/rndis.h:220:
+#define RNDIS_OID_GEN_CURRENT_PACKET_FILTER^I0x0001010E$

ERROR: code indent should never use tabs
#240: FILE: hw/net/rndis.h:221:
+#define RNDIS_OID_GEN_CURRENT_LOOKAHEAD^I^I0x0001010F$

ERROR: code indent should never use tabs
#241: FILE: hw/net/rndis.h:222:
+#define RNDIS_OID_GEN_DRIVER_VERSION^I^I0x00010110$

ERROR: code indent should never use tabs
#242: FILE: hw/net/rndis.h:223:
+#define RNDIS_OID_GEN_MAXIMUM_TOTAL_SIZE^I0x00010111$

ERROR: code indent should never use tabs
#243: FILE: hw/net/rndis.h:224:
+#define RNDIS_OID_GEN_PROTOCOL_OPTIONS^I^I0x00010112$

ERROR: code indent should never use tabs
#244: FILE: hw/net/rndis.h:225:
+#define RNDIS_OID_GEN_MAC_OPTIONS^I^I0x00010113$

ERROR: code indent should never use tabs
#245: FILE: hw/net/rndis.h:226:
+#define RNDIS_OID_GEN_MEDIA_CONNECT_STATUS^I0x00010114$

ERROR: code indent should never use tabs
#246: FILE: hw/net/rndis.h:227:
+#define RNDIS_OID_GEN_MAXIMUM_SEND_PACKETS^I0x00010115$

ERROR: code indent should never use tabs
#247: FILE: hw/net/rndis.h:228:
+#define RNDIS_OID_GEN_VENDOR_DRIVER_VERSION^I0x00010116$

ERROR: code indent should never use tabs
#248: FILE: hw/net/rndis.h:229:
+#define RNDIS_OID_GEN_SUPPORTED_GUIDS^I^I0x00010117$

ERROR: code indent should never use tabs
#249: FILE: hw/net/rndis.h:230:
+#define RNDIS_OID_GEN_NETWORK_LAYER_ADDRESSES^I0x00010118$

ERROR: code indent should never use tabs
#250: FILE: hw/net/rndis.h:231:
+#define RNDIS_OID_GEN_TRANSPORT_HEADER_OFFSET^I0x00010119$

ERROR: code indent should never use tabs
#251: FILE: hw/net/rndis.h:232:
+#define RNDIS_OID_GEN_PHYSICAL_MEDIUM^I^I0x00010202$

ERROR: code indent should never use tabs
#252: FILE: hw/net/rndis.h:233:
+#define RNDIS_OID_GEN_MACHINE_NAME^I^I0x0001021A$

ERROR: code indent should never use tabs
#253: FILE: hw/net/rndis.h:234:
+#define RNDIS_OID_GEN_RNDIS_CONFIG_PARAMETER^I0x0001021B$

ERROR: code indent should never use tabs
#254: FILE: hw/net/rndis.h:235:
+#define RNDIS_OID_GEN_VLAN_ID^I^I^I0x0001021C$

ERROR: code indent should never use tabs
#257: FILE: hw/net/rndis.h:238:
+#define RNDIS_OID_GEN_MEDIA_CAPABILITIES^I0x00010201$

ERROR: code indent should never use tabs
#260: FILE: hw/net/rndis.h:241:
+#define RNDIS_OID_GEN_XMIT_OK^I^I^I0x00020101$

ERROR: code indent should never use tabs
#261: FILE: hw/net/rndis.h:242:
+#define RNDIS_OID_GEN_RCV_OK^I^I^I0x00020102$

ERROR: code indent should never use tabs
#262: FILE: hw/net/rndis.h:243:
+#define RNDIS_OID_GEN_XMIT_ERROR^I^I0x00020103$

ERROR: code indent should never use tabs
#263: FILE: hw/net/rndis.h:244:
+#define RNDIS_OID_GEN_RCV_ERROR^I^I^I0x00020104$

ERROR: code indent should never use tabs
#264: FILE: hw/net/rndis.h:245:
+#define RNDIS_OID_GEN_RCV_NO_BUFFER^I^I0x00020105$

ERROR: code indent should never use tabs
#267: FILE: hw/net/rndis.h:248:
+#define RNDIS_OID_GEN_DIRECTED_BYTES_XMIT^I0x00020201$

ERROR: code indent should never use tabs
#268: FILE: hw/net/rndis.h:249:
+#define RNDIS_OID_GEN_DIRECTED_FRAMES_XMIT^I0x00020202$

ERROR: code indent should never use tabs
#269: FILE: hw/net/rndis.h:250:
+#define RNDIS_OID_GEN_MULTICAST_BYTES_XMIT^I0x00020203$

ERROR: code indent should never use tabs
#270: FILE: hw/net/rndis.h:251:
+#define RNDIS_OID_GEN_MULTICAST_FRAMES_XMIT^I0x00020204$

ERROR: code indent should never use tabs
#271: FILE: hw/net/rndis.h:252:
+#define RNDIS_OID_GEN_BROADCAST_BYTES_XMIT^I0x00020205$

ERROR: code indent should never use tabs
#272: FILE: hw/net/rndis.h:253:
+#define RNDIS_OID_GEN_BROADCAST_FRAMES_XMIT^I0x00020206$

ERROR: code indent should never use tabs
#273: FILE: hw/net/rndis.h:254:
+#define RNDIS_OID_GEN_DIRECTED_BYTES_RCV^I0x00020207$

ERROR: code indent should never use tabs
#274: FILE: hw/net/rndis.h:255:
+#define RNDIS_OID_GEN_DIRECTED_FRAMES_RCV^I0x00020208$

ERROR: code indent should never use tabs
#275: FILE: hw/net/rndis.h:256:
+#define RNDIS_OID_GEN_MULTICAST_BYTES_RCV^I0x00020209$

ERROR: code indent should never use tabs
#276: FILE: hw/net/rndis.h:257:
+#define RNDIS_OID_GEN_MULTICAST_FRAMES_RCV^I0x0002020A$

ERROR: code indent should never use tabs
#277: FILE: hw/net/rndis.h:258:
+#define RNDIS_OID_GEN_BROADCAST_BYTES_RCV^I0x0002020B$

ERROR: code indent should never use tabs
#278: FILE: hw/net/rndis.h:259:
+#define RNDIS_OID_GEN_BROADCAST_FRAMES_RCV^I0x0002020C$

ERROR: code indent should never use tabs
#280: FILE: hw/net/rndis.h:261:
+#define RNDIS_OID_GEN_RCV_CRC_ERROR^I^I0x0002020D$

ERROR: code indent should never use tabs
#281: FILE: hw/net/rndis.h:262:
+#define RNDIS_OID_GEN_TRANSMIT_QUEUE_LENGTH^I0x0002020E$

ERROR: code indent should never use tabs
#283: FILE: hw/net/rndis.h:264:
+#define RNDIS_OID_GEN_GET_TIME_CAPS^I^I0x0002020F$

ERROR: code indent should never use tabs
#284: FILE: hw/net/rndis.h:265:
+#define RNDIS_OID_GEN_GET_NETCARD_TIME^I^I0x00020210$

ERROR: code indent should never use tabs
#286: FILE: hw/net/rndis.h:267:
+#define RNDIS_OID_GEN_NETCARD_LOAD^I^I0x00020211$

ERROR: code indent should never use tabs
#287: FILE: hw/net/rndis.h:268:
+#define RNDIS_OID_GEN_DEVICE_PROFILE^I^I0x00020212$

ERROR: code indent should never use tabs
#288: FILE: hw/net/rndis.h:269:
+#define RNDIS_OID_GEN_INIT_TIME_MS^I^I0x00020213$

ERROR: code indent should never use tabs
#289: FILE: hw/net/rndis.h:270:
+#define RNDIS_OID_GEN_RESET_COUNTS^I^I0x00020214$

ERROR: code indent should never use tabs
#290: FILE: hw/net/rndis.h:271:
+#define RNDIS_OID_GEN_MEDIA_SENSE_COUNTS^I0x00020215$

ERROR: code indent should never use tabs
#291: FILE: hw/net/rndis.h:272:
+#define RNDIS_OID_GEN_FRIENDLY_NAME^I^I0x00020216$

ERROR: code indent should never use tabs
#292: FILE: hw/net/rndis.h:273:
+#define RNDIS_OID_GEN_MINIPORT_INFO^I^I0x00020217$

ERROR: code indent should never use tabs
#293: FILE: hw/net/rndis.h:274:
+#define RNDIS_OID_GEN_RESET_VERIFY_PARAMETERS^I0x00020218$

ERROR: code indent should never use tabs
#297: FILE: hw/net/rndis.h:278:
+#define RNDIS_OID_GEN_CO_SUPPORTED_LIST^I^I0x00010101$

ERROR: code indent should never use tabs
#298: FILE: hw/net/rndis.h:279:
+#define RNDIS_OID_GEN_CO_HARDWARE_STATUS^I0x00010102$

ERROR: code indent should never use tabs
#299: FILE: hw/net/rndis.h:280:
+#define RNDIS_OID_GEN_CO_MEDIA_SUPPORTED^I0x00010103$

ERROR: code indent should never use tabs
#300: FILE: hw/net/rndis.h:281:
+#define RNDIS_OID_GEN_CO_MEDIA_IN_USE^I^I0x00010104$

ERROR: code indent should never use tabs
#301: FILE: hw/net/rndis.h:282:
+#define RNDIS_OID_GEN_CO_LINK_SPEED^I^I0x00010105$

ERROR: code indent should never use tabs
#302: FILE: hw/net/rndis.h:283:
+#define RNDIS_OID_GEN_CO_VENDOR_ID^I^I0x00010106$

ERROR: code indent should never use tabs
#303: FILE: hw/net/rndis.h:284:
+#define RNDIS_OID_GEN_CO_VENDOR_DESCRIPTION^I0x00010107$

ERROR: code indent should never use tabs
#304: FILE: hw/net/rndis.h:285:
+#define RNDIS_OID_GEN_CO_DRIVER_VERSION^I^I0x00010108$

ERROR: code indent should never use tabs
#305: FILE: hw/net/rndis.h:286:
+#define RNDIS_OID_GEN_CO_PROTOCOL_OPTIONS^I0x00010109$

ERROR: code indent should never use tabs
#306: FILE: hw/net/rndis.h:287:
+#define RNDIS_OID_GEN_CO_MAC_OPTIONS^I^I0x0001010A$

ERROR: code indent should never use tabs
#307: FILE: hw/net/rndis.h:288:
+#define RNDIS_OID_GEN_CO_MEDIA_CONNECT_STATUS^I0x0001010B$

ERROR: code indent should never use tabs
#308: FILE: hw/net/rndis.h:289:
+#define RNDIS_OID_GEN_CO_VENDOR_DRIVER_VERSION^I0x0001010C$

ERROR: code indent should never use tabs
#309: FILE: hw/net/rndis.h:290:
+#define RNDIS_OID_GEN_CO_MINIMUM_LINK_SPEED^I0x0001010D$

ERROR: code indent should never use tabs
#311: FILE: hw/net/rndis.h:292:
+#define RNDIS_OID_GEN_CO_GET_TIME_CAPS^I^I0x00010201$

ERROR: code indent should never use tabs
#312: FILE: hw/net/rndis.h:293:
+#define RNDIS_OID_GEN_CO_GET_NETCARD_TIME^I0x00010202$

ERROR: code indent should never use tabs
#315: FILE: hw/net/rndis.h:296:
+#define RNDIS_OID_GEN_CO_XMIT_PDUS_OK^I^I0x00020101$

ERROR: code indent should never use tabs
#316: FILE: hw/net/rndis.h:297:
+#define RNDIS_OID_GEN_CO_RCV_PDUS_OK^I^I0x00020102$

ERROR: code indent should never use tabs
#317: FILE: hw/net/rndis.h:298:
+#define RNDIS_OID_GEN_CO_XMIT_PDUS_ERROR^I0x00020103$

ERROR: code indent should never use tabs
#318: FILE: hw/net/rndis.h:299:
+#define RNDIS_OID_GEN_CO_RCV_PDUS_ERROR^I^I0x00020104$

ERROR: code indent should never use tabs
#319: FILE: hw/net/rndis.h:300:
+#define RNDIS_OID_GEN_CO_RCV_PDUS_NO_BUFFER^I0x00020105$

ERROR: code indent should never use tabs
#322: FILE: hw/net/rndis.h:303:
+#define RNDIS_OID_GEN_CO_RCV_CRC_ERROR^I^I0x00020201$

ERROR: code indent should never use tabs
#323: FILE: hw/net/rndis.h:304:
+#define RNDIS_OID_GEN_CO_TRANSMIT_QUEUE_LENGTH^I0x00020202$

ERROR: code indent should never use tabs
#324: FILE: hw/net/rndis.h:305:
+#define RNDIS_OID_GEN_CO_BYTES_XMIT^I^I0x00020203$

ERROR: code indent should never use tabs
#325: FILE: hw/net/rndis.h:306:
+#define RNDIS_OID_GEN_CO_BYTES_RCV^I^I0x00020204$

ERROR: code indent should never use tabs
#326: FILE: hw/net/rndis.h:307:
+#define RNDIS_OID_GEN_CO_BYTES_XMIT_OUTSTANDING^I0x00020205$

ERROR: code indent should never use tabs
#327: FILE: hw/net/rndis.h:308:
+#define RNDIS_OID_GEN_CO_NETCARD_LOAD^I^I0x00020206$

ERROR: code indent should never use tabs
#330: FILE: hw/net/rndis.h:311:
+#define RNDIS_OID_CO_ADD_PVC^I^I^I0xFF000001$

ERROR: code indent should never use tabs
#331: FILE: hw/net/rndis.h:312:
+#define RNDIS_OID_CO_DELETE_PVC^I^I^I0xFF000002$

ERROR: code indent should never use tabs
#332: FILE: hw/net/rndis.h:313:
+#define RNDIS_OID_CO_GET_CALL_INFORMATION^I0xFF000003$

ERROR: code indent should never use tabs
#333: FILE: hw/net/rndis.h:314:
+#define RNDIS_OID_CO_ADD_ADDRESS^I^I0xFF000004$

ERROR: code indent should never use tabs
#334: FILE: hw/net/rndis.h:315:
+#define RNDIS_OID_CO_DELETE_ADDRESS^I^I0xFF000005$

ERROR: code indent should never use tabs
#335: FILE: hw/net/rndis.h:316:
+#define RNDIS_OID_CO_GET_ADDRESSES^I^I0xFF000006$

ERROR: code indent should never use tabs
#336: FILE: hw/net/rndis.h:317:
+#define RNDIS_OID_CO_ADDRESS_CHANGE^I^I0xFF000007$

ERROR: code indent should never use tabs
#337: FILE: hw/net/rndis.h:318:
+#define RNDIS_OID_CO_SIGNALING_ENABLED^I^I0xFF000008$

ERROR: code indent should never use tabs
#338: FILE: hw/net/rndis.h:319:
+#define RNDIS_OID_CO_SIGNALING_DISABLED^I^I0xFF000009$

ERROR: code indent should never use tabs
#341: FILE: hw/net/rndis.h:322:
+#define RNDIS_OID_802_3_PERMANENT_ADDRESS^I0x01010101$

ERROR: code indent should never use tabs
#342: FILE: hw/net/rndis.h:323:
+#define RNDIS_OID_802_3_CURRENT_ADDRESS^I^I0x01010102$

ERROR: code indent should never use tabs
#343: FILE: hw/net/rndis.h:324:
+#define RNDIS_OID_802_3_MULTICAST_LIST^I^I0x01010103$

ERROR: code indent should never use tabs
#344: FILE: hw/net/rndis.h:325:
+#define RNDIS_OID_802_3_MAXIMUM_LIST_SIZE^I0x01010104$

ERROR: code indent should never use tabs
#345: FILE: hw/net/rndis.h:326:
+#define RNDIS_OID_802_3_MAC_OPTIONS^I^I0x01010105$

ERROR: code indent should never use tabs
#347: FILE: hw/net/rndis.h:328:
+#define RNDIS_802_3_MAC_OPTION_PRIORITY^I^I0x00000001$

ERROR: code indent should never use tabs
#349: FILE: hw/net/rndis.h:330:
+#define RNDIS_OID_802_3_RCV_ERROR_ALIGNMENT^I0x01020101$

ERROR: code indent should never use tabs
#350: FILE: hw/net/rndis.h:331:
+#define RNDIS_OID_802_3_XMIT_ONE_COLLISION^I0x01020102$

ERROR: code indent should never use tabs
#351: FILE: hw/net/rndis.h:332:
+#define RNDIS_OID_802_3_XMIT_MORE_COLLISIONS^I0x01020103$

ERROR: code indent should never use tabs
#353: FILE: hw/net/rndis.h:334:
+#define RNDIS_OID_802_3_XMIT_DEFERRED^I^I0x01020201$

ERROR: code indent should never use tabs
#354: FILE: hw/net/rndis.h:335:
+#define RNDIS_OID_802_3_XMIT_MAX_COLLISIONS^I0x01020202$

ERROR: code indent should never use tabs
#355: FILE: hw/net/rndis.h:336:
+#define RNDIS_OID_802_3_RCV_OVERRUN^I^I0x01020203$

ERROR: code indent should never use tabs
#356: FILE: hw/net/rndis.h:337:
+#define RNDIS_OID_802_3_XMIT_UNDERRUN^I^I0x01020204$

ERROR: code indent should never use tabs
#357: FILE: hw/net/rndis.h:338:
+#define RNDIS_OID_802_3_XMIT_HEARTBEAT_FAILURE^I0x01020205$

ERROR: code indent should never use tabs
#358: FILE: hw/net/rndis.h:339:
+#define RNDIS_OID_802_3_XMIT_TIMES_CRS_LOST^I0x01020206$

ERROR: code indent should never use tabs
#359: FILE: hw/net/rndis.h:340:
+#define RNDIS_OID_802_3_XMIT_LATE_COLLISIONS^I0x01020207$

ERROR: code indent should never use tabs
#361: FILE: hw/net/rndis.h:342:
+#define RNDIS_OID_802_11_BSSID^I^I^I^I0x0d010101$

ERROR: code indent should never use tabs
#362: FILE: hw/net/rndis.h:343:
+#define RNDIS_OID_802_11_SSID^I^I^I^I0x0d010102$

ERROR: code indent should never use tabs
#363: FILE: hw/net/rndis.h:344:
+#define RNDIS_OID_802_11_INFRASTRUCTURE_MODE^I^I0x0d010108$

ERROR: code indent should never use tabs
#364: FILE: hw/net/rndis.h:345:
+#define RNDIS_OID_802_11_ADD_WEP^I^I^I0x0d010113$

ERROR: code indent should never use tabs
#365: FILE: hw/net/rndis.h:346:
+#define RNDIS_OID_802_11_REMOVE_WEP^I^I^I0x0d010114$

ERROR: code indent should never use tabs
#366: FILE: hw/net/rndis.h:347:
+#define RNDIS_OID_802_11_DISASSOCIATE^I^I^I0x0d010115$

ERROR: code indent should never use tabs
#367: FILE: hw/net/rndis.h:348:
+#define RNDIS_OID_802_11_AUTHENTICATION_MODE^I^I0x0d010118$

ERROR: code indent should never use tabs
#368: FILE: hw/net/rndis.h:349:
+#define RNDIS_OID_802_11_PRIVACY_FILTER^I^I^I0x0d010119$

ERROR: code indent should never use tabs
#369: FILE: hw/net/rndis.h:350:
+#define RNDIS_OID_802_11_BSSID_LIST_SCAN^I^I0x0d01011a$

ERROR: code indent should never use tabs
#370: FILE: hw/net/rndis.h:351:
+#define RNDIS_OID_802_11_ENCRYPTION_STATUS^I^I0x0d01011b$

ERROR: code indent should never use tabs
#371: FILE: hw/net/rndis.h:352:
+#define RNDIS_OID_802_11_ADD_KEY^I^I^I0x0d01011d$

ERROR: code indent should never use tabs
#372: FILE: hw/net/rndis.h:353:
+#define RNDIS_OID_802_11_REMOVE_KEY^I^I^I0x0d01011e$

ERROR: code indent should never use tabs
#373: FILE: hw/net/rndis.h:354:
+#define RNDIS_OID_802_11_ASSOCIATION_INFORMATION^I0x0d01011f$

ERROR: code indent should never use tabs
#374: FILE: hw/net/rndis.h:355:
+#define RNDIS_OID_802_11_CAPABILITY^I^I^I0x0d010122$

ERROR: code indent should never use tabs
#375: FILE: hw/net/rndis.h:356:
+#define RNDIS_OID_802_11_PMKID^I^I^I^I0x0d010123$

ERROR: code indent should never use tabs
#376: FILE: hw/net/rndis.h:357:
+#define RNDIS_OID_802_11_NETWORK_TYPES_SUPPORTED^I0x0d010203$

ERROR: code indent should never use tabs
#377: FILE: hw/net/rndis.h:358:
+#define RNDIS_OID_802_11_NETWORK_TYPE_IN_USE^I^I0x0d010204$

ERROR: code indent should never use tabs
#378: FILE: hw/net/rndis.h:359:
+#define RNDIS_OID_802_11_TX_POWER_LEVEL^I^I^I0x0d010205$

ERROR: code indent should never use tabs
#379: FILE: hw/net/rndis.h:360:
+#define RNDIS_OID_802_11_RSSI^I^I^I^I0x0d010206$

ERROR: code indent should never use tabs
#380: FILE: hw/net/rndis.h:361:
+#define RNDIS_OID_802_11_RSSI_TRIGGER^I^I^I0x0d010207$

ERROR: code indent should never use tabs
#381: FILE: hw/net/rndis.h:362:
+#define RNDIS_OID_802_11_FRAGMENTATION_THRESHOLD^I0x0d010209$

ERROR: code indent should never use tabs
#382: FILE: hw/net/rndis.h:363:
+#define RNDIS_OID_802_11_RTS_THRESHOLD^I^I^I0x0d01020a$

ERROR: code indent should never use tabs
#383: FILE: hw/net/rndis.h:364:
+#define RNDIS_OID_802_11_SUPPORTED_RATES^I^I0x0d01020e$

ERROR: code indent should never use tabs
#384: FILE: hw/net/rndis.h:365:
+#define RNDIS_OID_802_11_CONFIGURATION^I^I^I0x0d010211$

ERROR: code indent should never use tabs
#385: FILE: hw/net/rndis.h:366:
+#define RNDIS_OID_802_11_POWER_MODE^I^I^I0x0d010216$

ERROR: code indent should never use tabs
#386: FILE: hw/net/rndis.h:367:
+#define RNDIS_OID_802_11_BSSID_LIST^I^I^I0x0d010217$

ERROR: code indent should never use tabs
#389: FILE: hw/net/rndis.h:370:
+#define RNDIS_OID_PNP_CAPABILITIES^I^I0xFD010100$

ERROR: code indent should never use tabs
#390: FILE: hw/net/rndis.h:371:
+#define RNDIS_OID_PNP_SET_POWER^I^I^I0xFD010101$

ERROR: code indent should never use tabs
#391: FILE: hw/net/rndis.h:372:
+#define RNDIS_OID_PNP_QUERY_POWER^I^I0xFD010102$

ERROR: code indent should never use tabs
#392: FILE: hw/net/rndis.h:373:
+#define RNDIS_OID_PNP_ADD_WAKE_UP_PATTERN^I0xFD010103$

ERROR: code indent should never use tabs
#393: FILE: hw/net/rndis.h:374:
+#define RNDIS_OID_PNP_REMOVE_WAKE_UP_PATTERN^I0xFD010104$

ERROR: code indent should never use tabs
#394: FILE: hw/net/rndis.h:375:
+#define RNDIS_OID_PNP_ENABLE_WAKE_UP^I^I0xFD010106$

ERROR: code indent should never use tabs
#397: FILE: hw/net/rndis.h:378:
+#define RNDIS_DEVICE_WAKE_UP_ENABLE^I^I^I0x00000001$

ERROR: code indent should never use tabs
#398: FILE: hw/net/rndis.h:379:
+#define RNDIS_DEVICE_WAKE_ON_PATTERN_MATCH_ENABLE^I0x00000002$

ERROR: code indent should never use tabs
#399: FILE: hw/net/rndis.h:380:
+#define RNDIS_DEVICE_WAKE_ON_MAGIC_PACKET_ENABLE^I0x00000004$

ERROR: code indent should never use tabs
#401: FILE: hw/net/rndis.h:382:
+#define REMOTE_CONDIS_MP_CREATE_VC_MSG^I^I0x00008001$

ERROR: code indent should never use tabs
#402: FILE: hw/net/rndis.h:383:
+#define REMOTE_CONDIS_MP_DELETE_VC_MSG^I^I0x00008002$

ERROR: code indent should never use tabs
#403: FILE: hw/net/rndis.h:384:
+#define REMOTE_CONDIS_MP_ACTIVATE_VC_MSG^I0x00008005$

ERROR: code indent should never use tabs
#404: FILE: hw/net/rndis.h:385:
+#define REMOTE_CONDIS_MP_DEACTIVATE_VC_MSG^I0x00008006$

ERROR: code indent should never use tabs
#405: FILE: hw/net/rndis.h:386:
+#define REMOTE_CONDIS_INDICATE_STATUS_MSG^I0x00008007$

ERROR: code indent should never use tabs
#407: FILE: hw/net/rndis.h:388:
+#define REMOTE_CONDIS_MP_CREATE_VC_CMPLT^I0x80008001$

ERROR: code indent should never use tabs
#408: FILE: hw/net/rndis.h:389:
+#define REMOTE_CONDIS_MP_DELETE_VC_CMPLT^I0x80008002$

ERROR: code indent should never use tabs
#409: FILE: hw/net/rndis.h:390:
+#define REMOTE_CONDIS_MP_ACTIVATE_VC_CMPLT^I0x80008005$

ERROR: code indent should never use tabs
#410: FILE: hw/net/rndis.h:391:
+#define REMOTE_CONDIS_MP_DEACTIVATE_VC_CMPLT^I0x80008006$

total: 323 errors, 0 warnings, 391 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 29/34: net: add Hyper-V/VMBus network protocol definitions...
ERROR: code indent should never use tabs
#45: FILE: hw/net/hvnet-proto.h:24:
+#define NDIS_OBJECT_TYPE_OFFLOAD^I0xa7$

ERROR: code indent should never use tabs
#164: FILE: hw/net/hvnet-proto.h:143:
+#define NVSP_INVALID_PROTOCOL_VERSION^I((uint32_t)0xFFFFFFFF)$

ERROR: code indent should never use tabs
#166: FILE: hw/net/hvnet-proto.h:145:
+#define NVSP_PROTOCOL_VERSION_1^I^I2$

ERROR: code indent should never use tabs
#167: FILE: hw/net/hvnet-proto.h:146:
+#define NVSP_PROTOCOL_VERSION_2^I^I0x30002$

ERROR: code indent should never use tabs
#168: FILE: hw/net/hvnet-proto.h:147:
+#define NVSP_PROTOCOL_VERSION_4^I^I0x40000$

ERROR: code indent should never use tabs
#169: FILE: hw/net/hvnet-proto.h:148:
+#define NVSP_PROTOCOL_VERSION_5^I^I0x50000$

ERROR: code indent should never use tabs
#175: FILE: hw/net/hvnet-proto.h:154:
+    NVSP_MSG_TYPE_INIT^I^I^I= 1,$

ERROR: code indent should never use tabs
#176: FILE: hw/net/hvnet-proto.h:155:
+    NVSP_MSG_TYPE_INIT_COMPLETE^I^I= 2,$

ERROR: code indent should never use tabs
#178: FILE: hw/net/hvnet-proto.h:157:
+    NVSP_VERSION_MSG_START^I^I^I= 100,$

ERROR: code indent should never use tabs
#181: FILE: hw/net/hvnet-proto.h:160:
+    NVSP_MSG1_TYPE_SEND_NDIS_VER^I^I= NVSP_VERSION_MSG_START,$

ERROR: code indent should never use tabs
#548: FILE: hw/net/hvnet-proto.h:527:
+#define NETVSC_RECEIVE_BUFFER_SIZE^I^I(1024*1024*16)^I/* 16MB */$

ERROR: spaces required around that '*' (ctx:VxV)
#548: FILE: hw/net/hvnet-proto.h:527:
+#define NETVSC_RECEIVE_BUFFER_SIZE             (1024*1024*16)  /* 16MB */
                                                     ^

ERROR: spaces required around that '*' (ctx:VxV)
#548: FILE: hw/net/hvnet-proto.h:527:
+#define NETVSC_RECEIVE_BUFFER_SIZE             (1024*1024*16)  /* 16MB */
                                                          ^

ERROR: code indent should never use tabs
#549: FILE: hw/net/hvnet-proto.h:528:
+#define NETVSC_RECEIVE_BUFFER_SIZE_LEGACY^I(1024*1024*15)  /* 15MB */$

ERROR: spaces required around that '*' (ctx:VxV)
#549: FILE: hw/net/hvnet-proto.h:528:
+#define NETVSC_RECEIVE_BUFFER_SIZE_LEGACY      (1024*1024*15)  /* 15MB */
                                                     ^

ERROR: spaces required around that '*' (ctx:VxV)
#549: FILE: hw/net/hvnet-proto.h:528:
+#define NETVSC_RECEIVE_BUFFER_SIZE_LEGACY      (1024*1024*15)  /* 15MB */
                                                          ^

ERROR: code indent should never use tabs
#550: FILE: hw/net/hvnet-proto.h:529:
+#define NETVSC_SEND_BUFFER_SIZE^I^I^I(1024 * 1024 * 15)   /* 15MB */$

ERROR: code indent should never use tabs
#551: FILE: hw/net/hvnet-proto.h:530:
+#define NETVSC_INVALID_INDEX^I^I^I-1$

ERROR: code indent should never use tabs
#554: FILE: hw/net/hvnet-proto.h:533:
+#define NETVSC_RECEIVE_BUFFER_ID^I^I0xcafe$

ERROR: code indent should never use tabs
#555: FILE: hw/net/hvnet-proto.h:534:
+#define NETVSC_SEND_BUFFER_ID^I^I^I0$

ERROR: code indent should never use tabs
#739: FILE: hw/net/hvnet-proto.h:718:
+#define NDIS_OBJECT_TYPE_DEFAULT^I0x80$

ERROR: code indent should never use tabs
#755: FILE: hw/net/hvnet-proto.h:734:
+#define NDIS_TCP_LARGE_SEND_OFFLOAD_V2_TYPE^I1$

ERROR: code indent should never use tabs
#756: FILE: hw/net/hvnet-proto.h:735:
+#define NDIS_TCP_LARGE_SEND_OFFLOAD_IPV4^I0$

ERROR: code indent should never use tabs
#757: FILE: hw/net/hvnet-proto.h:736:
+#define NDIS_TCP_LARGE_SEND_OFFLOAD_IPV6^I1$

ERROR: code indent should never use tabs
#759: FILE: hw/net/hvnet-proto.h:738:
+#define VERSION_4_OFFLOAD_SIZE^I^I^I22$

ERROR: code indent should never use tabs
#764: FILE: hw/net/hvnet-proto.h:743:
+#define OID_TCP_OFFLOAD_PARAMETERS 0xFC01020C^I^I/* set only */$

ERROR: code indent should never use tabs
#775: FILE: hw/net/hvnet-proto.h:754:
+#define^INDIS_OFFLOAD_ENCAP_NONE^I^I0x0000$

ERROR: code indent should never use tabs
#776: FILE: hw/net/hvnet-proto.h:755:
+#define^INDIS_OFFLOAD_ENCAP_NULL^I^I0x0001$

ERROR: code indent should never use tabs
#777: FILE: hw/net/hvnet-proto.h:756:
+#define^INDIS_OFFLOAD_ENCAP_8023^I^I0x0002$

ERROR: code indent should never use tabs
#778: FILE: hw/net/hvnet-proto.h:757:
+#define^INDIS_OFFLOAD_ENCAP_8023PQ^I0x0004$

ERROR: code indent should never use tabs
#779: FILE: hw/net/hvnet-proto.h:758:
+#define^INDIS_OFFLOAD_ENCAP_8023PQ_OOB^I0x0008$

ERROR: code indent should never use tabs
#780: FILE: hw/net/hvnet-proto.h:759:
+#define^INDIS_OFFLOAD_ENCAP_RFC1483^I0x0010$

ERROR: code indent should never use tabs
#783: FILE: hw/net/hvnet-proto.h:762:
+    uint32_t^Iip4_txenc;$

ERROR: code indent should never use tabs
#784: FILE: hw/net/hvnet-proto.h:763:
+    uint32_t^Iip4_txcsum;$

ERROR: code indent should never use tabs
#785: FILE: hw/net/hvnet-proto.h:764:
+#define^INDIS_TXCSUM_CAP_IP4OPT^I^I0x001$

ERROR: code indent should never use tabs
#786: FILE: hw/net/hvnet-proto.h:765:
+#define^INDIS_TXCSUM_CAP_TCP4OPT^I^I0x004$

ERROR: code indent should never use tabs
#787: FILE: hw/net/hvnet-proto.h:766:
+#define^INDIS_TXCSUM_CAP_TCP4^I^I0x010$

ERROR: code indent should never use tabs
#788: FILE: hw/net/hvnet-proto.h:767:
+#define^INDIS_TXCSUM_CAP_UDP4^I^I0x040$

ERROR: code indent should never use tabs
#789: FILE: hw/net/hvnet-proto.h:768:
+#define^INDIS_TXCSUM_CAP_IP4^I^I0x100$

ERROR: code indent should never use tabs
#791: FILE: hw/net/hvnet-proto.h:770:
+#define NDIS_TXCSUM_ALL_TCP4^I(NDIS_TXCSUM_CAP_TCP4 | NDIS_TXCSUM_CAP_TCP4OPT)$

ERROR: code indent should never use tabs
#793: FILE: hw/net/hvnet-proto.h:772:
+    uint32_t^Iip4_rxenc;$

ERROR: code indent should never use tabs
#794: FILE: hw/net/hvnet-proto.h:773:
+    uint32_t^Iip4_rxcsum;$

ERROR: code indent should never use tabs
#795: FILE: hw/net/hvnet-proto.h:774:
+#define^INDIS_RXCSUM_CAP_IP4OPT^I^I0x001$

ERROR: code indent should never use tabs
#796: FILE: hw/net/hvnet-proto.h:775:
+#define^INDIS_RXCSUM_CAP_TCP4OPT^I^I0x004$

ERROR: code indent should never use tabs
#797: FILE: hw/net/hvnet-proto.h:776:
+#define^INDIS_RXCSUM_CAP_TCP4^I^I0x010$

ERROR: code indent should never use tabs
#798: FILE: hw/net/hvnet-proto.h:777:
+#define^INDIS_RXCSUM_CAP_UDP4^I^I0x040$

ERROR: code indent should never use tabs
#799: FILE: hw/net/hvnet-proto.h:778:
+#define^INDIS_RXCSUM_CAP_IP4^I^I0x100$

ERROR: code indent should never use tabs
#800: FILE: hw/net/hvnet-proto.h:779:
+    uint32_t^Iip6_txenc;$

ERROR: code indent should never use tabs
#801: FILE: hw/net/hvnet-proto.h:780:
+    uint32_t^Iip6_txcsum;$

ERROR: code indent should never use tabs
#802: FILE: hw/net/hvnet-proto.h:781:
+#define^INDIS_TXCSUM_CAP_IP6EXT^I^I0x001$

ERROR: code indent should never use tabs
#803: FILE: hw/net/hvnet-proto.h:782:
+#define^INDIS_TXCSUM_CAP_TCP6OPT^I^I0x004$

ERROR: code indent should never use tabs
#804: FILE: hw/net/hvnet-proto.h:783:
+#define^INDIS_TXCSUM_CAP_TCP6^I^I0x010$

ERROR: code indent should never use tabs
#805: FILE: hw/net/hvnet-proto.h:784:
+#define^INDIS_TXCSUM_CAP_UDP6^I^I0x040$

ERROR: code indent should never use tabs
#806: FILE: hw/net/hvnet-proto.h:785:
+    uint32_t^Iip6_rxenc;$

ERROR: code indent should never use tabs
#807: FILE: hw/net/hvnet-proto.h:786:
+    uint32_t^Iip6_rxcsum;$

ERROR: code indent should never use tabs
#808: FILE: hw/net/hvnet-proto.h:787:
+#define^INDIS_RXCSUM_CAP_IP6EXT^I^I0x001$

ERROR: code indent should never use tabs
#809: FILE: hw/net/hvnet-proto.h:788:
+#define^INDIS_RXCSUM_CAP_TCP6OPT^I^I0x004$

ERROR: code indent should never use tabs
#810: FILE: hw/net/hvnet-proto.h:789:
+#define^INDIS_RXCSUM_CAP_TCP6^I^I0x010$

ERROR: code indent should never use tabs
#811: FILE: hw/net/hvnet-proto.h:790:
+#define^INDIS_RXCSUM_CAP_UDP6^I^I0x040$

ERROR: code indent should never use tabs
#813: FILE: hw/net/hvnet-proto.h:792:
+#define NDIS_TXCSUM_ALL_TCP6^I(NDIS_TXCSUM_CAP_TCP6 |^I^I\$

ERROR: code indent should never use tabs
#814: FILE: hw/net/hvnet-proto.h:793:
+                                 NDIS_TXCSUM_CAP_TCP6OPT |^I\$

ERROR: code indent should never use tabs
#819: FILE: hw/net/hvnet-proto.h:798:
+    uint32_t^Iencap;$

ERROR: code indent should never use tabs
#820: FILE: hw/net/hvnet-proto.h:799:
+    uint32_t^Imaxsize;$

ERROR: code indent should never use tabs
#821: FILE: hw/net/hvnet-proto.h:800:
+    uint32_t^Iminsegs;$

ERROR: code indent should never use tabs
#822: FILE: hw/net/hvnet-proto.h:801:
+    uint32_t^Iopts;$

ERROR: code indent should never use tabs
#826: FILE: hw/net/hvnet-proto.h:805:
+    uint32_t^Iencap;$

ERROR: code indent should never use tabs
#827: FILE: hw/net/hvnet-proto.h:806:
+    uint32_t^Iah_esp;$

ERROR: code indent should never use tabs
#828: FILE: hw/net/hvnet-proto.h:807:
+    uint32_t^Ixport_tun;$

ERROR: code indent should never use tabs
#829: FILE: hw/net/hvnet-proto.h:808:
+    uint32_t^Iip4_opts;$

ERROR: code indent should never use tabs
#830: FILE: hw/net/hvnet-proto.h:809:
+    uint32_t^Iflags;$

ERROR: code indent should never use tabs
#831: FILE: hw/net/hvnet-proto.h:810:
+    uint32_t^Iip4_ah;$

ERROR: code indent should never use tabs
#832: FILE: hw/net/hvnet-proto.h:811:
+    uint32_t^Iip4_esp;$

ERROR: code indent should never use tabs
#836: FILE: hw/net/hvnet-proto.h:815:
+    uint32_t^Iip4_encap;$

ERROR: code indent should never use tabs
#837: FILE: hw/net/hvnet-proto.h:816:
+    uint32_t^Iip4_maxsz;$

ERROR: code indent should never use tabs
#838: FILE: hw/net/hvnet-proto.h:817:
+    uint32_t^Iip4_minsg;$

ERROR: code indent should never use tabs
#839: FILE: hw/net/hvnet-proto.h:818:
+    uint32_t^Iip6_encap;$

ERROR: code indent should never use tabs
#840: FILE: hw/net/hvnet-proto.h:819:
+    uint32_t^Iip6_maxsz;$

ERROR: code indent should never use tabs
#841: FILE: hw/net/hvnet-proto.h:820:
+    uint32_t^Iip6_minsg;$

ERROR: code indent should never use tabs
#842: FILE: hw/net/hvnet-proto.h:821:
+    uint32_t^Iip6_opts;$

ERROR: code indent should never use tabs
#843: FILE: hw/net/hvnet-proto.h:822:
+#define^INDIS_LSOV2_CAP_IP6EXT^I^I0x001$

ERROR: code indent should never use tabs
#844: FILE: hw/net/hvnet-proto.h:823:
+#define^INDIS_LSOV2_CAP_TCP6OPT^I^I0x004$

ERROR: code indent should never use tabs
#846: FILE: hw/net/hvnet-proto.h:825:
+#define NDIS_LSOV2_CAP_IP6^I^I(NDIS_LSOV2_CAP_IP6EXT | \$

ERROR: code indent should never use tabs
#851: FILE: hw/net/hvnet-proto.h:830:
+    uint32_t^Iencap;$

ERROR: code indent should never use tabs
#852: FILE: hw/net/hvnet-proto.h:831:
+    uint16_t^Iip6;$

ERROR: code indent should never use tabs
#853: FILE: hw/net/hvnet-proto.h:832:
+    uint16_t^Iip4opt;$

ERROR: code indent should never use tabs
#854: FILE: hw/net/hvnet-proto.h:833:
+    uint16_t^Iip6ext;$

ERROR: code indent should never use tabs
#855: FILE: hw/net/hvnet-proto.h:834:
+    uint16_t^Iah;$

ERROR: code indent should never use tabs
#856: FILE: hw/net/hvnet-proto.h:835:
+    uint16_t^Iesp;$

ERROR: code indent should never use tabs
#857: FILE: hw/net/hvnet-proto.h:836:
+    uint16_t^Iah_esp;$

ERROR: code indent should never use tabs
#858: FILE: hw/net/hvnet-proto.h:837:
+    uint16_t^Ixport;$

ERROR: code indent should never use tabs
#859: FILE: hw/net/hvnet-proto.h:838:
+    uint16_t^Itun;$

ERROR: code indent should never use tabs
#860: FILE: hw/net/hvnet-proto.h:839:
+    uint16_t^Ixport_tun;$

ERROR: code indent should never use tabs
#861: FILE: hw/net/hvnet-proto.h:840:
+    uint16_t^Ilso;$

ERROR: code indent should never use tabs
#862: FILE: hw/net/hvnet-proto.h:841:
+    uint16_t^Iextseq;$

ERROR: code indent should never use tabs
#863: FILE: hw/net/hvnet-proto.h:842:
+    uint32_t^Iudp_esp;$

ERROR: code indent should never use tabs
#864: FILE: hw/net/hvnet-proto.h:843:
+    uint32_t^Iauth;$

ERROR: code indent should never use tabs
#865: FILE: hw/net/hvnet-proto.h:844:
+    uint32_t^Icrypto;$

ERROR: code indent should never use tabs
#866: FILE: hw/net/hvnet-proto.h:845:
+    uint32_t^Isa_caps;$

ERROR: code indent should never use tabs
#870: FILE: hw/net/hvnet-proto.h:849:
+    uint16_t^Iip4;$

ERROR: code indent should never use tabs
#871: FILE: hw/net/hvnet-proto.h:850:
+    uint16_t^Iip6;$

ERROR: code indent should never use tabs
#875: FILE: hw/net/hvnet-proto.h:854:
+    uint32_t^Iflags;$

ERROR: code indent should never use tabs
#876: FILE: hw/net/hvnet-proto.h:855:
+    uint32_t^Imaxhdr;$

ERROR: code indent should never use tabs
#880: FILE: hw/net/hvnet-proto.h:859:
+    struct ndis_object_header^Iheader;$

ERROR: code indent should never use tabs
#881: FILE: hw/net/hvnet-proto.h:860:
+    struct ndis_csum_offload^Icsum;$

ERROR: code indent should never use tabs
#882: FILE: hw/net/hvnet-proto.h:861:
+    struct ndis_lsov1_offload^Ilsov1;$

ERROR: code indent should never use tabs
#883: FILE: hw/net/hvnet-proto.h:862:
+    struct ndis_ipsecv1_offload^Iipsecv1;$

ERROR: code indent should never use tabs
#884: FILE: hw/net/hvnet-proto.h:863:
+    struct ndis_lsov2_offload^Ilsov2;$

ERROR: code indent should never use tabs
#885: FILE: hw/net/hvnet-proto.h:864:
+    uint32_t^I^I^I^Iflags;$

ERROR: code indent should never use tabs
#887: FILE: hw/net/hvnet-proto.h:866:
+    struct ndis_ipsecv2_offload^Iipsecv2;$

ERROR: code indent should never use tabs
#889: FILE: hw/net/hvnet-proto.h:868:
+    struct ndis_rsc_offload^I^Irsc;$

ERROR: code indent should never use tabs
#890: FILE: hw/net/hvnet-proto.h:869:
+    struct ndis_encap_offload^Iencap_gre;$

ERROR: code indent should never use tabs
#893: FILE: hw/net/hvnet-proto.h:872:
+#define^INDIS_OFFLOAD_SIZE^I^Isizeof(struct ndis_offload)$

ERROR: code indent should never use tabs
#894: FILE: hw/net/hvnet-proto.h:873:
+#define^INDIS_OFFLOAD_SIZE_6_0^I^Ioffsetof(struct ndis_offload, ipsecv2)$

ERROR: code indent should never use tabs
#895: FILE: hw/net/hvnet-proto.h:874:
+#define^INDIS_OFFLOAD_SIZE_6_1^I^Ioffsetof(struct ndis_offload, rsc)$

ERROR: code indent should never use tabs
#1163: FILE: hw/net/hvnet-proto.h:1142:
+#define NDIS_PACKET_TYPE_DIRECTED^I0x00000001$

ERROR: code indent should never use tabs
#1164: FILE: hw/net/hvnet-proto.h:1143:
+#define NDIS_PACKET_TYPE_MULTICAST^I0x00000002$

ERROR: code indent should never use tabs
#1165: FILE: hw/net/hvnet-proto.h:1144:
+#define NDIS_PACKET_TYPE_ALL_MULTICAST^I0x00000004$

ERROR: code indent should never use tabs
#1166: FILE: hw/net/hvnet-proto.h:1145:
+#define NDIS_PACKET_TYPE_BROADCAST^I0x00000008$

ERROR: code indent should never use tabs
#1167: FILE: hw/net/hvnet-proto.h:1146:
+#define NDIS_PACKET_TYPE_SOURCE_ROUTING^I0x00000010$

ERROR: code indent should never use tabs
#1168: FILE: hw/net/hvnet-proto.h:1147:
+#define NDIS_PACKET_TYPE_PROMISCUOUS^I0x00000020$

ERROR: code indent should never use tabs
#1169: FILE: hw/net/hvnet-proto.h:1148:
+#define NDIS_PACKET_TYPE_SMT^I^I0x00000040$

ERROR: code indent should never use tabs
#1170: FILE: hw/net/hvnet-proto.h:1149:
+#define NDIS_PACKET_TYPE_ALL_LOCAL^I0x00000080$

ERROR: code indent should never use tabs
#1171: FILE: hw/net/hvnet-proto.h:1150:
+#define NDIS_PACKET_TYPE_GROUP^I^I0x00000100$

ERROR: code indent should never use tabs
#1172: FILE: hw/net/hvnet-proto.h:1151:
+#define NDIS_PACKET_TYPE_ALL_FUNCTIONAL^I0x00000200$

ERROR: code indent should never use tabs
#1173: FILE: hw/net/hvnet-proto.h:1152:
+#define NDIS_PACKET_TYPE_FUNCTIONAL^I0x00000400$

ERROR: code indent should never use tabs
#1174: FILE: hw/net/hvnet-proto.h:1153:
+#define NDIS_PACKET_TYPE_MAC_FRAME^I0x00000800$

total: 126 errors, 0 warnings, 1161 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 30/34: net: add Hyper-V/VMBus net adapter...
ERROR: open brace '{' following struct go on the same line
#109: FILE: hw/net/hv-net.c:81:
+typedef struct HvNetReq
+{

ERROR: if this code is redundant consider removing it
#147: FILE: hw/net/hv-net.c:119:
+#if 0

WARNING: line over 80 characters
#321: FILE: hw/net/hv-net.c:293:
+        error_report("%s: failed to get gpadl %u", __func__, 
net->rcvbuf_gpadl_id);

ERROR: do not use C99 // comments
#373: FILE: hw/net/hv-net.c:345:
+    msg_out->section_size = 1; //vmbus_gpadl_len(net->sndbuf_gpadl);

ERROR: if this code is redundant consider removing it
#415: FILE: hw/net/hv-net.c:387:
+#if 0

ERROR: if this code is redundant consider removing it
#418: FILE: hw/net/hv-net.c:390:
+#if 0

ERROR: if this code is redundant consider removing it
#439: FILE: hw/net/hv-net.c:411:
+#if 0

ERROR: do not use C99 // comments
#482: FILE: hw/net/hv-net.c:454:
+    // desc.hdr.sender_owns_set = ?;

ERROR: if this code is redundant consider removing it
#492: FILE: hw/net/hv-net.c:464:
+#if 0

ERROR: do not use C99 // comments
#682: FILE: hw/net/hv-net.c:654:
+        // return RNDIS_STATUS_NOT_SUPPORTED;

ERROR: if this code is redundant consider removing it
#689: FILE: hw/net/hv-net.c:661:
+#if 0

ERROR: do not use C99 // comments
#753: FILE: hw/net/hv-net.c:725:
+    // {.oid = RNDIS_OID_GEN_MAXIMUM_LOOKAHEAD},

ERROR: do not use C99 // comments
#771: FILE: hw/net/hv-net.c:743:
+    // {.oid = RNDIS_OID_GEN_SUPPORTED_GUIDS},

ERROR: do not use C99 // comments
#772: FILE: hw/net/hv-net.c:744:
+    // {.oid = RNDIS_OID_GEN_NETWORK_LAYER_ADDRESSES, .set = set_net_addr},

WARNING: line over 80 characters
#825: FILE: hw/net/hv-net.c:797:
+    error_report("%s: +++++++++ unknown query: %#x", __func__, 
net->rndis_query_oid);

ERROR: if this code is redundant consider removing it
#828: FILE: hw/net/hv-net.c:800:
+#if 0

ERROR: if this code is redundant consider removing it
#851: FILE: hw/net/hv-net.c:823:
+#if 0

ERROR: if this code is redundant consider removing it
#865: FILE: hw/net/hv-net.c:837:
+#if 0

WARNING: line over 80 characters
#890: FILE: hw/net/hv-net.c:862:
+        error_report("%s: +++++ unrecognized rndis ctrl: %#x", __func__, 
net->rndis_ctl);

WARNING: line over 80 characters
#932: FILE: hw/net/hv-net.c:904:
+        error_report("%s: too big RNDIS query info: %u", __func__, 
msg->info_buflen);

ERROR: if this code is redundant consider removing it
#997: FILE: hw/net/hv-net.c:969:
+#if 0

ERROR: if this code is redundant consider removing it
#1012: FILE: hw/net/hv-net.c:984:
+#if 0

ERROR: space required before the open parenthesis '('
#1029: FILE: hw/net/hv-net.c:1001:
+    switch(hdr->msg_type) {

ERROR: if this code is redundant consider removing it
#1066: FILE: hw/net/hv-net.c:1038:
+#if 0

ERROR: line over 90 characters
#1067: FILE: hw/net/hv-net.c:1039:
+    error_report("%s >>>> iov:%p num:%u secidx:%u secsz:%u", __func__, 
vmreq->iov, vmreq->num, msg_in->send_buf_section_index, 
msg_in->send_buf_section_size);

ERROR: line over 90 characters
#1103: FILE: hw/net/hv-net.c:1075:
+        error_report("%s: unexpected RNDIS packet channel: %u", __func__, 
msg_in->channel_type);

ERROR: if this code is redundant consider removing it
#1115: FILE: hw/net/hv-net.c:1087:
+#if 0

ERROR: if this code is redundant consider removing it
#1130: FILE: hw/net/hv-net.c:1102:
+#if 0

ERROR: if this code is redundant consider removing it
#1174: FILE: hw/net/hv-net.c:1146:
+#if 0

ERROR: code indent should never use tabs
#1242: FILE: hw/net/hv-net.c:1214:
+^I.data_offset = sizeof(pkt),$

ERROR: code indent should never use tabs
#1243: FILE: hw/net/hv-net.c:1215:
+^I.data_len = iov_size(iov, iovcnt),$

ERROR: code indent should never use tabs
#1247: FILE: hw/net/hv-net.c:1219:
+^I.msg_len = sizeof(hdr) + pkt.data_offset + pkt.data_len,$

ERROR: if this code is redundant consider removing it
#1284: FILE: hw/net/hv-net.c:1256:
+#if 0

total: 29 errors, 4 warnings, 1445 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 31/34: hv-net: add .bootindex support...
Checking PATCH 32/34: loader: allow arbitrary basename for fw_cfg file roms...
Checking PATCH 33/34: vmbus: add support for rom files...
Checking PATCH 34/34: hv-net: define default rom file name...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
[Prev in Thread]
Current Thread
[Next in Thread]
Re: [Qemu-devel] [RFC PATCH 29/34] net: add Hyper-V/VMBus network protocol definitions, (continued)
- [Qemu-devel] [RFC PATCH 32/34] loader: allow arbitrary basename for fw_cfg file roms, Roman Kagan, 2018/02/06
  - Re: [Qemu-devel] [RFC PATCH 32/34] loader: allow arbitrary basename for fw_cfg file roms, Paolo Bonzini, 2018/02/07
- [Qemu-devel] [RFC PATCH 30/34] net: add Hyper-V/VMBus net adapter, Roman Kagan, 2018/02/06
- [Qemu-devel] [RFC PATCH 33/34] vmbus: add support for rom files, Roman Kagan, 2018/02/06
  - Re: [Qemu-devel] [RFC PATCH 33/34] vmbus: add support for rom files, Paolo Bonzini, 2018/02/07
    - Re: [Qemu-devel] [RFC PATCH 33/34] vmbus: add support for rom files, Roman Kagan, 2018/02/07
- [Qemu-devel] [RFC PATCH 34/34] hv-net: define default rom file name, Roman Kagan, 2018/02/06
- Re: [Qemu-devel] [RFC PATCH 00/34] Hyper-V / VMBus, no-reply, 2018/02/06
- Re: [Qemu-devel] [RFC PATCH 00/34] Hyper-V / VMBus, no-reply <=
- Re: [Qemu-devel] [RFC PATCH 00/34] Hyper-V / VMBus, no-reply, 2018/02/06
- Re: [Qemu-devel] [RFC PATCH 00/34] Hyper-V / VMBus, no-reply, 2018/02/06
- Re: [Qemu-devel] [RFC PATCH 00/34] Hyper-V / VMBus, no-reply, 2018/02/06
- Re: [Qemu-devel] [RFC PATCH 00/34] Hyper-V / VMBus, no-reply, 2018/02/07
Prev by Date: Re: [Qemu-devel] [PATCH 08/10] cuda: factor out timebase-derived counter value and load time
Next by Date: Re: [Qemu-devel] [PATCH v3 01/25] nios2: 10m50_devboard: replace cpu_model with cpu_type
Previous by thread: Re: [Qemu-devel] [RFC PATCH 00/34] Hyper-V / VMBus
Next by thread: Re: [Qemu-devel] [RFC PATCH 00/34] Hyper-V / VMBus
Index(es):
- Date
- Thread