Re: [Qemu-devel] [PATCH v4] m68k: implement movep instruction

[Laurent Vivier]

Le 06/02/2018 à 13:44, Pavel Dovgalyuk a écrit :
> This patch implements movep instruction. It moves data between a data register
> and alternate bytes within the address space starting at the location
> specified and incrementing by two.
> 
> It was designed for the original 68000 and used in firmwares for
> interfacing the 8-bit peripherals through the 16-bit data bus.

Did you test this change with some kind of firmware?

> Without this patch opcode for this instruction is recognized as some bitop.
> 
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
> Signed-off-by: Mihail Abakumov <address@hidden>
> 
> --
> 
> v4: - fixed offset calculation misprint
> 
> v3: - simplified movep function code
>     - joined movep masks
> 
> v2: - disabled movep for Coldfire
>     - fixed gen_store/load usage
> ---
>  target/m68k/cpu.c       |    2 ++
>  target/m68k/cpu.h       |    1 +
>  target/m68k/translate.c |   46 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 49 insertions(+)

Tested-by: Laurent Vivier <address@hidden>

I've checked we have the same result on a real 68040

Reviewed-by: Laurent Vivier <address@hidden>

Thanks,
Laurent