Re: [Qemu-devel] [PATCH 0/2] block/ssh: Implement .bdrv_refresh_filename()

[Richard W.M. Jones]

On Mon, Feb 05, 2018 at 09:22:30PM +0100, Max Reitz wrote:
> This series implements .bdrv_refresh_filename() for the ssh block
> driver, along with an appropriate .bdrv_dirname() so we don't chop off
> query strings for backing files with relative filenames.
> 
> This series depends on my “block: Fix some filename generation issues”
> series and on Pino's “ssh: switch from libssh2 to libssh” patch.
> 
> Based-on: address@hidden
> Based-on: address@hidden
> 
> 
> Max Reitz (2):
>   block/ssh: Implement .bdrv_refresh_filename()
>   block/ssh: Implement .bdrv_dirname()
> 
>  block/ssh.c | 72 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++------

I reviewed the patches and I can't see anything wrong with them.

I guess that on "weird" remote machines getting the directory from a
filename is an impossible mission, but for reasonable hosts it's going
to be fine.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org