Re: [Qemu-devel] [PATCH v2 01/19] Use #include "..." for our own headers, <...> for others

[Thomas Huth]

On 01.02.2018 07:57, Markus Armbruster wrote:
> Thomas Huth <address@hidden> writes:
> 
>> On 31.01.2018 15:48, Markus Armbruster wrote:
>>> System headers should be included with <...>, our own headers with
>>> "...". Offenders tracked down with an ugly, brittle and probably
>>> buggy Perl script.  Previous iteration was commit a9c94277f0.
>>>
>>> Put the cleaned up system header includes first, except for the ones
>>> the next commit will delete.
>>
>> That's a little bit of code churn ... why not delete them here
>> immediately, or simply ignore these headers here and just delete them in
>> the next patch?
> 
> Ignore won't do, as scripts/clean-includes won't find them then.
> 
> Delete is possible, but requires still more explanation in the commit
> message.  Worthwhile?

I'd prefer to do it. Otherwise, if you look at the commit log of such a
file later, it just looks weird (first change the quotes, then
immediately delete it afterwards again). But if it's too cumbersome to
rework your patch this way right now, I'm also fine if you keep it as it
currently is.

 Thomas