[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 04/12] gtk: add and use DisplayOptions + Disp
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 04/12] gtk: add and use DisplayOptions + DisplayGTK |
Date: |
Wed, 31 Jan 2018 12:37:20 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 01/31/2018 12:02 PM, Markus Armbruster wrote:
> Got a QAPI remark, cc: Eric.
>
> Gerd Hoffmann <address@hidden> writes:
>
>> +++ b/qapi/ui.json
>> @@ -982,3 +982,62 @@
>> 'data': { '*device': 'str',
>> '*head' : 'int',
>> 'events' : [ 'InputEvent' ] } }
>> +
>> +
>> +##
>> +# @DisplayNoOpts:
>> +#
>> +# Empty struct for displays without config options.
>> +#
>> +# Since: 2.12
>> +#
>> +##
>> +{ 'struct' : 'DisplayNoOpts',
>> + 'data' : { } }
>
> This is the fifth empty struct (QCryptoBlockInfoQCow, NetdevNoneOptions,
> Abort, CpuInfoOther), not counting the QAPI frontend's internal one.
> Perhaps we should make the internal one a full built-in type. Not this
> patch's problem, of course.
Yeah, I really need to revive my patch that would allow:
>> +{ 'union' : 'DisplayOptions',
>> + 'base' : { 'type' : 'DisplayType',
>> + '*full-screen' : 'bool',
>> + '*window-close' : 'bool',
>> + '*gl' : 'bool' },
>> + 'discriminator' : 'type',
>> + 'data' : { 'default' : 'DisplayNoOpts',
>> + 'none' : 'DisplayNoOpts',
>> + 'gtk' : 'DisplayGTK' } }
'data': { 'none': {},
'gtk': 'DisplayGTK' }
Whoa - it's been a while!
https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg00311.html
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 05/12] sdl: use DisplayOptions, (continued)
- [Qemu-devel] [PATCH v2 05/12] sdl: use DisplayOptions, Gerd Hoffmann, 2018/01/29
- [Qemu-devel] [PATCH v2 09/12] cocoa: use DisplayOptions, Gerd Hoffmann, 2018/01/29
- [Qemu-devel] [PATCH v2 10/12] vl: drop full_screen variable, Gerd Hoffmann, 2018/01/29
- [Qemu-devel] [PATCH v2 11/12] vl: drop display_type variable, Gerd Hoffmann, 2018/01/29
- [Qemu-devel] [PATCH v2 07/12] egl-headless: use DisplayOptions, Gerd Hoffmann, 2018/01/29
- [Qemu-devel] [PATCH v2 01/12] vl: deprecate -no-frame, Gerd Hoffmann, 2018/01/29
- [Qemu-devel] [PATCH v2 06/12] vl: drop no_quit variable, Gerd Hoffmann, 2018/01/29
- [Qemu-devel] [PATCH v2 04/12] gtk: add and use DisplayOptions + DisplayGTK, Gerd Hoffmann, 2018/01/29
- [Qemu-devel] [PATCH v2 02/12] vl: deprecate -alt-grab and -ctrl-grab, Gerd Hoffmann, 2018/01/29
- [Qemu-devel] [PATCH v2 08/12] curses: use DisplayOptions, Gerd Hoffmann, 2018/01/29