[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 02/19] Clean up includes
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 02/19] Clean up includes |
|
Date: |
Wed, 31 Jan 2018 09:06:01 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 01/31/2018 08:48 AM, Markus Armbruster wrote:
> Clean up includes so that osdep.h is included first and headers
> which it implies are not included manually.
>
> This commit was created with scripts/clean-includes, with the change
> to target/s390x/gen-features.c manually reverted, and blank lines
> around deletions collapsed.
Is it worth tweaking scripts/clean-includes to add gen-features.c to the
whitelist of special cases (alongside *.inc.c, perhaps)?
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 00/19] Clean up includes to reduce compile time, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 01/19] Use #include "..." for our own headers, <...> for others, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 10/19] Include qapi/qmp/qobject.h exactly where needed, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 16/19] Include qapi/qmp/qnull.h exactly where needed, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 03/19] Drop superfluous includes of qapi-types.h and test-qapi-types.h, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 02/19] Clean up includes, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 07/19] Typedef the subtypes of QObject in qemu/typedefs.h, too, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 06/19] Include qmp-commands.h exactly where needed, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 17/19] Drop superfluous includes of qapi/qmp/dispatch.h, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 13/19] Include qapi/qmp/qstring.h exactly where needed, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 05/19] Drop superfluous includes of qapi/qmp/qerror.h, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 09/19] qdict qlist: Make most helper macros functions, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 12/19] Include qapi/qmp/qdict.h exactly where needed, Markus Armbruster, 2018/01/31