qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC v3 00/14] blockjobs: add explicit job management


From: no-reply
Subject: Re: [Qemu-devel] [RFC v3 00/14] blockjobs: add explicit job management
Date: Fri, 26 Jan 2018 18:25:37 -0800 (PST)

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [RFC v3 00/14] blockjobs: add explicit job management

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
10959f8618 iotests: test manual job dismissal
fa3b3419d9 blockjobs: Expose manual property
acf29467dd blockjobs: add block-job-finalize
b8250669f5 blockjobs: add PENDING status and event
67b2f8d3ed blockjobs: Add waiting event
22b6b95b6e blockjobs: add prepare callback
51530e8516 blockjobs: add commit, abort, clean helpers
45761a2219 blockjobs: ensure abort is called for cancelled jobs
d7317d4525 blockjobs: add CONCLUDED state
a4939037ed blockjobs: add block_job_dismiss
83b14366be blockjobs: RFC add block_job_verb permission table
446a6e487b blockjobs: add state transition table
bf5fb419c1 blockjobs: Add status enum
85487f375a blockjobs: add manual property

=== OUTPUT BEGIN ===
Checking PATCH 1/14: blockjobs: add manual property...
Checking PATCH 2/14: blockjobs: Add status enum...
Checking PATCH 3/14: blockjobs: add state transition table...
ERROR: space prohibited before open square bracket '['
#37: FILE: blockjob.c:48:
+    /* U: */ [BLOCK_JOB_STATUS_UNDEFINED] = {0, 1, 0, 0, 0},

ERROR: space prohibited before open square bracket '['
#38: FILE: blockjob.c:49:
+    /* C: */ [BLOCK_JOB_STATUS_CREATED]   = {0, 0, 1, 0, 0},

ERROR: space prohibited before open square bracket '['
#39: FILE: blockjob.c:50:
+    /* R: */ [BLOCK_JOB_STATUS_RUNNING]   = {0, 0, 0, 1, 1},

ERROR: space prohibited before open square bracket '['
#40: FILE: blockjob.c:51:
+    /* P: */ [BLOCK_JOB_STATUS_PAUSED]    = {0, 0, 1, 0, 1},

ERROR: space prohibited before open square bracket '['
#41: FILE: blockjob.c:52:
+    /* Y: */ [BLOCK_JOB_STATUS_READY]     = {0, 0, 0, 1, 0},

total: 5 errors, 0 warnings, 72 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/14: blockjobs: RFC add block_job_verb permission table...
Checking PATCH 5/14: blockjobs: add block_job_dismiss...
Checking PATCH 6/14: blockjobs: add CONCLUDED state...
ERROR: space prohibited before open square bracket '['
#40: FILE: blockjob.c:48:
+    /* U: */ [BLOCK_JOB_STATUS_UNDEFINED] = {0, 1, 0, 0, 0, 0},

ERROR: space prohibited before open square bracket '['
#41: FILE: blockjob.c:49:
+    /* C: */ [BLOCK_JOB_STATUS_CREATED]   = {0, 0, 1, 0, 0, 0},

ERROR: space prohibited before open square bracket '['
#42: FILE: blockjob.c:50:
+    /* R: */ [BLOCK_JOB_STATUS_RUNNING]   = {0, 0, 0, 1, 1, 1},

ERROR: space prohibited before open square bracket '['
#43: FILE: blockjob.c:51:
+    /* P: */ [BLOCK_JOB_STATUS_PAUSED]    = {0, 0, 1, 0, 1, 1},

ERROR: space prohibited before open square bracket '['
#44: FILE: blockjob.c:52:
+    /* Y: */ [BLOCK_JOB_STATUS_READY]     = {0, 0, 0, 1, 0, 1},

ERROR: space prohibited before open square bracket '['
#45: FILE: blockjob.c:53:
+    /* E: */ [BLOCK_JOB_STATUS_CONCLUDED] = {1, 0, 0, 0, 0, 0},

total: 6 errors, 0 warnings, 126 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 7/14: blockjobs: ensure abort is called for cancelled jobs...
Checking PATCH 8/14: blockjobs: add commit, abort, clean helpers...
Checking PATCH 9/14: blockjobs: add prepare callback...
Checking PATCH 10/14: blockjobs: Add waiting event...
ERROR: space prohibited before open square bracket '['
#43: FILE: blockjob.c:48:
+    /* U: */ [BLOCK_JOB_STATUS_UNDEFINED] = {0, 1, 0, 0, 0, 0, 0},

ERROR: space prohibited before open square bracket '['
#44: FILE: blockjob.c:49:
+    /* C: */ [BLOCK_JOB_STATUS_CREATED]   = {0, 0, 1, 0, 0, 0, 0},

ERROR: space prohibited before open square bracket '['
#45: FILE: blockjob.c:50:
+    /* R: */ [BLOCK_JOB_STATUS_RUNNING]   = {0, 0, 0, 1, 1, 1, 1},

ERROR: space prohibited before open square bracket '['
#46: FILE: blockjob.c:51:
+    /* P: */ [BLOCK_JOB_STATUS_PAUSED]    = {0, 0, 1, 0, 1, 0, 1},

ERROR: space prohibited before open square bracket '['
#47: FILE: blockjob.c:52:
+    /* Y: */ [BLOCK_JOB_STATUS_READY]     = {0, 0, 0, 1, 0, 1, 1},

ERROR: space prohibited before open square bracket '['
#48: FILE: blockjob.c:53:
+    /* W: */ [BLOCK_JOB_STATUS_WAITING]   = {0, 0, 0, 0, 0, 0, 1},

ERROR: space prohibited before open square bracket '['
#49: FILE: blockjob.c:54:
+    /* E: */ [BLOCK_JOB_STATUS_CONCLUDED] = {1, 0, 0, 0, 0, 0, 0},

total: 7 errors, 0 warnings, 106 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 11/14: blockjobs: add PENDING status and event...
ERROR: space prohibited before open square bracket '['
#44: FILE: blockjob.c:48:
+    /* U: */ [BLOCK_JOB_STATUS_UNDEFINED] = {0, 1, 0, 0, 0, 0, 0, 0},

ERROR: space prohibited before open square bracket '['
#45: FILE: blockjob.c:49:
+    /* C: */ [BLOCK_JOB_STATUS_CREATED]   = {0, 0, 1, 0, 0, 0, 0, 0},

ERROR: space prohibited before open square bracket '['
#46: FILE: blockjob.c:50:
+    /* R: */ [BLOCK_JOB_STATUS_RUNNING]   = {0, 0, 0, 1, 1, 1, 1, 1},

ERROR: space prohibited before open square bracket '['
#47: FILE: blockjob.c:51:
+    /* P: */ [BLOCK_JOB_STATUS_PAUSED]    = {0, 0, 1, 0, 1, 0, 0, 1},

ERROR: space prohibited before open square bracket '['
#48: FILE: blockjob.c:52:
+    /* Y: */ [BLOCK_JOB_STATUS_READY]     = {0, 0, 0, 1, 0, 1, 1, 1},

ERROR: space prohibited before open square bracket '['
#49: FILE: blockjob.c:53:
+    /* W: */ [BLOCK_JOB_STATUS_WAITING]   = {0, 0, 0, 0, 0, 0, 1, 1},

ERROR: space prohibited before open square bracket '['
#50: FILE: blockjob.c:54:
+    /* D: */ [BLOCK_JOB_STATUS_PENDING]   = {0, 0, 0, 0, 0, 0, 0, 1},

ERROR: space prohibited before open square bracket '['
#51: FILE: blockjob.c:55:
+    /* E: */ [BLOCK_JOB_STATUS_CONCLUDED] = {1, 0, 0, 0, 0, 0, 0, 0},

total: 8 errors, 0 warnings, 107 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 12/14: blockjobs: add block-job-finalize...
Checking PATCH 13/14: blockjobs: Expose manual property...
Checking PATCH 14/14: iotests: test manual job dismissal...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]