[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10.5 12/20] target/arm: Use vector infrastructu
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v10.5 12/20] target/arm: Use vector infrastructure for aa64 add/sub/logic |
Date: |
Thu, 25 Jan 2018 09:06:08 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 01/25/2018 08:44 AM, Peter Maydell wrote:
>> +/* Return the offset info CPUARMState of the "whole" vector register Qn. */
>> +static inline int vec_full_reg_offset(DisasContext *s, int regno)
>> +{
>> + assert_fp_access_checked(s);
>> + return offsetof(CPUARMState, vfp.regs[regno * 2]);
>> +}
>
> This function is already in the preparatory SVE code in target-arm.next,
> so it should go away on rebase...
Ok.
>
>> +
>> +/* Return the byte size of the "whole" vector register, VL / 8. */
>> +static inline int vec_full_reg_size(DisasContext *s)
>> +{
>> + /* FIXME SVE: We should put the composite ZCR_EL* value into tb->flags.
>> + In the meantime this is just the AdvSIMD length of 128. */
>> + return 128 / 8;
>> +}
>
> ...and this is fixed in your other patchset with the leftovers from
> that preparatory set, right? What's the plan for what sequence we
> put these into master?
I had previously assumed that this patch set would go in before all of the
other SVE prep work, though it doesn't seem to be working out that way...
I'd like this one to go in next, fwiw.
> Have you done risu-testing on this patchset?
Yes, I've run the full set of aarch64 risu tests.
r~
- [Qemu-devel] [PATCH v10.5 06/20] tcg: Add generic vector ops for comparisons, (continued)
- [Qemu-devel] [PATCH v10.5 06/20] tcg: Add generic vector ops for comparisons, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10.5 07/20] tcg: Add generic vector ops for multiplication, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10.5 05/20] tcg: Add generic vector ops for constant shifts, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10.5 04/20] tcg: Add generic vector expanders, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10.5 08/20] tcg: Add generic helpers for saturating arithmetic, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10.5 09/20] tcg: Add generic vector helpers with a scalar operand, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10.5 10/20] tcg/optimize: Handle vector opcodes during optimize, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10.5 12/20] target/arm: Use vector infrastructure for aa64 add/sub/logic, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10.5 11/20] target/arm: Align vector registers, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10.5 14/20] target/arm: Use vector infrastructure for aa64 dup/movi, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10.5 13/20] target/arm: Use vector infrastructure for aa64 mov/not/neg, Richard Henderson, 2018/01/17
- [Qemu-devel] [PATCH v10.5 15/20] target/arm: Use vector infrastructure for aa64 constant shifts, Richard Henderson, 2018/01/17