[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 10/14] migration: Add multifd test
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v10 10/14] migration: Add multifd test |
Date: |
Wed, 24 Jan 2018 14:23:33 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
* Juan Quintela (address@hidden) wrote:
> We set the x-multifd-page-count and x-multifd-channels.
>
> Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> tests/migration-test.c | 50
> ++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 50 insertions(+)
>
> diff --git a/tests/migration-test.c b/tests/migration-test.c
> index eb44a95aa9..488ae89f34 100644
> --- a/tests/migration-test.c
> +++ b/tests/migration-test.c
> @@ -826,6 +826,55 @@ static void test_compress_unix(void)
> g_free(uri);
> }
>
> +static void test_multifd_tcp(void)
> +{
> + char *uri;
> + char *port;
> + QTestState *from, *to;
> +
> + test_migrate_start(&from, &to, "tcp:127.0.0.1:0");
> +
> + /* We want to pick a speed slow enough that the test completes
> + * quickly, but that it doesn't complete precopy even on a slow
> + * machine, so also set the downtime.
> + */
> + /* 1 ms should make it not converge*/
> + migrate_set_parameter(from, "downtime-limit", "1");
> + /* 1GB/s */
> + migrate_set_parameter(from, "max-bandwidth", "100000000");
> +
> + migrate_set_parameter(from, "x-multifd-channels", "4");
> + migrate_set_parameter(to, "x-multifd-channels", "4");
> +
> + migrate_set_parameter(from, "x-multifd-page-count", "64");
> + migrate_set_parameter(to, "x-multifd-page-count", "64");
> +
> + migrate_set_capability(from, "x-multifd", "true");
> + migrate_set_capability(to, "x-multifd", "true");
> + /* Wait for the first serial output from the source */
> + wait_for_serial("src_serial");
> +
> + port = migrate_get_parameter(to, "tcp-port");
> + uri = g_strdup_printf("tcp:127.0.0.1:%s", port);
> +
> + migrate(from, uri);
> +
> + wait_for_migration_pass(from);
> +
> + /* 300ms it should converge */
> + migrate_set_parameter(from, "downtime-limit", "300");
> +
> + if (!got_stop) {
> + qtest_qmp_eventwait(from, "STOP");
> + }
> + qtest_qmp_eventwait(to, "RESUME");
> +
> + wait_for_serial("dest_serial");
> + wait_for_migration_complete(from);
> +
> + test_migrate_end(from, to);
> +}
> +
> int main(int argc, char **argv)
> {
> char template[] = "/tmp/migration-test-XXXXXX";
> @@ -853,6 +902,7 @@ int main(int argc, char **argv)
> if (0) {
> qtest_add_func("/migration/compress/unix", test_compress_unix);
> }
> + qtest_add_func("/migration/multifd/tcp", test_multifd_tcp);
>
> ret = g_test_run();
>
> --
> 2.14.3
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH v10 07/14] migration: Create thread infrastructure for multifd recv side, (continued)
- [Qemu-devel] [PATCH v10 07/14] migration: Create thread infrastructure for multifd recv side, Juan Quintela, 2018/01/10
- [Qemu-devel] [PATCH v10 04/14] migration: Start of multiple fd work, Juan Quintela, 2018/01/10
- [Qemu-devel] [PATCH v10 08/14] migration: Transfer pages over new channels, Juan Quintela, 2018/01/10
- [Qemu-devel] [PATCH v10 06/14] migration: Send the fd number which we are going to use for this page, Juan Quintela, 2018/01/10
- [Qemu-devel] [PATCH v10 11/14] LOCAL: use trace events for migration-test, Juan Quintela, 2018/01/10
- [Qemu-devel] [PATCH v10 10/14] migration: Add multifd test, Juan Quintela, 2018/01/10
- Re: [Qemu-devel] [PATCH v10 10/14] migration: Add multifd test,
Dr. David Alan Gilbert <=
- [Qemu-devel] [PATCH v10 09/14] migration: Flush receive queue, Juan Quintela, 2018/01/10
- [Qemu-devel] [PATCH v10 12/14] migration: Sent the page list over the normal thread, Juan Quintela, 2018/01/10
- [Qemu-devel] [PATCH v10 13/14] migration: Add multifd_send_packet trace, Juan Quintela, 2018/01/10
- [Qemu-devel] [PATCH v10 14/14] all works, Juan Quintela, 2018/01/10
- Re: [Qemu-devel] [RFC 00/14] Multifd, Juan Quintela, 2018/01/10