[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v7 04/23] qobject: let object_property_get_str() use
From: |
Peter Xu |
Subject: |
[Qemu-devel] [PATCH v7 04/23] qobject: let object_property_get_str() use new API |
Date: |
Wed, 24 Jan 2018 13:39:38 +0800 |
We can simplify object_property_get_str() using the new
qobject_get_try_str().
Reviewed-by: Fam Zheng <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
---
qom/object.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/qom/object.c b/qom/object.c
index c58c52d518..9cbeb51f0b 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -1116,18 +1116,15 @@ char *object_property_get_str(Object *obj, const char
*name,
Error **errp)
{
QObject *ret = object_property_get_qobject(obj, name, errp);
- QString *qstring;
char *retval;
if (!ret) {
return NULL;
}
- qstring = qobject_to_qstring(ret);
- if (!qstring) {
+
+ retval = g_strdup(qobject_get_try_str(ret));
+ if (!retval) {
error_setg(errp, QERR_INVALID_PARAMETER_TYPE, name, "string");
- retval = NULL;
- } else {
- retval = g_strdup(qstring_get_str(qstring));
}
qobject_decref(ret);
--
2.14.3
- [Qemu-devel] [PATCH v7 00/23] QMP: out-of-band (OOB) execution support, Peter Xu, 2018/01/24
- [Qemu-devel] [PATCH v7 01/23] docs: update QMP documents for OOB commands, Peter Xu, 2018/01/24
- [Qemu-devel] [PATCH v7 02/23] qobject: introduce qstring_get_try_str(), Peter Xu, 2018/01/24
- [Qemu-devel] [PATCH v7 03/23] qobject: introduce qobject_get_try_str(), Peter Xu, 2018/01/24
- [Qemu-devel] [PATCH v7 04/23] qobject: let object_property_get_str() use new API,
Peter Xu <=
- [Qemu-devel] [PATCH v7 05/23] monitor: move skip_flush into monitor_data_init, Peter Xu, 2018/01/24
- [Qemu-devel] [PATCH v7 06/23] monitor: move the cur_mon hack deeper for QMP, Peter Xu, 2018/01/24
- [Qemu-devel] [PATCH v7 07/23] monitor: unify global init, Peter Xu, 2018/01/24
- [Qemu-devel] [PATCH v7 08/23] monitor: let mon_list be tail queue, Peter Xu, 2018/01/24
- [Qemu-devel] [PATCH v7 09/23] monitor: allow using IO thread for parsing, Peter Xu, 2018/01/24
- [Qemu-devel] [PATCH v7 10/23] qmp: introduce QMPCapability, Peter Xu, 2018/01/24
- [Qemu-devel] [PATCH v7 11/23] monitor: introduce monitor_qmp_respond(), Peter Xu, 2018/01/24
- [Qemu-devel] [PATCH v7 12/23] monitor: let suspend_cnt be thread safe, Peter Xu, 2018/01/24
- [Qemu-devel] [PATCH v7 13/23] monitor: let suspend/resume work even with QMPs, Peter Xu, 2018/01/24
- [Qemu-devel] [PATCH v7 14/23] monitor: separate QMP parser and dispatcher, Peter Xu, 2018/01/24