Re: [Qemu-devel] [PATCH] linux-user: implement renameat2

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH] linux-user: implement renameat2

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
59d79798ac linux-user: implement renameat2

=== OUTPUT BEGIN ===
Checking PATCH 1/1: linux-user: implement renameat2...
WARNING: architecture specific defines should be avoided
#21: FILE: linux-user/syscall.c:602:
+#if defined(__NR_renameat2)

ERROR: spaces required around that '*' (ctx:WxV)
#27: FILE: linux-user/syscall.c:608:
+                         int newfd, const chat *new, int flags)
                                                ^

ERROR: braces {} are necessary for all arms of this statement
#29: FILE: linux-user/syscall.c:610:
+    if (flags == 0)
[...]

ERROR: braces {} are necessary for all arms of this statement
#50: FILE: linux-user/syscall.c:8368:
+            if (!p || !p2)
[...]
+            else
[...]

ERROR: line over 90 characters
#54: FILE: linux-user/syscall.c:8372:
+                                              target_to_host_bitmask(arg5, 
fcntl_flags_tbl)));

total: 4 errors, 1 warnings, 45 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden