Re: [Qemu-devel] [PULL 00/27] Migration pull

[Philippe Mathieu-Daudé]

On 01/19/2018 01:34 PM, Peter Maydell wrote:
> On 19 January 2018 at 16:27, Philippe Mathieu-Daudé <address@hidden> wrote:
>> We have armel/armhf/powerpc hosts failing since this pull due to commit
>> 3be98be4e9f.
>>
>> Those target are currently tested on Shippable CI, eventually adding an
>> IRC bot we could notice.
>>
>> I know companies using QEMU system in embedded armel/armhf hosts, I
>> don't know about the ppc32 hosts.
>> This is however unlikely the migration features are used there.
> 
> I have ppc64 and armhf in my test set, so clearly they don't all
> fail all the time. What are the failure symptoms ?

I misread Shippable report with the report trying to fix this,
so indeed on /master, only ppc32 is broken, the symtom is linking failing:

https://app.shippable.com/github/qemu/qemu/runs/665/10/console

../migration/postcopy-ram.o: In function `mark_postcopy_blocktime_end':
/root/src/github.com/qemu/qemu/migration/postcopy-ram.c:717: undefined
reference to `__atomic_fetch_add_8'
/root/src/github.com/qemu/qemu/migration/postcopy-ram.c:738: undefined
reference to `__atomic_fetch_add_8'
../migration/postcopy-ram.o: In function `mark_postcopy_blocktime_begin':
/root/src/github.com/qemu/qemu/migration/postcopy-ram.c:651: undefined
reference to `__atomic_exchange_8'
/root/src/github.com/qemu/qemu/migration/postcopy-ram.c:652: undefined
reference to `__atomic_exchange_8'
/root/src/github.com/qemu/qemu/migration/postcopy-ram.c:661: undefined
reference to `__atomic_exchange_8'
collect2: error: ld returned 1 exit status
Makefile:193: recipe for target 'qemu-system-ppc' failed
make[1]: *** [qemu-system-ppc] Error 1
Makefile:391: recipe for target 'subdir-ppc-softmmu' failed
make: *** [subdir-ppc-softmmu] Error 2

../migration/postcopy-ram.o: In function `mark_postcopy_blocktime_end':
/root/src/github.com/qemu/qemu/migration/postcopy-ram.c:717: undefined
reference to `__atomic_fetch_add_8'
/root/src/github.com/qemu/qemu/migration/postcopy-ram.c:738: undefined
reference to `__atomic_fetch_add_8'
../migration/postcopy-ram.o: In function `mark_postcopy_blocktime_begin':
/root/src/github.com/qemu/qemu/migration/postcopy-ram.c:651: undefined
reference to `__atomic_exchange_8'
/root/src/github.com/qemu/qemu/migration/postcopy-ram.c:652: undefined
reference to `__atomic_exchange_8'
/root/src/github.com/qemu/qemu/migration/postcopy-ram.c:661: undefined
reference to `__atomic_exchange_8'
collect2: error: ld returned 1 exit status
Makefile:193: recipe for target 'qemu-system-ppcemb' failed
make[1]: *** [qemu-system-ppcemb] Error 1
Makefile:391: recipe for target 'subdir-ppcemb-softmmu' failed
make: *** [subdir-ppcemb-softmmu] Error 2

The armel/armhf failures are when I apply this patch:

http://lists.nongnu.org/archive/html/qemu-devel/2018-01/msg04873.html

In file included from
/root/src/github.com/philmd/qemu/include/qemu/osdep.h:36:0,
                 from migration/postcopy-ram.c:19:
migration/postcopy-ram.c: In function 'mark_postcopy_blocktime_begin':
/root/src/github.com/philmd/qemu/include/qemu/compiler.h:86:30: error:
static assertion failed: "not expecting: sizeof(*&dc->last_begin) >
ATOMIC_REG_SIZE"
 #define QEMU_BUILD_BUG_ON(x) _Static_assert(!(x), "not expecting: " #x)
                              ^
/root/src/github.com/philmd/qemu/include/qemu/atomic.h:183:5: note: in
expansion of macro 'QEMU_BUILD_BUG_ON'
     QEMU_BUILD_BUG_ON(sizeof(*ptr) > ATOMIC_REG_SIZE);      \
     ^~~~~~~~~~~~~~~~~
migration/postcopy-ram.c:651:5: note: in expansion of macro 'atomic_xchg'
     atomic_xchg(&dc->last_begin, now_ms);
     ^~~~~~~~~~~
/root/src/github.com/philmd/qemu/include/qemu/compiler.h:86:30: error:
static assertion failed: "not expecting:
sizeof(*&dc->page_fault_vcpu_time[cpu]) > ATOMIC_REG_SIZE"
 #define QEMU_BUILD_BUG_ON(x) _Static_assert(!(x), "not expecting: " #x)
                              ^
/root/src/github.com/philmd/qemu/include/qemu/atomic.h:183:5: note: in
expansion of macro 'QEMU_BUILD_BUG_ON'
     QEMU_BUILD_BUG_ON(sizeof(*ptr) > ATOMIC_REG_SIZE);      \
     ^~~~~~~~~~~~~~~~~
migration/postcopy-ram.c:652:5: note: in expansion of macro 'atomic_xchg'
     atomic_xchg(&dc->page_fault_vcpu_time[cpu], now_ms);
     ^~~~~~~~~~~
/root/src/github.com/philmd/qemu/include/qemu/compiler.h:86:30: error:
static assertion failed: "not expecting:
sizeof(*&dc->page_fault_vcpu_time[cpu]) > ATOMIC_REG_SIZE"
 #define QEMU_BUILD_BUG_ON(x) _Static_assert(!(x), "not expecting: " #x)
                              ^
/root/src/github.com/philmd/qemu/include/qemu/atomic.h:183:5: note: in
expansion of macro 'QEMU_BUILD_BUG_ON'
     QEMU_BUILD_BUG_ON(sizeof(*ptr) > ATOMIC_REG_SIZE);      \
     ^~~~~~~~~~~~~~~~~
migration/postcopy-ram.c:661:9: note: in expansion of macro 'atomic_xchg'
         atomic_xchg(&dc->page_fault_vcpu_time[cpu], 0);
         ^~~~~~~~~~~
/root/src/github.com/philmd/qemu/rules.mak:66: recipe for target
'migration/postcopy-ram.o' failed
make: *** [migration/postcopy-ram.o] Error 1
make: *** Waiting for unfinished jobs....