[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 1/2] memory: do explicit cleanup when remove liste
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC 1/2] memory: do explicit cleanup when remove listeners |
Date: |
Fri, 19 Jan 2018 11:21:36 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 19/01/2018 09:42, Peter Xu wrote:
> + FOR_EACH_FLAT_RANGE(fr, view) {
listener->begin is missing before the loop.
Paolo
> + MemoryRegionSection section = section_from_flat_range(fr, view);
> +
> + if (fr->dirty_log_mask && listener->log_stop) {
> + listener->log_stop(listener, §ion, fr->dirty_log_mask, 0);
> + }
> + if (listener->region_del) {
> + listener->region_del(listener, §ion);
> + }
> + }
> + if (listener->commit) {
> + listener->commit(listener);
> + }
> + flatview_unref(view);