[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/6] hmp: add name parameter to nbd_server_ad
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/6] hmp: add name parameter to nbd_server_add |
Date: |
Thu, 18 Jan 2018 15:08:36 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 01/18/2018 12:11 PM, Vladimir Sementsov-Ogievskiy wrote:
> Support name parameter for HMP too.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> hmp.c | 3 ++-
> hmp-commands.hx | 9 +++++----
> 2 files changed, 7 insertions(+), 5 deletions(-)
>
> +++ b/hmp-commands.hx
> @@ -1553,8 +1553,8 @@ ETEXI
>
> {
> .name = "nbd_server_add",
> - .args_type = "writable:-w,device:B",
> - .params = "nbd_server_add [-w] device",
> + .args_type = "name:-n,writable:-w,device:B",
> + .params = "nbd_server_add [-n] [-w] device",
Doesn't quite look like my proposal:
https://lists.gnu.org/archive/html/qemu-devel/2018-01/msg01639.html
- .args_type = "writable:-w,device:B",
- .params = "nbd_server_add [-w] device",
+ .args_type = "writable:-w,device:B,name:s?",
+ .params = "nbd_server_add [-w] device [name]",
In fact, using -n is not quite right, because that's just a boolean flag
rather than a string.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/6] nbd export qmp interface, Vladimir Sementsov-Ogievskiy, 2018/01/18
- [Qemu-devel] [PATCH v2 5/6] iotests: implement QemuIoInteractive class, Vladimir Sementsov-Ogievskiy, 2018/01/18
- [Qemu-devel] [PATCH v2 3/6] qapi: add nbd-server-remove, Vladimir Sementsov-Ogievskiy, 2018/01/18
- [Qemu-devel] [PATCH v2 6/6] iotest 201: new test for qmp nbd-server-remove, Vladimir Sementsov-Ogievskiy, 2018/01/18
- [Qemu-devel] [PATCH v2 4/6] iotest 147: add cases to test new @name parameter of nbd-server-add, Vladimir Sementsov-Ogievskiy, 2018/01/18
- [Qemu-devel] [PATCH v2 1/6] qapi: add name parameter to nbd-server-add, Vladimir Sementsov-Ogievskiy, 2018/01/18
- [Qemu-devel] [PATCH v2 2/6] hmp: add name parameter to nbd_server_add, Vladimir Sementsov-Ogievskiy, 2018/01/18
- Re: [Qemu-devel] [PATCH v2 2/6] hmp: add name parameter to nbd_server_add,
Eric Blake <=
- Re: [Qemu-devel] [PATCH v2 0/6] nbd export qmp interface, Eric Blake, 2018/01/18