qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v7 16/16] sdhci: throw an error if capabilities


From: Alistair Francis
Subject: Re: [Qemu-devel] [PATCH v7 16/16] sdhci: throw an error if capabilities are incorrectly configured
Date: Thu, 18 Jan 2018 10:19:53 -0800

On Thu, Jan 18, 2018 at 4:32 AM, Philippe Mathieu-Daudé <address@hidden> wrote:
> now than the Exynos4210 uses the 'capareg-reserved' property,
> we can safely report missing capabilities as error, since
> capabilities will only get changed once new SDHCI models
> are added.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>

Reviewed-by: Alistair Francis <address@hidden>

Alistair

> ---
>  hw/sd/sdhci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
> index 7799382e89..07a7ebcc1e 100644
> --- a/hw/sd/sdhci.c
> +++ b/hw/sd/sdhci.c
> @@ -23,7 +23,6 @@
>   */
>
>  #include "qemu/osdep.h"
> -#include "qemu/error-report.h"
>  #include "qapi/error.h"
>  #include "hw/hw.h"
>  #include "sysemu/block-backend.h"
> @@ -1208,7 +1207,8 @@ static void sdhci_init_readonly_registers(SDHCIState 
> *s, Error **errp)
>      } else {
>          capab = s->capareg & ~capab;
>          if (capab) {
> -            warn_report("SDHCI: missing capability mask: 0x%" PRIx64, capab);
> +            error_setg(errp, "missing capability mask: 0x%" PRIx64, capab);
> +            return;
>          }
>      }
>  }
> --
> 2.15.1
>
>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]