[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 08/16] sdhci: add basic Spec v1 capabilities
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v7 08/16] sdhci: add basic Spec v1 capabilities |
|
Date: |
Thu, 18 Jan 2018 17:04:17 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 18/01/2018 16:45, Philippe Mathieu-Daudé wrote:
>> s->version = (SDHC_HCVER_VENDOR << 8) | (s->spec_version - 1);
>>
>> + capab = sdhci_init_capareg(s, errp);
>> + if (errp && *errp) {
> Paolo said this is wrong, I'll resping using UINT64_MAX as error and
> checking "if (capab == UINT64_MAX) { return; }"
If all-ones capabilities is valid or can be valid in the future, then
perhaps it is better to use local_err, and not use the return value at
all if local_err != NULL.
Paolo
- [Qemu-devel] [PATCH v7 05/16] sdhci: add qtest to check the SD Spec version, (continued)
[Qemu-devel] [PATCH v7 08/16] sdhci: add basic Spec v1 capabilities, Philippe Mathieu-Daudé, 2018/01/18
[Qemu-devel] [PATCH v7 09/16] sdhci: add max-block-length capability (Spec v1), Philippe Mathieu-Daudé, 2018/01/18
[Qemu-devel] [PATCH v7 12/16] sdhci: Fix 64-bit ADMA2, Philippe Mathieu-Daudé, 2018/01/18
[Qemu-devel] [PATCH v7 14/16] hw/arm/xilinx_zynq: implement SDHCI Spec v2, Philippe Mathieu-Daudé, 2018/01/18
[Qemu-devel] [PATCH v7 15/16] hw/arm/exynos4210: implement SDHCI Spec v2, Philippe Mathieu-Daudé, 2018/01/18
[Qemu-devel] [PATCH v7 16/16] sdhci: throw an error if capabilities are incorrectly configured, Philippe Mathieu-Daudé, 2018/01/18