|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [PATCH v7 06/16] sdhci: add init_readonly_registers() to initialize the CAPAB register |
| Date: | Thu, 18 Jan 2018 17:00:42 +0100 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 18/01/2018 16:44, Philippe Mathieu-Daudé wrote:
>> static void sdhci_common_realize(SDHCIState *s, Error **errp)
>> {
>> + sdhci_init_readonly_registers(s, errp);
>> + if (errp && *errp) {
> Paolo said this is wrong (as in bad pattern?).
>
> I will respin probably using 'bool sdhci_init_readonly_registers()' instead.
>
Please use the local_err idiom instead.
Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |