[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/4] linux-user: MIPS set cpu to r6 CPU if bi
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/4] linux-user: MIPS set cpu to r6 CPU if binary is R6 |
Date: |
Tue, 16 Jan 2018 23:01:17 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
Le 16/01/2018 à 21:26, Richard Henderson a écrit :
> On 01/16/2018 09:25 AM, Laurent Vivier wrote:
>> From: YunQiang Su <address@hidden>
>>
>> So here we need to detect the version of binaries and set
>> cpu_model for it.
>>
>> [lv: original patch modified to move code into cpu_get_model()]
>> Signed-off-by: Laurent Vivier <address@hidden>
>> ---
>
> Reviewed-by: Richard Henderson <address@hidden>
>
>> static inline const char *cpu_get_model(uint32_t eflags)
>> {
>> + if ((eflags & EF_MIPS_ARCH_32R6) != 0) {
>> + return "mips32r6-generic";
>> + }
>> return "24Kf";
>
> That said, I don't suppose it's worth diagnosing cases that we can't support
> somehow? E.g. mips-linux-user and EF_MIPS_ARCH_64. Or even coldfire ISA-C.
Yes, the idea is "if we don't know, do as before":
the real error will be reported by the loader.
Thanks,
Laurent
- [Qemu-devel] [PATCH v2 0/4] linux-user: select CPU type according ELF header values, Laurent Vivier, 2018/01/16
- [Qemu-devel] [PATCH v2 3/4] linux-user, m68k: select CPU according to ELF header values, Laurent Vivier, 2018/01/16
- [Qemu-devel] [PATCH v2 4/4] linux-user: MIPS set cpu to r6 CPU if binary is R6, Laurent Vivier, 2018/01/16
- [Qemu-devel] [PATCH v2 2/4] linux-user: introduce functions to detect CPU type, Laurent Vivier, 2018/01/16
- [Qemu-devel] [PATCH v2 1/4] linux-user: Move CPU type name selection to a function, Laurent Vivier, 2018/01/16
- Re: [Qemu-devel] [PATCH v2 0/4] linux-user: select CPU type according ELF header values, no-reply, 2018/01/17