[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/4] cryptodev-vhost-user: add crypto session
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/4] cryptodev-vhost-user: add crypto session handler |
Date: |
Tue, 16 Jan 2018 06:24:04 +0200 |
On Sat, Dec 30, 2017 at 04:52:12PM +0800, Jay Zhou wrote:
> diff --git a/docs/interop/vhost-user.txt b/docs/interop/vhost-user.txt
> index 954771d..f43c63d 100644
> --- a/docs/interop/vhost-user.txt
> +++ b/docs/interop/vhost-user.txt
> @@ -596,6 +596,25 @@ Master message types
> and expect this message once (per VQ) during device configuration
> (ie. before the master starts the VQ).
>
> + * VHOST_USER_CREATE_CRYPTO_SESSION
> +
> + Id: 23
> + Equivalent ioctl: N/A
> + Master payload: crypto session description
> + Slave payload: crypto session description
> +
> + Create a session for crypto operation. The server side must return the
> + session id, 0 or positive for success, negative for failure.
> +
> + * VHOST_USER_CLOSE_CRYPTO_SESSION
> +
> + Id: 24
> + Equivalent ioctl: N/A
> + Master payload: u64
> +
> + Close a session for crypto operation which was previously
> + created by VHOST_USER_CREATE_CRYPTO_SESSION.
> +
> Slave message types
> -------------------
>
Sorry about a delayed response.
So an issue with this patchset is that you are adding
new messages unconditionally.
You must add a protocol bit whenever you add new messages.
If appropriate, you can document that it's a required feature for crypto
devices.
--
MST
- Re: [Qemu-devel] [PATCH v2 3/4] cryptodev-vhost-user: add crypto session handler,
Michael S. Tsirkin <=