Re: [Qemu-devel] [PATCH v2 0/2] sdl: hotkey updates and cleanups

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 0/2] sdl: hotkey updates and cleanups

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
069b912d67 sdl: reorganize -no-frame support
e25380fb5c sdl: use ctrl-alt-g as grab hotkey

=== OUTPUT BEGIN ===
Checking PATCH 1/2: sdl: use ctrl-alt-g as grab hotkey...
Checking PATCH 2/2: sdl: reorganize -no-frame support...
ERROR: braces {} are necessary for all arms of this statement
#68: FILE: ui/sdl.c:116:
+    if (no_frame)
[...]

ERROR: do not initialise globals to 0 or NULL
#132: FILE: vl.c:153:
+int no_frame = 0;

total: 2 errors, 0 warnings, 97 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden