[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 03/13] qapi: Use OrderedDict from standard li
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v3 03/13] qapi: Use OrderedDict from standard library if available |
Date: |
Mon, 15 Jan 2018 07:39:13 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 01/15/2018 07:26 AM, Daniel P. Berrange wrote:
> The OrderedDict class appeared in the 'collections' module
> from python 2.7 onwards, so use that in preference to our
> local backport if available.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> scripts/qapi.py | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/qapi.py b/scripts/qapi.py
> index 5ef50317ca..7ec2e00b2c 100644
> --- a/scripts/qapi.py
> +++ b/scripts/qapi.py
> @@ -18,7 +18,10 @@ import os
> import re
> import string
> import sys
> -from ordereddict import OrderedDict
> +try:
> + from collections import OrderedDict
> +except:
> + from ordereddict import OrderedDict
>
> builtin_types = {
> 'null': 'QTYPE_QNULL',
>
- [Qemu-devel] [PATCH v3 00/13] Support building with py2 or py3, Daniel P. Berrange, 2018/01/15
- [Qemu-devel] [PATCH v3 01/13] qapi: convert to use python print function instead of statement, Daniel P. Berrange, 2018/01/15
- [Qemu-devel] [PATCH v3 03/13] qapi: Use OrderedDict from standard library if available, Daniel P. Berrange, 2018/01/15
- Re: [Qemu-devel] [PATCH v3 03/13] qapi: Use OrderedDict from standard library if available,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v3 02/13] qapi: use items()/values() intead of iteritems()/itervalues(), Daniel P. Berrange, 2018/01/15
- [Qemu-devel] [PATCH v3 04/13] qapi: adapt to moved location of StringIO module in py3, Daniel P. Berrange, 2018/01/15
- [Qemu-devel] [PATCH v3 05/13] qapi: Adapt to moved location of 'maketrans' function in py3, Daniel P. Berrange, 2018/01/15
- [Qemu-devel] [PATCH v3 06/13] qapi: remove '-q' arg to diff when comparing QAPI output, Daniel P. Berrange, 2018/01/15
- [Qemu-devel] [PATCH v3 07/13] qapi: ensure stable sort ordering when checking QAPI entities, Daniel P. Berrange, 2018/01/15
- [Qemu-devel] [PATCH v3 08/13] scripts: ensure signrom treats data as bytes, Daniel P. Berrange, 2018/01/15