qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] scsi: handle the special parameters


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] scsi: handle the special parameters
Date: Mon, 15 Jan 2018 10:29:32 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0

On 15/01/2018 05:16, linzhecheng wrote:
> scsi_disk_emulate_command calls
> scsi_build_sense(NULL, 0, outbuf, r->buflen,
>                                   (req->cmd.buf[1] & 1) == 0);
> But scsi_convert_sense doesn't handle the case when in_buf is NULL
> or in_len is 0, which will lead to segfault.
> 

This is already fixed in my last pull request.

Paolo

> Signed-off-by: linzhecheng <address@hidden>
> ---
>  scsi/utils.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/scsi/utils.c b/scsi/utils.c
> index ddae650a99..b769e80c12 100644
> --- a/scsi/utils.c
> +++ b/scsi/utils.c
> @@ -322,6 +322,10 @@ int scsi_convert_sense(uint8_t *in_buf, int in_len,
>      SCSISense sense;
>      bool fixed_in;
>  
> +    if (!in_buf || !in_len) {
> +        return 0;
> +    }
> +
>      fixed_in = (in_buf[0] & 2) == 0;
>      if (in_len && fixed == fixed_in) {
>          memcpy(buf, in_buf, MIN(len, in_len));
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]