[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 2/9] ui: deprecate use of GTK 2.x in favour of 3.x se
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 2/9] ui: deprecate use of GTK 2.x in favour of 3.x series |
Date: |
Fri, 12 Jan 2018 15:52:51 +0100 |
From: "Daniel P. Berrange" <address@hidden>
The GTK 3.0 release was made in Feb, 2011:
https://blog.gtk.org/2011/02/10/gtk-3-0-released/
That will soon be 7 years ago, which is enough time to consider
the 3.x series widely supported.
Thus we deprecate the GTK 2.x support, which will allow us to
delete it in the last release of 2018. By this time, GTK 3.x
will be almost 8 years old.
Signed-off-by: Daniel P. Berrange <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
---
configure | 6 ++++++
ui/gtk.c | 5 +++++
qemu-doc.texi | 9 +++++++++
3 files changed, 20 insertions(+)
diff --git a/configure b/configure
index 89bd662a6a..b272a0336b 100755
--- a/configure
+++ b/configure
@@ -5629,6 +5629,12 @@ if test "$sdl_too_old" = "yes"; then
echo "-> Your SDL version is too old - please upgrade to have SDL support"
fi
+if test "$gtkabi" = "2.0"; then
+ echo
+ echo "WARNING: Use of GTK 2.0 is deprecated and will be removed in"
+ echo "WARNING: future releases. Please switch to using GTK 3.0"
+fi
+
if test "$supported_cpu" = "no"; then
echo
echo "WARNING: SUPPORT FOR THIS HOST CPU WILL GO AWAY IN FUTURE RELEASES!"
diff --git a/ui/gtk.c b/ui/gtk.c
index 342e96fbe9..f3b7567984 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -2248,6 +2248,11 @@ void gtk_display_init(DisplayState *ds, bool
full_screen, bool grab_on_hover)
exit(1);
}
+#if !GTK_CHECK_VERSION(3, 0, 0)
+ g_printerr("Running QEMU with GTK 2.x is deprecated, and will be removed\n"
+ "in a future release. Please switch to GTK 3.x instead\n");
+#endif
+
s->window = gtk_window_new(GTK_WINDOW_TOPLEVEL);
#if GTK_CHECK_VERSION(3, 2, 0)
s->vbox = gtk_box_new(GTK_ORIENTATION_VERTICAL, 0);
diff --git a/qemu-doc.texi b/qemu-doc.texi
index a3d2054c90..3e9eb819a6 100644
--- a/qemu-doc.texi
+++ b/qemu-doc.texi
@@ -2587,6 +2587,15 @@ they were first deprecated in the 2.10.0 release.
What follows is a list of all features currently marked as
deprecated.
address@hidden Build options
+
address@hidden GTK 2.x
+
+Previously QEMU has supported building against both GTK 2.x
+and 3.x series APIs. Support for the GTK 2.x builds will be
+discontinued, so maintainers should switch to using GTK 3.x,
+which is the default.
+
@section System emulator command line arguments
@subsection -tdf (since 1.3.0)
--
2.9.3
- [Qemu-devel] [PULL 0/9] Ui 20180112 patches, Gerd Hoffmann, 2018/01/12
- [Qemu-devel] [PULL 3/9] spice: remove QXLWorker interface field, Gerd Hoffmann, 2018/01/12
- [Qemu-devel] [PULL 4/9] spice: remove unused watch list, Gerd Hoffmann, 2018/01/12
- [Qemu-devel] [PULL 1/9] input: fix memory leak, Gerd Hoffmann, 2018/01/12
- [Qemu-devel] [PULL 8/9] sdl2 uses surface relative coordinates, Gerd Hoffmann, 2018/01/12
- [Qemu-devel] [PULL 5/9] spice: remove only written event_mask field, Gerd Hoffmann, 2018/01/12
- [Qemu-devel] [PULL 6/9] spice: remove unused timer list, Gerd Hoffmann, 2018/01/12
- [Qemu-devel] [PULL 2/9] ui: deprecate use of GTK 2.x in favour of 3.x series,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 9/9] sdl2: Ignore UI hotkeys after a focus change when GUI modifier is held, Gerd Hoffmann, 2018/01/12
- [Qemu-devel] [PULL 7/9] sdl2: Do not hide the cursor on auxilliary windows, Gerd Hoffmann, 2018/01/12
- Re: [Qemu-devel] [PULL 0/9] Ui 20180112 patches, Peter Maydell, 2018/01/15