[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 10/16] piix4: add a i8042 keyboard/mouse cont
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v4 10/16] piix4: add a i8042 keyboard/mouse controller as specified in datasheet |
Date: |
Sun, 7 Jan 2018 13:51:10 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
Hi Hervé,
On 01/06/2018 12:37 PM, Hervé Poussineau wrote:
> Remove i8042 instanciated in malta board, to not have it twice.
Even if this works, I'm not 100% sure this is correct, since the Malta
board uses the i8042 from the FDC37M817 superio, not from the PIIX4E
southbridge.
I think the problem is this is unclear which PIIX4 is modelled in QEMU.
Apparently this code comes from the i440fx which southbridge companion
is the PIIX3 (what Virtual PC 2007 uses?).
If so, we should model the 2 devices (PIIX3 + PIIX4E for Malta).
>
> Acked-by: Michael S. Tsirkin <address@hidden>
> Acked-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Hervé Poussineau <address@hidden>
> ---
> hw/isa/piix4.c | 3 +++
> hw/mips/mips_malta.c | 2 --
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
> index 3f59750e5a..1aab78cdd2 100644
> --- a/hw/isa/piix4.c
> +++ b/hw/isa/piix4.c
> @@ -169,6 +169,9 @@ static void piix4_realize(PCIDevice *pci_dev, Error
> **errp)
> /* DMA */
> DMA_init(isa_bus, 0);
>
> + /* Super I/O */
> + isa_create_simple(isa_bus, "i8042");
> +
> piix4_dev = pci_dev;
> qemu_register_reset(piix4_reset, s);
> }
> diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
> index afe13c684f..7498fad006 100644
> --- a/hw/mips/mips_malta.c
> +++ b/hw/mips/mips_malta.c
> @@ -1204,8 +1204,6 @@ void mips_malta_init(MachineState *machine)
> g_free(smbus_eeprom_buf);
>
> /* Super I/O */
> - isa_create_simple(isa_bus, "i8042");
> -
> mc146818_rtc_init(isa_bus, 2000, NULL);
> serial_hds_isa_init(isa_bus, 0, 2);
> parallel_hds_isa_init(isa_bus, 1);
>
- [Qemu-devel] [PATCH v4 00/16] piix4: cleanup and improvements, Hervé Poussineau, 2018/01/06
- [Qemu-devel] [PATCH v4 06/16] piix4: add Reset Control Register, Hervé Poussineau, 2018/01/06
- [Qemu-devel] [PATCH v4 03/16] mc146818rtc: move structure to header file, Hervé Poussineau, 2018/01/06
- [Qemu-devel] [PATCH v4 02/16] serial/parallel: move object structures to header file, Hervé Poussineau, 2018/01/06
- [Qemu-devel] [PATCH v4 07/16] piix4: add a i8259 interrupt controller as specified in datasheet, Hervé Poussineau, 2018/01/06
- [Qemu-devel] [PATCH v4 10/16] piix4: add a i8042 keyboard/mouse controller as specified in datasheet, Hervé Poussineau, 2018/01/06
- Re: [Qemu-devel] [PATCH v4 10/16] piix4: add a i8042 keyboard/mouse controller as specified in datasheet,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v4 08/16] piix4: add a i8257 dma controller as specified in datasheet, Hervé Poussineau, 2018/01/06
- [Qemu-devel] [PATCH v4 01/16] fdc: move object structures to header file, Hervé Poussineau, 2018/01/06
- [Qemu-devel] [PATCH v4 05/16] piix4: rename some variables in realize function, Hervé Poussineau, 2018/01/06
- [Qemu-devel] [PATCH v4 09/16] piix4: add a i8254 pit controller as specified in datasheet, Hervé Poussineau, 2018/01/06
- [Qemu-devel] [PATCH v4 04/16] mc146818rtc: always register rtc to rtc list, Hervé Poussineau, 2018/01/06
- [Qemu-devel] [PATCH v4 11/16] piix4: add a floppy controller, 1 parallel port and 2 serial ports, Hervé Poussineau, 2018/01/06
- [Qemu-devel] [PATCH v4 13/16] piix4: add a speaker as specified in datasheet, Hervé Poussineau, 2018/01/06