Re: [Qemu-devel] [PATCH v1 06/19] fpu/softfloat: propagate signalling NaNs in MINMAX

[Alex Bennée]

Richard Henderson <address@hidden> writes:

> On 12/11/2017 04:56 AM, Alex Bennée wrote:
>> While a comparison between a QNaN and a number will return the number
>> it is not the same with a signaling NaN. In this case the SNaN will
>> "win" and after potentially raising an exception it will be quietened.
>>
>> Signed-off-by: Alex Bennée <address@hidden>
>>
>> ---
>> v2
>>   - added return for propageFloat
>> ---
>>  fpu/softfloat.c | 8 ++++++--
>>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> I suppose this fixes minmax for float128 too,
> and is thus not redundant with patch 18?

It was never expanded so I guess no one does float128 minmax's at the moment.

>
> Reviewed-by: Richard Henderson <address@hidden>
>
>
> r~


--
Alex Bennée