Re: [Qemu-devel] [PATCH v3 00/16] piix4: cleanup and improvements

[Philippe Mathieu-Daudé]

>> This patchset is a cleanup of the PIIX4 PCI-ISA bridge. Lots of devices
>> are moved from MIPS Malta board (which has a PIIX4) to PIIX4, where devices
>> belong. This lets us reuse PIIX4 in other machines, while not loosing any
>> functionality.
>>
>> Last patch allows adding a new PIIX4 device directly from command line.
>> Note that this will work only as long no other ISA bus already exist on the
>> machine.
>
> Thanks, I think this is the right place to draw the line.  The more
> "correct" one would be like pc87312, where the serial and parallel ports
> are e.g. also included in the SuperI/O chip, but then you get

Yes, this is how I did in my "remove 'i386/pc.h' dependency" series ...

>
>             /* FIXME use a qdev chardev prop instead of serial_hds[] */
>             chr = serial_hds[i];
>
> so you have to mark the bridge as not user-creatable.

... using qdev chardev and getting ride of this serial_hds[] limitation.

I suggested Hervé we have an IRC meeting today at 7PM GMT+1 to talk
about sharing common efforts.